Fwd: [DISCUSS] Formalizing requirements for pre-commit patches on new CI

2023-07-05 Thread Ekaterina Dimitrova
“I'm curious what it triggers for you Brandon, Berenguer, Andres, Ekaterina, and Mick (when you're back from the mountains ;)). ” We already have pre-commit a minimum set being mandatory in CircleCI. People can manually trigger other tests if they feel they might have broken something. The only tes

Re: JDK 17 Support Proposal for ant generate-idea-files in CASSANDRA-18467

2023-07-05 Thread Ekaterina Dimitrova
Dear all, Thanks to everyone who shared feedback and tested the changes. The patch was committed. ‘ant generate-idea-files’ now support JDK8, JDK11, and JDK17 To add support for another JDK the java-jvmargs property must be set for the JDK in question (see how it’s done in build.xml for Java 11 a

Re: [DISCUSS] Formalizing requirements for pre-commit patches on new CI

2023-07-05 Thread Josh McKenzie
> choose a consistent, representative subset of stable tests that we feel give > us a reasonable level of confidence in return for a reasonable amount of > runtime > > ... > Currently a dtest is being ran in j8 w/wo vnodes , j8/j11 w/wo vnodes and j11 > w/wo vnodes. That is 6 times total. I won

Re: [DISCUSS] Formalizing requirements for pre-commit patches on new CI

2023-07-05 Thread Jacek Lewandowski
Perhaps pre-commit checks should include mostly the typical configuration of Cassandra rather than some subset of possible combinations. Like it was said somewhere above - test with the default number of vnodes, test with the default compression settings, and test with the default heap/off-heap buf