Re: [DISCUSS] Adding dependency to the Big-Math library from eobermuhlner

Seems well maintained and MIT licensed. +1 from me. > On Nov 28, 2022, at 6:35 PM, Derek Chen-Becker wrote: > > Overall the library appears to be high quality, even going so far as > to have regression tests between versions. I do, however, think that > the long-term maintenance risk needs to b

Re: [DISCUSS] Adding dependency to the Big-Math library from eobermuhlner

Overall the library appears to be high quality, even going so far as to have regression tests between versions. I do, however, think that the long-term maintenance risk needs to be acknowledged here. I think the *absolute* worst case scenario would be corruption or deletion of source and artifacts,

Re: [DISCUSSION] Cassandra's code style and source code analysis

I can put few sentences in this context, because my involvement into Cassandra mailing list started with looking at build system. It was 8 or maybe 9 years ago. Simple fact that Cassandra core team do understand their chain of Ant task execution doesn't automatically make all other contributor

Re: [DISCUSSION] Cassandra's code style and source code analysis

On the topic of code style, the wiki not only covers many elements of style that are impossible to encode in a linter, but explicitly uses terminology on many lintable items that is not “hard.” I should know, I formulated it this way deliberately, and made this explicit in the discussion while s

Re: [DISCUSSION] Cassandra's code style and source code analysis

Scott makes some valid points about legitimate benefits. I personally doubt the high upfront cost of migration will take less than a decade to pay back in time saved managing shims. But, it’s a tangible justification. Conveniently the bulk of my contributions are also at Scott’s prerogative, so

Re: [DISCUSSION] If we fix code that used default encoding to now be UTF-8... is this a regression?

> It probably has to be done on a case-by-case basis Yeah, this is what I feel as well… > Does the linter provide more detail than just the list? Not really, it shows how to fix but can’t really say if the fix will cause issues… If you are not running with UTF-8 we do the right thing most o

Re: [DISCUSSION] Cassandra's code style and source code analysis

I am strong +1 to new linters, I have been working on SpotBugs but not sent a patch due to sickness and holidays… About the check style as the source of truth for the style guides, I am +1 to this as well… I feel that wiki is a bad place for this and we can use the check style file to generate

Re: [DISCUSSION] Cassandra's code style and source code analysis

Thank you all for the feedback and productive discussion. I couldn't have formed my thoughts on the build tools for the product better and provided such good examples than Scott did. Rephrasing what I wrote in the first letter, seeing Maven/Gradle in the project underfoot, a modern IDE will take

Re: [DISCUSS] Adding dependency to the Big-Math library from eobermuhlner

I'm pleased with the rigor he shows on his explanations of implementation and performance: http://obermuhlner.ch/wordpress/2016/06/02/bigdecimalmath/ Seems like it's probably stable given the infrequency of changes to it and he's still actively merging patches submit by others: https://github.c

[DISCUSS] Adding dependency to the Big-Math library from eobermuhlner

Hi everybody, I wanted to discuss the addition of the Big-Math library( http://eobermuhlner.github.io/big-math/) as a dependency by CASSANDRA-17221 which add support for abs, exp, log, log10, and round Math function. The library was added fo