New episode of The Apache Cassandra(R) Corner

2022-11-08 Thread Aaron Ploetz
Link to next episode: Ep13 - Alexa Simon (Realeyes Sr. Data Engineer) https://drive.google.com/file/d/17vVbAirAJABH4ZbNS-4Yk-eeUbQCyTWd/view?usp=share_link (You may have to download it to listen) It will remain in staging for 72 hours, going live (assuming no objections) by Friday (afternoon),

Re: [DISCUSSION] Add SpotBugs to the build

2022-11-08 Thread David Capwell
Thanks all for the replies, I hope I am posting a summary of all the feedback 1) double check with legal due to LGPL 2) need way to opt-out during development similar to checkstyle 3) patch should be in the same spirit as the other build changes, hiding details in .build and following naming 4) c

Re: [DISCUSSION] Add SpotBugs to the build

2022-11-08 Thread Mick Semb Wever
Fair point on the name both being more representative of what it does and > being less scary. Wish we could think of something alpha-adjacent to "ant > jar" so folks that are thinking "I want to build this thing" immediately > see both options; the ant -p output is getting pretty long. > What's t

Re: [DISCUSSION] Add SpotBugs to the build

2022-11-08 Thread Josh McKenzie
Fair point on the name both being more representative of what it does and being less scary. Wish we could think of something alpha-adjacent to "ant jar" so folks that are thinking "I want to build this thing" immediately see both options; the ant -p output is getting pretty long. On Tue, Nov 8,

Re: [DISCUSSION] Add SpotBugs to the build

2022-11-08 Thread Derek Chen-Becker
"ant skip-code-checks" might be more discoverable (and less intimidating) than "ant unsafe". I'm a +100 on enabling more static analysis/linting/coverage reporting for full builds. On Tue, Nov 8, 2022, 6:42 AM Josh McKenzie wrote: > We used to do linting years ago, and our approach was basically

Re: [DISCUSSION] Add SpotBugs to the build

2022-11-08 Thread Josh McKenzie
We used to do linting years ago, and our approach was basically "the past is past, but look for deltas of new bad things added and notify the author". At least for me personally the signal / noise ratio was quite valuable (and not just for my own code; i.e. this wasn't *just* a "Josh Problem" ;)

Re: Cassandra project status update 2022-11-07

2022-11-08 Thread Josh McKenzie
Thanks Stefan; I added the 4.1-rc fixver to the ticket we already have. Could you do the same when you create a ticket for that other failure? On Mon, Nov 7, 2022, at 5:29 PM, Miklosovic, Stefan wrote: > Hi Josh, > > thanks for the status. > > I would like to raise awareness that as we fix CASS

Re: [DISSCUSS] Access to JDK internals only after dev mailing list consensus?

2022-11-08 Thread Josh McKenzie
Left a couple thoughts that are probably outside the scope of this work but fast-follows, and one nit on ordering (hit ML before documenting on JIRA vs. hit JIRA and then hit up ML). Otherwise, looks great! On Mon, Nov 7, 2022, at 2:56 PM, Chen-Becker, Derek wrote: > There was one very minor gra

Re: [DISCUSSION] Add SpotBugs to the build

2022-11-08 Thread Miklosovic, Stefan
I confused Jacoco to be code analysis tool instead of code coverage one. Early morning I guess :) I was thinking more about tooling like Sonar. What do you think about that? Any pros / cons to Spotbugs? From: Miklosovic, Stefan Sent: Tuesday, November 8,

Re: [DISCUSSION] Add SpotBugs to the build

2022-11-08 Thread Miklosovic, Stefan
Hi David, all what is the position of Jacoco in Cassandra as this point? I see it in build.xml there are some targets and infrastructure around that. What is wrong with using Jacoco instead more heavily for static analysis? Why do we need to introduce this? Regards ___