Positive David!
Can I suggest building on top of a change like this:
https://github.com/apache/cassandra/compare/cassandra-4.1...thelastpickle:cassandra:mck/buildfiles-linter-docs/4.1
i.e.
- moving all the linter stuff out to .build/build-linter.xml
- standardising on the -Dno-xxx approach (as we
+1 to static code analysis and hoping it's smart enough to check only
changed files instead of adding 30s to each build by checking everything
:fingerscrossed:
On 8/11/22 2:03, Brandon Williams wrote:
I suspect we'll have a -Dno-spotbugs flag as a counterpart to the
-Dno-checkstyle flag we hav
I suspect we'll have a -Dno-spotbugs flag as a counterpart to the
-Dno-checkstyle flag we have now.
Kind Regards,
Brandon
On Mon, Nov 7, 2022 at 6:45 PM Derek Chen-Becker wrote:
>
> I'm always in favor of having the compiler/runtime do more work for
> us, but I guess in the interest of gauging i
I would expect the role of SpotBugs to be advisory at first. After running it
on the code and evaluating the number and type of violations we can decide
which make sense to address and whether we would like it break the builds if it
detects violations.
>
> On Nov 7, 2022, at 4:45 PM, Derek Che
I'm always in favor of having the compiler/runtime do more work for
us, but I guess in the interest of gauging impact to dev productivity,
does this add much overhead? I guess we'll need to discuss what it
finds after it runs, as well.
Cheers,
Derek
On Mon, Nov 7, 2022 at 4:10 PM David Capwell
This is a good idea. Could you please run it by ASF legal just so we have all
our bases covered?
>
> On Nov 7, 2022, at 3:10 PM, David Capwell wrote:
>
> I was thinking that it would be good to add SpotBugs
> (https://spotbugs.github.io) into our build to help find bugs earlier in the
> lif
I was thinking that it would be good to add SpotBugs
(https://spotbugs.github.io) into our build to help find bugs earlier in the
life cycle. SpotBugs is LGPL but as it is used only in the build and not to
within this project, then this should be fine with Apache.
The motivation for adding thi
Hi Josh,
thanks for the status.
I would like to raise awareness that as we fix CASSANDRA-17964, it will
introduce two tests which will start to fail (because they were not executed as
part of CI until now because how they are named (not ending on *Test)).
I believe that these tests will need t
Hi,
A while ago we came up with a very nice solution (thank you David Capwell for
suggesting this). Sorry for no updating this thread sooner, a lot of discussion
was done in the ticket. (CASSANDRA-17964).
The solution we think is the best is to have an Ant task which would scan all
classes via
Oh good grief, it's been 26 days since I wrote one of these. My apologies!
(Life happens - I can confirm that the terribly named "triple-demic" is real
folks)
We've had a number of releases since the last status email. The current and
latest supported GA cassandra releases across all branches a
There was one very minor grammatical nit that I commented on, but I think that
otherwise this is clear and well-written 😊
Cheers,
Derek
From: Ekaterina Dimitrova
Reply-To: "dev@cassandra.apache.org"
Date: Friday, November 4, 2022 at 3:51 PM
To: "dev@cassandra.apache.org"
Subject: RE: [EXTER
This change looks good to me. It is clear and concise.
On Fri, Nov 4, 2022 at 9:50 PM Ekaterina Dimitrova
wrote:
> 👋
>
> I finally got the chance to put down a proposal for a section at the end
> of the Cassandra Code Style document.
> Please help a fellow non-native speaker and definitely not
12 matches
Mail list logo
