Re: [DISCUSS] Change code style guide WRT to @Override in subclasses / interface implementations

2022-06-03 Thread Dinesh Joshi
Let’s bring it to vote? We can update the docs as we evolve the guidance but I think it’s in a good enough shape to publish. > > On Jun 3, 2022, at 9:07 AM, bened...@apache.org wrote: > >  > I always ask if we’re ready, get a few acks, then one or two new queries come > out of the woodwork. >

Re: [DISCUSS] Change code style guide WRT to @Override in subclasses / interface implementations

2022-06-03 Thread Ekaterina Dimitrova
+1 On Fri, 3 Jun 2022 at 12:26, Derek Chen-Becker wrote: > +1 to publishing. We should consider it a living document, not something > that we need to necessarily set in stone :) > > Cheers, > > Derek > > On Fri, Jun 3, 2022 at 10:05 AM bened...@apache.org > wrote: > >> I always ask if we’re rea

Re: [DISCUSS] Change code style guide WRT to @Override in subclasses / interface implementations

2022-06-03 Thread Derek Chen-Becker
+1 to publishing. We should consider it a living document, not something that we need to necessarily set in stone :) Cheers, Derek On Fri, Jun 3, 2022 at 10:05 AM bened...@apache.org wrote: > I always ask if we’re ready, get a few acks, then one or two new queries > come out of the woodwork. >

Re: [DISCUSS] Change code style guide WRT to @Override in subclasses / interface implementations

2022-06-03 Thread Brandon Williams
+1, let's do that. Kind Regards, Brandon On Fri, Jun 3, 2022 at 11:05 AM bened...@apache.org wrote: > > I always ask if we’re ready, get a few acks, then one or two new queries come > out of the woodwork. > > > > Perhaps I will just publish, and we can start addressing these queries in a > fol

Re: [DISCUSS] Change code style guide WRT to @Override in subclasses / interface implementations

2022-06-03 Thread bened...@apache.org
I always ask if we’re ready, get a few acks, then one or two new queries come out of the woodwork. Perhaps I will just publish, and we can start addressing these queries in a follow-up process. From: Dinesh Joshi Date: Friday, 3 June 2022 at 16:57 To: dev@cassandra.apache.org Subject: Re: [DI

Re: [DISCUSS] Change code style guide WRT to @Override in subclasses / interface implementations

2022-06-03 Thread Dinesh Joshi
I don’t think the guide has yet been published to the official website, has it? Maybe we should just get it out there. > On Jun 3, 2022, at 8:54 AM, bened...@apache.org wrote: > >  > Somebody hasn’t looked at the new style guide*, the conversation for which > keeps rolling on and so it never q

Re: [DISCUSS] Change code style guide WRT to @Override in subclasses / interface implementations

2022-06-03 Thread bened...@apache.org
Somebody hasn’t looked at the new style guide*, the conversation for which keeps rolling on and so it never quite gets promoted to the wiki. It says: Always use @Override annotations when implementing abstract or interface methods or overriding a parent method. * https://docs.google.com/docume

CEP-15 multi key transaction syntax

2022-06-03 Thread Blake Eggleston
Hi dev@, I’ve been working on a draft syntax for Accord transactions and wanted to bring what I have to the dev list to solicit feedback and build consensus before moving forward with it. The proposed transaction syntax is intended to be an extended batch syntax. Basically batches with selects,

Re: [DISCUSS] Change code style guide WRT to @Override in subclasses / interface implementations

2022-06-03 Thread Josh McKenzie
> > Avoid redundant `@Override` annotations when implementing abstract or > > interface methods. I'd argue they're not redundant. We're humans and infinitely fallible. :) +1 to changing this to just always annotate for all the reasons you enumerate. On Fri, Jun 3, 2022, at 10:16 AM, Alex Petrov

Re: [DISCUSS] Change code style guide WRT to @Override in subclasses / interface implementations

2022-06-03 Thread Alex Petrov
Right, my thinking matches what David has mentioned: https://issues.apache.org/jira/browse/CASSANDRA-16096 https://lists.apache.org/thread/mkskwxn921t5bkfmnog032qvnyjk82t7 I'll make sure to update the style guide itself, too, since it looks like there was a vote, and intellij file is updated, ju

Re: [DISCUSS] Change code style guide WRT to @Override in subclasses / interface implementations

2022-06-03 Thread Stefan Miklosovic
https://lists.apache.org/thread/mkskwxn921t5bkfmnog032qvnyjk82t7 On Fri, 3 Jun 2022 at 16:11, Derek Chen-Becker wrote: > > I think we discussed this a couple of weeks ago, but to reiterate my > position: I think we should use annotations where they allow the compiler and > ancillary tooling (e.

Re: [DISCUSS] Change code style guide WRT to @Override in subclasses / interface implementations

2022-06-03 Thread Derek Chen-Becker
I think we discussed this a couple of weeks ago, but to reiterate my position: I think we should use annotations where they allow the compiler and ancillary tooling (e.g. FindBugs) to catch and prevent classes of errors. @Override seems like a pretty easy one to add, and has concrete examples of th

Re: [DISCUSS] Change code style guide WRT to @Override in subclasses / interface implementations

2022-06-03 Thread Dinesh Joshi
So your proposal is to always add override annotation? Or are there situations where you don’t want to add them? > > On Jun 3, 2022, at 6:53 AM, Alex Petrov wrote: > >  > Hi everyone, > > In our style guide [1], we have a following statement: > > > Avoid redundant @Override annotations when

Re: [DISCUSS] Change code style guide WRT to @Override in subclasses / interface implementations

2022-06-03 Thread Stefan Miklosovic
Hi, I was living with the fact that we are putting @Override in the cases you described already. I _think_ it was David Capwell (sorry if I am wrong here) who suggested we should start to put @Override on these methods but it was a very long time ago. I'll try to go over the ML archive to find it.

[DISCUSS] Change code style guide WRT to @Override in subclasses / interface implementations

2022-06-03 Thread Alex Petrov
Hi everyone, In our style guide [1], we have a following statement: > Avoid redundant `@Override` annotations when implementing abstract or > interface methods. I'd like to suggest we change this. @Override annotation in subclasses might be annoying when you're writing the code for the first