Fair enough. Thanks for the perspective, and the doc is shaping up nicely!
On Sat, May 14, 2022 at 2:28 PM bened...@apache.org
wrote:
> > having the policy be enums by default as opposed to just recommending
> them
>
>
>
> This might be a stylistic issue. “Prefer an enum to Boolean properties” i
> having the policy be enums by default as opposed to just recommending them
This might be a stylistic issue. “Prefer an enum to Boolean properties” is
imperative voice, and is meant to be read as “you should use enums, not
booleans, unless you have overriding reasons not to” – perhaps the examp
On Sat, May 14, 2022 at 11:00 AM Josh McKenzie wrote:
>
> Incidentally, I've found similar value in @ThreadSafe, const, readonly,
> etc - communications of author's intent; being able to signal to future
> maintainers helps them make modifications that are more consistent with and
> safer with re
On Sat, May 14, 2022 at 8:24 AM bened...@apache.org
wrote:
> > I'm in favor of codifying the usage of @NotNull and @Nullable
> stylistically. +1
>
>
>
> I’m in favour of the use of _*one*_ of @Nullable and @NotNull, preferably
> the former since we already use it and it’s more reasonable to have
> At the very least we should mention @Nullable and invite authors to use it
> where it aids clarity,
Thanks for taking the time to better articulate the appropriate constraints on
this Benedict - I think "always use these annotations" would have very poor
signal / noise ratios, but in cases whe
> I'm in favor of codifying the usage of @NotNull and @Nullable stylistically.
> +1
I’m in favour of the use of _one_ of @Nullable and @NotNull, preferably the
former since we already use it and it’s more reasonable to have a default of
non-null variables, parameters and properties.
However, I
