Re: [VOTE] Release Apache Cassandra 4.0.1

2021-09-03 Thread Ekaterina Dimitrova
+1 On Fri, 3 Sep 2021 at 11:55, Benjamin Lerer wrote: > +1 > > Le jeu. 2 sept. 2021 à 07:25, Dinesh Joshi a > écrit : > > > +1 > > > > Dinesh > > > > > On Sep 1, 2021, at 4:54 AM, Sam Tunnicliffe wrote: > > > > > > Proposing the test build of Cassandra 4.0.1 for release. > > > > > > sha1: 670

Re: [VOTE] Release Apache Cassandra 4.0.1

2021-09-03 Thread Benjamin Lerer
+1 Le jeu. 2 sept. 2021 à 07:25, Dinesh Joshi a écrit : > +1 > > Dinesh > > > On Sep 1, 2021, at 4:54 AM, Sam Tunnicliffe wrote: > > > > Proposing the test build of Cassandra 4.0.1 for release. > > > > sha1: 6709111ed007a54b3e42884853f89cabd38e4316 > > Git: > https://gitbox.apache.org/repos/as

Re: [VOTE] Release Apache Cassandra 4.0.1

2021-09-03 Thread Blake Eggleston
+1 > On Sep 1, 2021, at 4:54 AM, Sam Tunnicliffe wrote: > > Proposing the test build of Cassandra 4.0.1 for release. > > sha1: 6709111ed007a54b3e42884853f89cabd38e4316 > Git: > https://gitbox.apache.org/repos/asf?p=cassandra.git;a=shortlog;h=refs/tags/4.0.1-tentative > Maven Artifacts: > http

Re: [DISCUSS] CASSANDRA-15234

2021-09-03 Thread bened...@apache.org
> I think as the comments were stripped only for the POC. I guess many of them > will get back in the actual doc version unfortunately. Well, I think the grouped format lends itself to much briefer comments, with groups of related parameters getting an overall description. Even as a developer w

Re: [DISCUSS] CASSANDRA-15234

2021-09-03 Thread Joshua McKenzie
> > at this point we shouldn’t be comparing the length of the files I think as > the comments were stripped only for the POC Ah - my misunderstanding then. I assumed we were relying on the local context of the grouping to provide insight into the functionality of parameters and removed the comment

Re: [DISCUSS] CASSANDRA-15234

2021-09-03 Thread Ekaterina Dimitrova
> > > > It’s worth noting that the two don’t have to be in >conflict: we could > offer two template yaml with the parameters grouped differently, for users > to decide for themselves. Sure, my only concern is that three versions of the yaml could bring confusion (we will have backward compatibilit