Re: [DISCUSS] Diagnostic events in virtual tables

2021-07-21 Thread Stefan Miklosovic
Thank you both for the answers, really appreciate it. My concern is that there would be "too much data" in them and it might grow and grow as a node is live, however, that being said, I think there is currently a hardcap like 200 events per event type in the current implementation (1). Hence I see

Re: [DISCUSS] Diagnostic events in virtual tables

2021-07-21 Thread Jeremiah D Jordan
Yes, I think it would make sense to have the events available in a virtual table, especially if we are trying to move our operational management in that direction. But, why does it need to be bin log or virtual tables? Why not both? The virtual tables could even return the data stored in the

Re: [DISCUSS] CEP-11: Pluggable memtable implementations

2021-07-21 Thread Branimir Lambov
> Why is flushing control bad to do in CFS and better in the memtable? I wonder why you would understand this as something that takes away control instead of giving it. The CFS is not configurable. With the CEP, memtables are configurable at the table level. It is entirely possible to implement

Re: [DISCUSS] CEP-11: Pluggable memtable implementations

2021-07-21 Thread bened...@apache.org
I would love to help out with this in any way that I can, FYI. Definitely one of the more impactful performance improvements to the codebase, given the benefits to compaction and memory behaviour. From: bened...@apache.org Date: Wednesday, 21 July 2021 at 14:32 To: dev@cassandra.apache.org Sub

Re: [DISCUSS] CEP-11: Pluggable memtable implementations

2021-07-21 Thread bened...@apache.org
> memtable-as-a-commitlog-index Heh, based on 7282? Yeah, I’ve had this idea for a while now (actually there was a paper that did this a long time ago), and it could be very nice (if for no other benefit than reducing heap utilisation). I don’t think this requires that they be modelled as the s

Re: [DISCUSS] CEP-11: Pluggable memtable implementations

2021-07-21 Thread Branimir Lambov
> In general, I think we need to make up our mind as to whether we consider the Memtable and CommitLog one logical entity [...], or whether we want to further untangle those two components from an architectural perspective which we started down that road on with the pluggable storage engine

Re: [DISCUSS] Diagnostic events in virtual tables

2021-07-21 Thread Paulo Motta
I'm not very familiar with diagnostic events, but I think there's great value in providing a Virtual Table implementation to diagnostic events, since this will help in the long term objective of providing a unified interface to node monitoring, so +1 from my side. I think it would definitely help t

Re: [DISCUSS] CEP-11: Pluggable memtable implementations

2021-07-21 Thread Michael Burman
Hi, It is nice to see these going forward (and a great use of CEP) so thanks for the proposal. I have my reservations regarding the linking of memtable to CommitLog and flushing and should not leak abstraction from one to another. And I don't see the reasoning why they should be, it doesn't seem t