Review Needed

2018-10-23 Thread Akash Gangil
Hi, I am facing a issue with updating the DDL which is solved by the PR associated with this issue. It needs reviews though. Would be great if this can get some attention and is merged for 4.0. https://issues.apache.org/jira/browse/CASSANDRA-14706 thanks! -- Akash

Re: CASSANDRA-13241 lower default chunk_length_in_kb

2018-10-23 Thread Jeff Jirsa
My objection (-0.5) is based on freeze not in code complexity -- Jeff Jirsa > On Oct 23, 2018, at 8:59 AM, Benedict Elliott Smith > wrote: > > To discuss the concerns about the patch for a more efficient representation: > > The risk from such a patch is very low. It’s a very simple in-me

Re: Testing 4.0 upgrading

2018-10-23 Thread Jason Brown
Hi Tommy, Thank you for taking the time to start kicking the tires on the upgrade to 4.0. It looks like you've found two bugs: 1) "Unknown column coordinator_port during deserialization" (reported on 3.x nodes) - looks like the 4.0 node isn't filtering out a column from a system table that 3.0 d

Re: CASSANDRA-13241 lower default chunk_length_in_kb

2018-10-23 Thread Benedict Elliott Smith
To discuss the concerns about the patch for a more efficient representation: The risk from such a patch is very low. It’s a very simple in-memory data structure, that we can introduce thorough fuzz tests for. The reason to exclude it would be for reasons of wanting to begin strictly enforcing

Re: CASSANDRA-13241 lower default chunk_length_in_kb

2018-10-23 Thread Ariel Weisberg
Hi, I just asked Jeff. He is -0 and -0.5 respectively. Ariel On Tue, Oct 23, 2018, at 11:50 AM, Benedict Elliott Smith wrote: > I’m +1 change of default. I think Jeff was -1 on that though. > > > > On 23 Oct 2018, at 16:46, Ariel Weisberg wrote: > > > > Hi, > > > > To summarize who we have

Re: CASSANDRA-13241 lower default chunk_length_in_kb

2018-10-23 Thread Benedict Elliott Smith
I’m +1 change of default. I think Jeff was -1 on that though. > On 23 Oct 2018, at 16:46, Ariel Weisberg wrote: > > Hi, > > To summarize who we have heard from so far > > WRT to changing just the default: > > +1: > Jon Haddadd > Ben Bromhead > Alain Rodriguez > Sankalp Kohli (not explicit)

Re: CASSANDRA-13241 lower default chunk_length_in_kb

2018-10-23 Thread Ariel Weisberg
Hi, To summarize who we have heard from so far WRT to changing just the default: +1: Jon Haddadd Ben Bromhead Alain Rodriguez Sankalp Kohli (not explicit) -0: Sylvaine Lebresne Jeff Jirsa Not sure: Kurt Greaves Joshua Mckenzie Benedict Elliot Smith WRT to change the representation: +1: Ther

Testing 4.0 upgrading

2018-10-23 Thread Tommy Stendahl
Hi, I have been testing upgrade to 4.0, I started out with a cluster with 3.0.15 and server encryption enabled. Due to some issues in my environment I did upgrade one of the nodes to 3.11.3, I think this turned out to be a good thing since I could observer the behaviour of upgrading from both