Re: upgrade guava on trunk before 9/1?

2018-08-15 Thread dinesh.jo...@yahoo.com.INVALID
Jason, Given that we're so close to the 9/1 date, I would err on the side of caution especially given the low value prop. If someone does run into Guava compatibility issues (and someone somewhere will), we can revisit this question then. Dinesh On Wednesday, August 15, 2018, 11:42:31 PM P

Re: upgrade guava on trunk before 9/1?

2018-08-15 Thread Salih Gedik
Hi, Change logs are on Github releases page. It seems like only hash flooding protection which is added to ImmutableMap is relevant to Cassandra code. I haven’t checked whether we use deprecated APIs. But there isn’t much on table from what I see. Salih On 15 Aug 2018 17:55 +0300, Ariel Weisbe

Re: upgrade guava on trunk before 9/1?

2018-08-15 Thread Ariel Weisberg
Hi, They don't even do release notes after 23. Also no API diffs. I mean I'm fine with it, but it's mostly just changing to another arbitrary version that won't match what is in apps. Ariel On Wed, Aug 15, 2018, at 10:48 AM, Jason Brown wrote: > Hey Ariel, > > Tbqh, not that much. I was most

Re: upgrade guava on trunk before 9/1?

2018-08-15 Thread Jason Brown
Hey Ariel, Tbqh, not that much. I was mostly thinking from the "I have conflicts on guava versions in my app because I pull in cassandra and XYZ libraries, and the transitive dependencies on guava use different versions" POV. Further, we'll be on this version of guava for 4.0 for at least two year

Re: upgrade guava on trunk before 9/1?

2018-08-15 Thread Ariel Weisberg
Hi, What do we get from Guava in exchange for upgrading? Ariel On Wed, Aug 15, 2018, at 10:19 AM, Jason Brown wrote: > Hey all, > > Does anyone feel strongly about upgrading guava on trunk before the 9/1 > feature freeze for 4.0? We are currently at 23.3 (thanks to > CASSANDRA-13997), and the c

upgrade guava on trunk before 9/1?

2018-08-15 Thread Jason Brown
Hey all, Does anyone feel strongly about upgrading guava on trunk before the 9/1 feature freeze for 4.0? We are currently at 23.3 (thanks to CASSANDRA-13997), and the current is 26.0. I took a quick look, and there's about 17 compilation errors. They fall into two categories, both of which appear