Re: duration based config settings

2017-12-04 Thread Jon Haddad
Sure, I’m fine w/ letting the _ms settings work indefinitely. Can revisit retiring them if there’s ever a real need, am OK if that never happens. I’ll create the JIRA. > On Dec 4, 2017, at 5:19 PM, Nate McCall wrote: > >> I'd be in favour of never retiring the _ms format though - it's almost

Re: duration based config settings

2017-12-04 Thread Nate McCall
> I'd be in favour of never retiring the _ms format though - it's almost > free, there's no backward compatibility problems, and it's fairly intuitive > so long as we're consistent about it. > Agreed on this point. Overall, this will be excellent for usability. ---

Re: duration based config settings

2017-12-04 Thread Jeff Jirsa
To be clear I’m not -1 on this, I just hope we think about upgrading users as we deprecate the old stuff out -- Jeff Jirsa > On Dec 4, 2017, at 4:24 PM, Jon Haddad wrote: > > I ways back I had entire CASSANDRA-13976 out of sheer annoyance to change the > hint time to be in minutes instead

Re: duration based config settings

2017-12-04 Thread Benedict Elliott Smith
I'm strongly in favour of it; it's always bugged me, and I hadn't realised it might be contentious to implement. I'd be in favour of never retiring the _ms format though - it's almost free, there's no backward compatibility problems, and it's fairly intuitive so long as we're consistent about it.

duration based config settings

2017-12-04 Thread Jon Haddad
I ways back I had entire CASSANDRA-13976 out of sheer annoyance to change the hint time to be in minutes instead of ms. Millisecond based resolution is a bit absurd for things like hints. I figured minutes would be better, but after some back and forth realized durations (3h, 30m, etc) would b

Re: Making CommitLog pluggable

2017-12-04 Thread 大平怜
Hi, I submitted patches for the pluggable CommitLog. Appreciate any comments. Thanks! https://issues.apache.org/jira/browse/CASSANDRA-14062 Rei Odaira 2017-11-06 17:14 GMT-06:00 大平怜 : > Thanks for the feedback, Ariel, > > Based on your comments, we are revisiting our code changes, > and then