Re: New contribution - Burst Hour Compaction Strategy

2017-06-14 Thread Jeff Jirsa
Hi Pedro, I did a quick read through of your strategy, and have a few personal thoughts: First, writing a compaction strategy is a lot of work, and it's great to see new contributors take on ambitious projects. There are even a handful of ideas in here that may be useful to other strategies. The

Re: New contribution - Burst Hour Compaction Strategy

2017-06-14 Thread Cameron Zemek
The main issue I see with this is "Read all the SSTables and detect which partition keys are present in more than the compaction minimum threshold value" . This is quite expensive and will be using quite a lot of I/O to calculate. What makes writing a compaction strategy so difficult is calculating

Re: New contribution - Burst Hour Compaction Strategy

2017-06-14 Thread Pedro Gordo
Hi I've addressed the issues with Git. I believe this is what Stefan asking for: https://github.com/sedulam/cassandra/tree/12201 I've also added more tests for BHCS, including more for wide rows following Jeff's suggestion. Thanks for the directions so far! If there's something else you would lik