Re: Integrating vendor-specific code and developing plugins

2017-05-12 Thread J. D. Jordan
In tree would foster more committers which is a good thing. But I also agree that not being able to actually run unit tests is a bad thing. What if we asked people who want to contribute these types of optimizations to provide the ASF with a Jenkins slave we could test them on, if they want them

Re: Integrating vendor-specific code and developing plugins

2017-05-12 Thread Nate McCall
> This being said, I don't think we should remove support for Windows or > those snitches. Instead, what I think would be more beneficial, and > certainly more reflecting the Apache Way, is to see if someone in the > community would be willing to maintain those components. Looking at another > Apac

Re: Integrating vendor-specific code and developing plugins

2017-05-12 Thread Jeff Jirsa
I think the status quo is insufficient - even if it doesn't go in tree, we should do more than just say "the API exists, ship your own jar" What's the real risk of having it in tree? We break it because nobody can test it? How's that any worse than breaking it outside the tree? Finger pointing?

Re: Integrating vendor-specific code and developing plugins

2017-05-12 Thread Jason Brown
I agree the plugins route is the safest and best. However, we already have platform-specific code in-tree that is semi-unmaintained: the Windows support. To Sylvain's point, I have little to no idea if I'm going to break the Windows builds as I don't have access to a Windows machine, nor are we as

Re: CASSANDRA-13444: Fast Streaming Hist

2017-05-12 Thread Jason Brown
Hey Fedor, I'll try to make some time in the next week to get to it, as my hands are all over streaming for 4.0. Thanks for being patient, -Jason On Tue, May 9, 2017 at 11:16 PM, Fedor Bobin wrote: > Hello, > > Could someone provide feedback (and possible merge) my PR [1] > for CASSANDRA-1344

Re: Integrating vendor-specific code and developing plugins

2017-05-12 Thread Aleksey Yeschenko
I’m with Sylvain on this for essentially same reasons. If we need to improve our extensibility here, we should do that, and then have niche platform specific code be an external plug-in (and add a link to the plug-in to our docs, to promote it). --  AY On 12 May 2017 at 12:36:33, Sylvain Lebre

Re: Integrating vendor-specific code and developing plugins

2017-05-12 Thread Sylvain Lebresne
On Fri, May 12, 2017 at 12:29 AM, Jason Brown wrote: > Hey all, > > I'm on-board with what Rei is saying. I think we should be open to, and > encourage, other platforms/architectures for integration. Of course, it > will come down to specific maintainers/committers to do the testing and > verific