Re: Draft board report for January 2020

2020-01-02 Thread Andrei Sereda
+1 Question regarding Hazelcast : > Finally, the Hazelcast system has decided to adopt Calcite for query planning. Was it Ignite [1] or Hazelcast team to adopt (prototype) Calcite ? https://lists.apache.org/thread.html/4211dbbe35690e70462370886afcbb35419ff016b0ee604acf07a4d3%40%3Cdev.ignite.apa

Re: Calcite Adapter Question

2020-01-17 Thread Andrei Sereda
Hi Charles, There is some documentation here https://calcite.apache.org/docs/adapter.html it describes how to setup and use an adapter. Note that you can only use those adapters within calcite runtime and not as a standalone library. Typical adapter would expose collection (for Mongo), index (fo

Re: Usage of SqlStdOperatorTable.BETWEEN from RelBuilder

2020-01-18 Thread Andrei Sereda
Hi Hrudaya, It seems that SqlBetweenOperator doesn’t correctly infer return type when created by RexBuilder. As a workaround, can you replace BETWEEN by composition of two ANDs ? (user_id >= 1 AND user_id <= 5) // RelBuilder builder = ... builder.scan("users"); RexNode condition1 = builder.call

Re: [DISCUSS] Towards Calcite 1.22

2020-01-22 Thread Andrei Sereda
>> Thank you for your work, Anderi. > >>> > >>> Let's get CALCITE-1581[1] into 1.22. > >>> > >>> +1 for release at early-mid January '20 (to have more time to review > >> prs). > >>> > >>> > >>> [1] https:

Re: [DISCUSS] Towards Calcite 1.22

2020-02-07 Thread Andrei Sereda
n December, then it was pushed back > to mid-January. We can't wait much longer. > > Julian > > On Wed, Jan 22, 2020 at 8:07 AM Andrei Sereda wrote: > > > > Hello, > > > > I would like to ask community if it is OK if 1.22 release gets delayed by > > 2-3

Re: [DISCUSS] Towards Calcite 1.22

2020-02-07 Thread Andrei Sereda
Is there anyone willing to swap a Calcite release with me ? On Fri, Feb 7, 2020 at 12:41 PM Andrei Sereda wrote: > Hi Julian et al, > > Unfortunately my current work schedule is still very tense. There are some > internal deadlines that have passed already. > > I would a

Re: [DISCUSS] Towards Calcite 1.22

2020-02-11 Thread Andrei Sereda
Thanks for stepping in Danny. Can I take your release ? On Mon, Feb 10, 2020 at 2:34 PM Julian Hyde wrote: > It would be helpful for us to test third-party projects. > > But equally, it is useful for third-party projects to test against us. > (Especially non-open-source ones, which we cannot tes

Re: Calcite PR CI offten failed due to elasticsearch:test

2020-07-09 Thread Andrei Sereda
Hello, I'll take a look at failing tests. It seems that embedded ES doesn't start correctly. Andrei. On Thu, Jul 9, 2020 at 10:21 PM JiaTao Tao wrote: > another case > https://travis-ci.org/github/apache/calcite/jobs/706573803 > > FAILURE 0.0sec, org.apache.calcite.test.RelMetadataTest > > t

Re: Calcite PR CI offten failed due to elasticsearch:test

2020-07-12 Thread Andrei Sereda
Hello, Can somebody pls point me to a failed test in PR (full stack trace) ? My understanding is that it is happening only in github CI ? Many thanks, Andrei. On Fri, Jul 10, 2020 at 10:07 PM Danny Chan wrote: > Thanks so much for taking care~ > > Andrei Sereda 于2020年7月10日 周五

Re: [DISCUSS] Towards Calcite 1.25.0

2020-07-24 Thread Andrei Sereda
It should be me. I swapped the 1.22 release with Danny Chen who was supposed to be release manager for 1.25 On Fri, Jul 24, 2020 at 12:52 PM Haisheng Yuan wrote: > Do we have release manager for v1.25.0? > > > On 2020/07/23 17:15:12, Julian Hyde wrote: > > The release vote for 1.24 RC0 just pa

Re: [DISCUSS] Towards Calcite 1.25.0

2020-07-24 Thread Andrei Sereda
could get this done in by Aug 8 - i.e. 2 weeks > - if we focus.) > > Julian > > > > On Jul 24, 2020, at 9:57 AM, Andrei Sereda wrote: > > > > It should be me. > > > > I swapped the 1.22 release with Danny Chen who was supposed to be release >

Re: [DISCUSS] Towards Calcite 1.25.0

2020-08-07 Thread Andrei Sereda
hat this would be a quick release. Above I mentioned Aug > 8th as a target, and it's Aug 7th already. Can you start moving the > release process along, please. > > Julian > > On Fri, Jul 24, 2020 at 2:23 PM Andrei Sereda wrote: > > > > Julian, > > > &

master locked during 1.25.0 release

2020-08-07 Thread Andrei Sereda
Hello, Please avoid committing anything to master while 1.25.0 release is in progress. It will be unlocked after the voting / successful release. Many thanks, Andrei.

Re: [DISCUSS] Towards Calcite 1.25.0

2020-08-07 Thread Andrei Sereda
, 2020 at 11:12 AM Andrei Sereda wrote: > Hello, > > I'm starting the release today. If there are some PRs which you would like > to be included in 1.25 please let me know ASAP. > > This should be a quick release mostly for CALCITE-4136 > > Thanks, > Andrei. > >

Re: [DISCUSS] Towards Calcite 1.25.0

2020-08-08 Thread Andrei Sereda
I would say yes. On Sat, Aug 8, 2020, 13:32 Rui Wang wrote: > Is the highlight section a right place for [1] as it has bigger impact? > > > [1] > > https://github.com/apache/calcite/commit/19edf52c76c6a1507721f5bd37f2a33497aa0c4c > > -Rui > > On Fri, Aug 7, 2020 a

[VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-08 Thread Andrei Sereda
Hi all, I have created a build for Apache Calcite 1.25.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://apache.github.io/calcite-site-preview/docs/history.html The commit to be voted upon: https://gitbox.apache.org/repo

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-09 Thread Andrei Sereda
ting related change). > > > > > > -Rui > > > > > > > > On Sun, Aug 9, 2020 at 2:02 AM Enrico Olivelli > wrote: > > > >> +1 (non binding) > >> run tests locally on Fedora + JDK14 > >> run tests of HerdDB just by switching from

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-10 Thread Andrei Sereda
d test suite changes, > those can be updated after release. > > - Haisheng > > On 2020/08/09 03:22:28, Andrei Sereda wrote: > > Hi all, > > > > I have created a build for Apache Calcite 1.25.0, release > > candidate 0. > > > > Thanks to everyone who

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-11 Thread Andrei Sereda
> * Andrei, I don’t think your key is in KEYS. Be sure to add it before the release announcement. I see my signing key in KEYS $ curl -s https://dist.apache.org/repos/dist/release/calcite/KEYS | grep sereda sig C41CFDDFED34C028 2019-08-19 Andrei Sereda (CODE SIGNING KEY) &l

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-11 Thread Andrei Sereda
; your key was still ‘unknown’ according to gpg. > > Julian > > > On Aug 11, 2020, at 8:04 AM, Andrei Sereda wrote: > > > >  > >> > >> * Andrei, I don’t think your key is in KEYS. Be sure to add it before > the > > release announcement. > &

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-11 Thread Andrei Sereda
Hi All, I plan to close the vote tomorrow (Aug 12th). If you still want to validate RC0 please do so before Wednesday. Regards, Andrei. On Tue, Aug 11, 2020 at 1:13 PM Andrei Sereda wrote: > Thanks, Julian, for the hint. I'll update the KEYS file. > > On Tue, Aug 11, 2020 at 1

Re: [ANNOUNCE] Ruben Quesada Lopez joins Calcite PMC

2020-08-12 Thread Andrei Sereda
Congratulations, Ruben! On Wed, Aug 12, 2020 at 1:21 PM Rui Wang wrote: > Congrats, Ruben! Well deserved! > > > > -Rui > > On Wed, Aug 12, 2020 at 9:24 AM Enrico Olivelli > wrote: > > > Congrats Ruben! > > > > Enrico > > > > Il Mer 12 Ago 2020, 18:05 Michael Mior ha scritto: > > > > > Congrats

[RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-12 Thread Andrei Sereda
* Andrei Sereda No 0s or -1s. Therefore I am delighted to announce that the proposal to release Apache Calcite 1.25.0 has passed. Thanks everyone. We’ll now roll the release out to the mirrors. I will also update release notes (in separate commit) to better reflect 1.25.0 changes. Please

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-12 Thread Andrei Sereda
Hello, Can somebody from PMC pls upload my public GPG key to KEYS <https://dist.apache.org/repos/dist/release/calcite/KEYS> ? I don't have permissions for that svn repo. I've sent an email to priv...@calcite.apache.org. Thanks, Andrei. On Tue, Aug 11, 2020 at 1:17 PM Andr

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-12 Thread Andrei Sereda
went wrong and you were not able to push it through. > > Best, > Stamatis > > On Thu, Aug 13, 2020 at 1:24 AM Andrei Sereda wrote: > > > Hello, > > > > Can somebody from PMC pls upload my public GPG key to KEYS > > <https://dist.apache.org/repos/di

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-13 Thread Andrei Sereda
ossible or if this is just the way ASF's infra is > > set up, but it's worth a look. > > > > Francis > > > > [1] > > > > > https://lists.apache.org/thread.html/rdb11cf78eaeecfefd68ce224cd2e6fd1e9f2ad964169d80f5d9cb82a%40%3Cdev.calcite.apache.org%3E &g

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-13 Thread Andrei Sereda
Inquired with INFRA-20681 <https://issues.apache.org/jira/browse/INFRA-20681> seems like only PMCs can commit to dist SVN: > Are committers (which are not PMCs) allowed to commit to SVN dist repo ? > ..., nope, by default its PMC members only On Thu, Aug 13, 2020 at 9:27 AM A

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-13 Thread Andrei Sereda
It can also be configured per project. > Do you know if SVN access can be configured per project ? > Yes it can, if the PMC agrees to it, the dist area can be opened up to all project committers - a few PMCs have done this. On Thu, Aug 13, 2020 at 10:43 AM Andrei Sereda wrote: > Inqu

[DISCUSS] Open SVN dist access to committers

2020-08-13 Thread Andrei Sereda
Hello, For the last two releases ([1] and [2]) committers were not able to finalize the release due to SVN restrictions. One of the PMC members had to step in order to distribute the artifacts. By default, only PMCs are allowed to make changes to dist

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-13 Thread Andrei Sereda
ild/stagingRepositories/nexus.txt and send me the content in > your local repo? > > Thanks, > Haisheng > > On 2020/08/13 14:47:05, Andrei Sereda wrote: > > It can also be configured per project. > > > > > Do you know if SVN access can be configured per proj

Re: [RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-15 Thread Andrei Sereda
sed? > > (Usually we push branch-x.x to master and re-open commits as soon as > the release vote passes. Amendments to release notes, if necessary, > can happen later.) > > Julian > > On Wed, Aug 12, 2020 at 11:13 AM Andrei Sereda wrote: > > > > Thanks to everyone

Re: [RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-16 Thread Andrei Sereda
. Since the release > vote has passed, we know that 68b02dfd4 is going to end up on master. > And we don't mind if people make intervening commits before you tweak > the release notes or whatever. > > On Sat, Aug 15, 2020 at 3:12 PM Andrei Sereda wrote: > > > > > i

Re: master locked during 1.25.0 release

2020-08-16 Thread Andrei Sereda
479b2397e06 > < > https://github.com/apache/calcite/commit/aadb605decd6bb6a853e23fac4b0f479b2397e06 > >. > > Julian > > > > On Aug 7, 2020, at 7:03 PM, Andrei Sereda wrote: > > > > Hello, > > > > Please avoid committing anything to master while

Re: [RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-21 Thread Andrei Sereda
Hello, I'm still waiting for INFRA-20681 [1] to be resolved to publish 1.25.0 artifacts to SVN. If some of you know different channels to speed up the resolution please let me know. [1] https://issues.apache.org/jira/browse/INFRA-20681 On Sun, Aug 16, 2020 at 12:58 PM Andrei Sereda

Re: [RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-22 Thread Andrei Sereda
INFRA-20681 was resolved. I have published the artifacts to SVN dist area. Will update static site and send an announcement shortly. On Fri, Aug 21, 2020 at 5:37 PM Andrei Sereda wrote: > Hello, > > I'm still waiting for INFRA-20681 [1] to be resolved to publish 1.25.0 > art

Re: [RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-22 Thread Andrei Sereda
1.25 [1] https://reporter.apache.org/addrelease.html?calcite [2] https://issues.apache.org/jira/projects/CALCITE/versions/12348564 On Sat, Aug 22, 2020 at 3:49 PM Michael Mior wrote: > Thanks Andrei! > > -- > Michael Mior > mm...@apache.org > > Le sam. 22 août 2020 à 15:

Re: [RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-22 Thread Andrei Sereda
5.0 as released? > > Francis > > On 23/08/2020 8:29 am, Andrei Sereda wrote: > > There are two things to be done by PMCs (unfortunately I can't due to > > restricted access): > > > > 1. Add release date 2020-08-22 for 1.25 to Apache Report Helper [1] > > 2. Mark

Re: [VOTE] Release apache-calcite-1.26.0 (release candidate 0)

2020-10-05 Thread Andrei Sereda
+1 (non-binding). - build locally: ok - check git hash: ok - check sha512 for artifacts: ok - check GPG signature: ok openjdk version "1.8.0_212" Note that I'm getting 404 for your public GPG key located here: https://people.apache.org/keys/committer/rubenql.asc So I've used Calcite KEYS instead

Re: How to test new datasource without "in memory/mock" implementation

2020-10-18 Thread Andrei Sereda
I agree with Julian. Not everybody has the option to run docker locally. Perhaps execute tests against embedded (or fake) instance as well as a real one (docker or externally managed) ? Like it is done in MongoDatabasePolicy.java [1] Currently tests for Elasticsearch, Geode and Mongo are all run

Re: [DISCUSS] Release Managers

2021-02-04 Thread Andrei Sereda
I'm happy to help with 1.30 On Thu, Feb 4, 2021 at 1:27 PM Julian Hyde wrote: > Yes, I'll be release manager for 1.28. > > I think I promised to be a release manager a while ago. I forget which > release. Sorry about that. > > On Thu, Feb 4, 2021 at 1:09 AM Stamatis Zampetakis > wrote: > > > >

Re: [DISCUSS] Release Managers

2021-06-04 Thread Andrei Sereda
I volunteered for 1.30 but happy to release a different version. On Fri, Jun 4, 2021 at 6:53 PM Haisheng Yuan wrote: > Thanks, Rui. > > Now we have release managers: > Rui Wang for 1.29.0 > Liya Fan for 1.30.0 > > Thanks, > Haisheng Yuan > > On 2021/06/04 22:05:34, Rui Wang wrote: > > In anothe

ElasticSearch Adapters. Calcite vs Dremio

2018-05-16 Thread Andrei Sereda
Hello, I've noticed that Dremio implemented their own (calcite) adapters for ElasticSearch. According to documentation those adapters support ES aggregations

ElasticSearch. Explicit Definitions, Literals and RelBuilder

2018-05-16 Thread Andrei Sereda
Hello Calcite Devs, I have some questions about ES adapter and custom predicates / projections in Calcite. Your help is much appreciated. 1) All ES examples use a view (ZIPS ) which does

Re: ElasticSearch. Explicit Definitions, Literals and RelBuilder

2018-05-17 Thread Andrei Sereda
of this and not sure whether it was intentional. It >> seems like a bug to me though. >> >> 3) Whenever you want to see how to build a particular query, you may find >> it helpful to run "EXPLAIN PLAN FOR " in sqlline. >> >> -- >> Michael Mior

Re: ElasticSearch. Explicit Definitions, Literals and RelBuilder

2018-05-17 Thread Andrei Sereda
tely. I think > for your ???, you want builder.field(0) although builder.field("_MAP") may > also work. > > -- > Michael Mior > mm...@uwaterloo.ca > > > Le jeu. 17 mai 2018 à 10:39, Andrei Sereda a écrit : > > > Hi Michael and Christian, > >

Re: ElasticSearch. Explicit Definitions, Literals and RelBuilder

2018-05-17 Thread Andrei Sereda
R? :) > > > Mit freundlichen Grüßen, > > *Christian Beikov* > Am 17.05.2018 um 17:43 schrieb Andrei Sereda: > >> Regarding (2) Lower-case problem. The issue seems to be in >> ElasticsearchFilter.Translator >>

ElasticSearch use of rest client (instead of TransportClient)

2018-05-18 Thread Andrei Sereda
Hello, ES TransportClient is deprecated in 7.0 (to be removed in 8.0) in favor of http rest client(s). Would you consider a contribution switching to Rest Low-Level Client

Re: ElasticSearch use of rest client (instead of TransportClient)

2018-05-18 Thread Andrei Sereda
> > > Mit freundlichen Grüßen, > > *Christian Beikov* > Am 18.05.2018 um 20:45 schrieb Andrei Sereda: > >> Hello, >> >> ES TransportClient is deprecated in 7.0 (to be removed >> <https://www.elastic.co/guide

Re: ElasticSearch use of rest client (instead of TransportClient)

2018-05-18 Thread Andrei Sereda
-- > *Christian Beikov* > Am 18.05.2018 um 21:19 schrieb Andrei Sereda: > > Yes it should be, since it is just an http client (apache http). > > ElasticSearch Rest API (query API) didn't change much > > < > https://www.elastic.co/guide/en/

RxNode (Filter) / Translator for various adapters (ES, Mongo, Geode etc.). Possible Bug ?

2018-05-28 Thread Andrei Sereda
Hello, Please correct me if my expectations are inaccurate about query predicates in Calcite. I think there is an issue in how expression translators work when AST is more complex (has more depth). Same code / logic is used across different adapters (Mongo / Geode / ES) so multiple data-sources m

skipping JDBC API (or ResultSet metadata / pagination)

2018-05-28 Thread Andrei Sereda
Hello, Is there a way to get Enumerator directly from RelNode bypassing JDBC calls like createStatement() / executeQuery() ? I'm looking for something like this: RelBuilder builder = . RelNode filter = builder.scan("mySchema", "myTable").filter().build(); Enumerable result = something.exe

Re: RxNode (Filter) / Translator for various adapters (ES, Mongo, Geode etc.). Possible Bug ?

2018-05-28 Thread Andrei Sereda
, a > method to add to MongoAdapterIT) even better. > > On Mon, May 28, 2018 at 2:47 PM, Andrei Sereda wrote: > > Hello, > > > > Please correct me if my expectations are inaccurate about query > predicates > > in Calcite. > > > > I think there is an

Re: RxNode (Filter) / Translator for various adapters (ES, Mongo, Geode etc.). Possible Bug ?

2018-05-28 Thread Andrei Sereda
ase? If you can provide a unit test (say, a >> method to add to MongoAdapterIT) even better. >> >> On Mon, May 28, 2018 at 2:47 PM, Andrei Sereda wrote: >> > Hello, >> > >> > Please correct me if my expectations are inaccurate about query >> predicate

using "fakes" in unit tests

2018-05-28 Thread Andrei Sereda
Hello, Current IT tests require manual startup and seeding of data-sources (Mongo, ES, Geode etc.) from separate git project (see calcite-test-dataset ). While useful they force developer to bootstrap additional environment on his own and don't work b

Re: RxNode (Filter) / Translator for various adapters (ES, Mongo, Geode etc.). Possible Bug ?

2018-05-29 Thread Andrei Sereda
der of conditions (eg. first AND then OR) which is not generic enough. Is it for operator precedence ? On Mon, May 28, 2018 at 11:20 PM, Andrei Sereda wrote: > Yes seems like subtree is not visited recursively for OR opeator(s). > > I have added a test to track this issue: htt

Re: RxNode (Filter) / Translator for various adapters (ES, Mongo, Geode etc.). Possible Bug ?

2018-05-29 Thread Andrei Sereda
/core/src/main/java/org/apache/calcite/rex/RexVisitor.java> is not being used to (recursively) translate RelNode into mongo query ? Would like to take a stub at CALCITE-2331 but, before, want to ensure I'm not missing anything. On Tue, May 29, 2018 at 7:20 AM, Andrei Sereda wrote: > An

Re: using "fakes" in unit tests

2018-05-30 Thread Andrei Sereda
ge for the adapters is great > in my books. > > -- > Michael Mior > mm...@apache.org > > > > Le lun. 28 mai 2018 à 23:47, Andrei Sereda a écrit : > > > Hello, > > > > Current IT tests require manual startup and seeding of data-sources > (Mongo, >

Re: using "fakes" in unit tests

2018-05-31 Thread Andrei Sereda
t; -- > Michael Mior > mm...@uwaterloo.ca > > > Le jeu. 31 mai 2018 à 00:53, Andrei Sereda a écrit : > > > Pls take a look at PR 715 <https://github.com/apache/calcite/pull/715> > and > > let me know what you think. > > > > I'm not sure if on

Re: using "fakes" in unit tests

2018-05-31 Thread Andrei Sereda
alcite-test-dataset artifacts need to be available in maven central. Also, for unit tests, I would suggest to add a smaller set (eg ~10-50 records called zips-mini.json) compared to existing 30k records in zips.json ? Let me know what you think. On Thu, May 31, 2018 at 10:27 AM, Andrei Sereda

Re: Elasticsearch integration test failures

2018-06-07 Thread Andrei Sereda
Hi Volodymyr, We're trying to bridge the gap between unit and integration tests (which are run infrequently) using fakes in Calcite. Currently the plan is to use fongo (see CALCITE-2345 for mongo adapter) and local elastic node (see CALCI

Re: Elasticsearch integration test failures

2018-06-11 Thread Andrei Sereda
;t change the functionality. So I'm all in on using just a > > local node which is also something I wanted to do for a long time, but > > you got to it before I did. > > > > Do the tests succeed with the local node? > > > > > > Mit freundlichen G

Re: Elasticsearch integration test failures

2018-06-11 Thread Andrei Sereda
Michael Mior > mm...@apache.org > > > Le lun. 11 juin 2018 à 08:34, Andrei Sereda a écrit : > > > > Do the tests succeed with the local node? > > IT tests haven't been migrated to local node yet. I wanted to do it as > > separate commit. > > There are

Re: Elasticsearch integration test failures

2018-06-11 Thread Andrei Sereda
For mongo / fongo <https://github.com/fakemongo/fongo> unfortunately we still have to run IT tests because fongo doesn't support all functionalies (see issue #152 <https://github.com/fakemongo/fongo/issues/152> as example). On Mon, Jun 11, 2018 at 10:26 AM, Andrei Sereda wrot

Re: Elasticsearch integration test failures

2018-06-11 Thread Andrei Sereda
ing that PR given that Travis CI reports no test failures. > > > Mit freundlichen Grüßen, > > *Christian Beikov* > Am 11.06.2018 um 14:33 schrieb Andrei Sereda: > >> Do the tests succeed with

Re: Elasticsearch integration test failures

2018-06-11 Thread Andrei Sereda
n.bei...@gmail.com> wrote: > For me that's fine, though it would be great if you could fix those given > your time permits it. > > Andrei Sereda schrieb am Mo., 11. Juni 2018, 22:12: > > > There are some tests which have been failing for while. Is it OK if I > > te

Re: Elasticsearch integration test failures

2018-06-12 Thread Andrei Sereda
at 5:46 PM Christian Beikov wrote: > I'm fine with a single PR as long as you split commits up. > > Andrei Sereda schrieb am Mo., 11. Juni 2018, 23:24: > > > Hi Christian, > > > > I'm working in parallel on CALCITE-2331 evaluation of predicate "(A or B) &g

Re: [2/2] calcite git commit: [CALCITE-2345] Running Unit tests with Fongo and integration tests with real mongo instance (Andrei Sereda)

2018-06-14 Thread Andrei Sereda
fix ASAP. > > > > > > > On Jun 13, 2018, at 6:00 PM, mm...@apache.org wrote: > > > > > > [CALCITE-2345] Running Unit tests with Fongo and integration tests with > > real mongo instance (Andrei Sereda) > > > > > > Better test coverage for

Re: Elasticsearch integration test failures

2018-06-18 Thread Andrei Sereda
csearch5Table you add the rules to the ElasticsearchTableScan > constructor. > > > Mit freundlichen Grüßen, > > *Christian Beikov* > Am 13.06.2018 um 06:15 schrieb Andrei Sereda: > > The issue seems to have

Re: ElasticSearch use of rest client (instead of TransportClient)

2018-06-22 Thread Andrei Sereda
to create / parse JSON formats, ES adapter would have to depend on some JSON library (most likely existing Jackson). Is that acceptable ? On Fri, May 18, 2018 at 4:29 PM Andrei Sereda wrote: > I believe this shouldn't be an issue with http client (contrary to native > transport)

Re: ElasticSearch use of rest client (instead of TransportClient)

2018-06-22 Thread Andrei Sereda
27;t a concern. > -- > Michael Mior > mm...@apache.org > > > > Le ven. 22 juin 2018 à 12:37, Andrei Sereda a écrit : > > > Some questions regarding this change: > > > > 1) Should one remove ES2 and ES5 adapters (maven modules) in favor of > > single

Re: ElasticSearch use of rest client (instead of TransportClient)

2018-06-22 Thread Andrei Sereda
are IMO not problematic. > > > Mit freundlichen Grüßen, > > *Christian Beikov* > Am 22.06.2018 um 19:07 schrieb Andrei Sereda: > > 1) If we go single (and separate) ES adapter route, people will have to > &g

Re: [2/2] calcite git commit: [CALCITE-2347] running ElasticSearch in embedded mode for unit tests of ES adapter (Andrei Sereda)

2018-06-22 Thread Andrei Sereda
or: package org.elasticsearch.node.internal does not exist > > [ERROR] import org.elasticsearch.node.internal.InternalSettingsPreparer; > > [ERROR] ^ > > [ERROR] > > > >> On Jun 21, 2018, at 3:39 AM, mm...@apache.org wrote: > >> > >> [CALCITE-2347] running

Re: [2/2] calcite git commit: [CALCITE-2347] running ElasticSearch in embedded mode for unit tests of ES adapter (Andrei Sereda)

2018-06-22 Thread Andrei Sereda
bootstrap tests faster) > >>> > >>> Created separate ES JUnit rule which can be re-used across different > >> tests. > >>> > >>> Both v2 and v5 of ES adapters are

Re: [2/2] calcite git commit: [CALCITE-2347] running ElasticSearch in embedded mode for unit tests of ES adapter (Andrei Sereda)

2018-06-24 Thread Andrei Sereda
] ^ > > > [ERROR] > > > /home/jhyde/open1/calcite.4/mongodb/src/test/java/org/apache/calcite/test/MongoAssertions.java:43: > > error: reference not found > > > [ERROR] /** Similar to {@link CalciteAssert#checkResultUnordered}, > but &

Re: [2/2] calcite git commit: [CALCITE-2347] running ElasticSearch in embedded mode for unit tests of ES adapter (Andrei Sereda)

2018-06-25 Thread Andrei Sereda
cked and it passed on my env. > > > > I think it should be also checked with other JDK versions besides 8. > > > > Kind regards, > > Volodymyr Vysotskyi > > > > > > пн, 25 черв. 2018 о 07:05 Andrei Sereda пише: > > > >> Can you please che

Re: [2/2] calcite git commit: [CALCITE-2347] running ElasticSearch in embedded mode for unit tests of ES adapter (Andrei Sereda)

2018-06-25 Thread Andrei Sereda
OK. I'm working on it. On Mon, Jun 25, 2018 at 2:18 PM Julian Hyde wrote: > > On Jun 25, 2018, at 11:11 AM, Andrei Sereda wrote: > > > > Would you consider merging this partial javadoc fix (PR 741 > > <https://github.com/apache/calcite/pull/741>) as precursor

Re: [2/2] calcite git commit: [CALCITE-2347] running ElasticSearch in embedded mode for unit tests of ES adapter (Andrei Sereda)

2018-06-25 Thread Andrei Sereda
ichael. Once implemented, it should automatically fix current classpath issue in javadoc. On Mon, Jun 25, 2018 at 2:23 PM Andrei Sereda wrote: > OK. I'm working on it. > > On Mon, Jun 25, 2018 at 2:18 PM Julian Hyde wrote: > >> > On Jun 25, 2018, at 11:11 AM, Andrei Se

Re: [2/2] calcite git commit: [CALCITE-2347] running ElasticSearch in embedded mode for unit tests of ES adapter (Andrei Sereda)

2018-06-25 Thread Andrei Sereda
PS. ES2+ES5 changes will be submitted in a couple of days. On Mon, Jun 25, 2018 at 4:56 PM Andrei Sereda wrote: > Temporary excluded elasticsearch2 package from javadoc. This should > unblock users. > Tested with JDK 8,9 and 10 (maven 3.5.2 / 3.5.4) macOSX > > Please double-chec

Re: ElasticSearch use of rest client (instead of TransportClient)

2018-06-27 Thread Andrei Sereda
Beikov* > Am 22.06.2018 um 20:24 schrieb Michael Mior: > > Looks good to me but I'll defer to Christian since I know little about > ES. > > Thanks for this Andrei! > > -- > > Michael Mior > > mm...@apache.org > > > > > > >

Re: [2/2] calcite git commit: [CALCITE-2347] running ElasticSearch in embedded mode for unit tests of ES adapter (Andrei Sereda)

2018-06-27 Thread Andrei Sereda
5 juin 2018 à 20:17, Julian Hyde a écrit : > > > I’m reviewing and testing just the package-exclusion part now. Hopefully > > will commit shortly. > > > > > On Jun 25, 2018, at 2:11 PM, Andrei Sereda wrote: > > > > > > PS. ES2+ES5 changes will be submi

Elasticsearch Adapter. Removal of Mapping Types (by vendor). Index == Table

2018-06-28 Thread Andrei Sereda
Hello, Elastic announced that they will be deprecating mapping types in ES6 and indexes will be single-typed only. Historical analogy between RDBMS and elastic was th

Re: [2/2] calcite git commit: [CALCITE-2347] running ElasticSearch in embedded mode for unit tests of ES adapter (Andrei Sereda)

2018-06-28 Thread Andrei Sereda
y PC as before. > > Kind regards, > Volodymyr Vysotskyi > > > чт, 28 черв. 2018 о 01:03 Andrei Sereda пише: > > > Submitted PR-744 <https://github.com/apache/calcite/pull/744> to unify > > ES2 > > and ES5. > > Javadoc Classpath collisions sh

Re: [2/2] calcite git commit: [CALCITE-2347] running ElasticSearch in embedded mode for unit tests of ES adapter (Andrei Sereda)

2018-06-28 Thread Andrei Sereda
b/src/test/java/org/apache/calcite/test/MongoAssertions.java:36: > error: reference not found > [ERROR] * Util class which needs to be in the same package as {@link > CalciteAssert} > [ERROR] ^ > > Kind regards, > Volodymyr Vysotskyi > > > чт, 28 черв. 2018 о 23:07 A

Re: Elasticsearch Adapter. Removal of Mapping Types (by vendor). Index == Table

2018-06-28 Thread Andrei Sereda
nks for your continued work on the ES adapter Andrei! > > -- > Michael Mior > mm...@apache.org > > > > Le jeu. 28 juin 2018 à 12:57, Andrei Sereda a écrit : > > > Hello, > > > > Elastic announced > > < > > > https://www.elastic.co/guide/en

Re: Elasticsearch Adapter. Removal of Mapping Types (by vendor). Index == Table

2018-06-28 Thread Andrei Sereda
of type name to index name map and be able to > support both scenarios. > > > Mit freundlichen Grüßen, > -------- > *Christian Beikov* > Am 29.06.2018 um 00:12 schrieb Andrei Sereda: > >> 1) What's the time horizon

Re: Elasticsearch Adapter. Removal of Mapping Types (by vendor). Index == Table

2018-06-29 Thread Andrei Sereda
; > * When index is given, the we only discover types according to the > > "type_field" configuration and the default for "table_mapping" is > > "type" > > > > This would also allow to discover indexes but still use "type" as

Re: Elasticsearch Adapter. Removal of Mapping Types (by vendor). Index == Table

2018-06-29 Thread Andrei Sereda
Plus allow to filter indexes using regexp ? On Fri, Jun 29, 2018 at 1:58 PM Andrei Sereda wrote: > I agree there should be a configuration option. How about the following > approach. > > Expose both variables ${index} and ${type} in configuration (JSON) and > user will use t

Re: Elasticsearch Adapter. Removal of Mapping Types (by vendor). Index == Table

2018-06-29 Thread Andrei Sereda
y affect JSON models? > > > > You seem to be using '_' as a separator character. Are we sure that > > people will never use it in index or type name? Separator characters > > often cause problems. > > > > Julian > > > > > > > &g

Re: Elasticsearch Adapter. Removal of Mapping Types (by vendor). Index == Table

2018-06-29 Thread Andrei Sereda
SON models? > > You seem to be using '_' as a separator character. Are we sure that > people will never use it in index or type name? Separator characters > often cause problems. > > Julian > > > > > On Fri, Jun 29, 2018 at 10:58 AM, Andrei Sereda

Re: Elasticsearch Adapter. Removal of Mapping Types (by vendor). Index == Table

2018-06-29 Thread Andrei Sereda
uot;x" with a type called "y_z". If I write "x_y_z" > it's not clear how it should be broken into index/type. > > > On Fri, Jun 29, 2018 at 3:15 PM, Andrei Sereda wrote: > >> Can you show how those examples affect SQL against the ES adapter and/or

Re: Elasticsearch Adapter. Removal of Mapping Types (by vendor). Index == Table

2018-06-29 Thread Andrei Sereda
ould stop using the parameter. > > Julian > > > > On Jun 29, 2018, at 4:43 PM, Andrei Sereda wrote: > > > > That's a valid point. Then user would define a different pattern like > > "i$index_t$type" for his cluster. > > > > I think we

Re: Elasticsearch Adapter. Removal of Mapping Types (by vendor). Index == Table

2018-06-30 Thread Andrei Sereda
if I add configuration parameter which allows to specify a (eg. regexp) filter for ES indexes ? On Fri, Jun 29, 2018 at 11:17 PM Andrei Sereda wrote: > That's a reasonable alternative. > > On Fri, Jun 29, 2018 at 7:57 PM Julian Hyde wrote: > >> Maybe there could be a

Re: [DISCUSS] Towards Calcite 1.17.0

2018-07-06 Thread Andrei Sereda
I have created PR-753 for CALCITE-2331. Please note it fixes only ES adapter (mongo is also affected). On Thu, Jun 28, 2018 at 1:54 PM Michael Mior wrote: > I'll add CALCITE-2331 as at least a nice-to-have. I believe Andrei is > working on a PR and th

Re: [DISCUSS] Towards Calcite 1.17.0

2018-07-11 Thread Andrei Sereda
; > > looks like work for CALCITE-2366 > > > <https://issues.apache.org/jira/browse/CALCITE-2366> is finished. > > > > > > Are there other PRs which may be merged before starting > > > the release process or new blocking issues? > > > &g

Re: [ANNOUNCE] Apache Calcite 1.17.0 released

2018-07-21 Thread Andrei Sereda
If people are interested I can prepare breaking changes paragraph for ES adapter. On Sat, Jul 21, 2018 at 1:17 PM Enrico Olivelli wrote: > Il sab 21 lug 2018, 18:25 Julian Hyde ha scritto: > > > Enrico, > > > > I agree. This release had so much good stuff that we were bound to miss > > some. Fo

Re: No data returned from mongodb table - calcite

2018-07-24 Thread Andrei Sereda
Hi Kumar, Probably, the problem is that mongo (Bson) documents are not shown correctly. Try to fetch individual attributes like : select _MAP['_id'], _MAP['attr1'] from "users" You can always double-check result size with select count(*) from "users" Regards, Andrei. On Tue, Jul 24, 2018 a

Re: Calcite-MongoDB-Joins operations support

2018-07-24 Thread Andrei Sereda
You can do joins but they will happen outside mongo (ie calcite does not use $lookup operator or such). On Tue, Jul 24, 2018 at 2:23 PM Satiz Kumar wrote: > Hi Calcite DEV Team, > > I am trying to use Calcite with my mongo

Re: Intermediate failure of materialized views in Cassandra adapter

2018-07-25 Thread Andrei Sereda
Mike, Is your branch michaelmior:2419-cassandra-unit up to date ? I'm getting NPE: > Caused by: java.lang.NullPointerException > at > org.apache.cassandra.config.DatabaseDescriptor.getDiskFailurePolicy(DatabaseDescriptor.java:1881) > at > org.apache.cassandra.utils.JVMStabilityInspector.inspectT

Re: Intermediate failure of materialized views in Cassandra adapter

2018-07-25 Thread Andrei Sereda
t want to merge the > branch with CassandraUnit until tests pass). > > -- > Michael Mior > mm...@apache.org > > > > Le mer. 25 juil. 2018 à 16:36, Andrei Sereda a écrit : > > > Mike, > > > > Is your branch michaelmior:2419-cassa

Re: Intermediate failure of materialized views in Cassandra adapter

2018-07-25 Thread Andrei Sereda
en all the tests and each test (after setup) runs rather quickly so I > don't think running the tests serially is a problem. I've never seen the > error you're seeing before. A full stack trace might help. > > -- > Michael Mior > mm...@apache.org > > > >

  1   2   3   4   >