Re: Running Calcite integration tests in docker

2018-05-15 Thread Michael Mior
I hadn't seen Testcontainers before. That looks pretty cool and I think it would be a great idea to explore. It seems like having a stable test infrastructure in Docker like Francis has been working on is a good first step. -- Michael Mior mm...@uwaterloo.ca Le mar. 15 mai 2018 à 17:26, Kevin Ri

Re: Running Calcite integration tests in docker

2018-05-15 Thread Kevin Risden
One idea I've been throwing around in my head is https://www.testcontainers.org/ where it would let you run Docker containers within unit tests. Again only an idea at this point but could move the actual integration tests back into Calcite instead of it being completely separate? Kevin Risden On

Re: Running Calcite integration tests in docker

2018-05-02 Thread Francis Chuang
Hey Christina, Thanks for clarifying! I think it's possible to ask infrastructure set up a docker repository for us, however, it also means that it's something we need to maintain vs using the official geode images. I am not sure what the policy is around releasing an artifact and docker imag

Re: Running Calcite integration tests in docker

2018-05-02 Thread Christian Tzolov
Hi Francis, Regarding Geode, initially i have tried to to ingest the test data via the Geode's REST/JSON endpoint but bumped into this bug: https://issues.apache.org/jira/browse/GEODE-3971 (still unresolved). As consequence i had to write a custom ingestion using Geode Java API. But since i had

Re: Running Calcite integration tests in docker

2018-04-23 Thread Francis Chuang
Thanks, Michael! I noticed that I forgot the link to my fork in my original message. Here is my fork if someone wants to hack on it a bit more: https://github.com/Boostport/calcite-test-dataset/tree/switch-to-docker On 23/04/2018 9:58 PM, Michael Mior wrote: Thanks for raising this Francis.

Re: Running Calcite integration tests in docker

2018-04-23 Thread Michael Mior
Thanks for raising this Francis. I was hoping to find more time to spend on this but unfortunately that hasn't happened. 1. That's a question for Christian Tzolov. I'm not too familiar with Geode. 2. You are correct that the VM contains several different database servers with various ports exposed

Running Calcite integration tests in docker

2018-04-23 Thread Francis Chuang
There is currently an issue open for this in the calcite-test-dataset repository[1], however, I would like to hear more from the wider community regarding this. I have created a `switch-to-docker` branch on my fork and committed a docker-compose.yml under the docker folder, but ran into a few