- checked signatures and checksums
- verified hashes
- downloaded sources, compiled and tested
+1 (binding)
On Thu, Apr 4, 2024 at 11:15 PM Francis Chuang
wrote:
> Good catch, Ruben and Michael!
>
> I will fix the release notes to say Gradle 8.5 instead of Gradle after
> release.
>
> The gradle
Good catch, Ruben and Michael!
I will fix the release notes to say Gradle 8.5 instead of Gradle after
release.
The gradle wrapper was removed in CALCITE-4575[1] to comply with ASF
guidelines.
For running tests in docker using docker-compose for releases, I've
filed CALCITE-6354 to directly
Francis,
+1 (checked signature and hash, ran tests)
I can't recall if this is expected, but the gradle wrapper is missing from
the release. This means that running tests via docker compose doesn't work.
--
Michael Mior
mm...@apache.org
On Mon, Apr 1, 2024 at 11:40 PM Francis Chuang
wrote:
>
- Checksum: ok
- Signature: ok
- Diff source release and git repository: ok
- Build + tests: ok
- Release notes: ok; one minor issue: the list item "CALCITE-6137" mentions
the upgrade to "Gradle 8.4", but both the Jira title and the initial
description of the RN say "8.5"
+1 (binding)
Best,
Ruben
+1 (non-binding) after verifying as follows:
- verified gpg signature: OK
$ curl "https://downloads.apache.org/calcite/KEYS"; | gpg --import
$ gpg --verify apache-calcite-avatica-1.25.0-src.tar.gz.asc
apache-calcite-avatica-1.25.0-src.tar.gz
- verified package checksum: OK
$ diff <(cat apache-
Ubuntu 20.04.6 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 8.1.1
* Checked signatures and checksums OK
* Checked diff between repo and artifacts OK
* Went over release note OK (It mentions two Gradle versions 8.4 and 8.5)
* Checked README, NOTICE, LICENSE OK (minor fixes in LICENSE from
Calcite
Opps, good catch! Please ignore the links to the
calcite-avatica-site-preview repo. Those are generated by the
asf-release plugin, but we don't use any preview repos for Calcite.
On 3/04/2024 9:41 pm, Benchao Li wrote:
+1 (binding)
- checked signature and checksum [OK]
- checked copyright yea
+1 (binding)
- checked signature and checksum [OK]
- checked copyright year in notice [OK]
- downloaded src, make sure no unexpected files [OK]
- compiled and tested from source [OK]
- reviewed release note [OK]
- checked a few files in Nexus for signature and checksum [OK]
- downloaded javadoc ja
