Re: [DISCUSS] Github PR link to JIRA issue

2022-04-04 Thread Michael Mior
Autolinks are listed as an "upcoming feature." I don't believe they can be currently controlled via .asf.yaml. -- Michael Mior mm...@apache.org Le sam. 2 avr. 2022 à 01:19, Julian Hyde a écrit : > The present hyperlinking was enabled by Stamatis: > https://issues.apache.org/jira/browse/CALCITE

Re: [DISCUSS] Github PR link to JIRA issue

2022-04-01 Thread Julian Hyde
The present hyperlinking was enabled by Stamatis: https://issues.apache.org/jira/browse/CALCITE-4104 I’m not exactly sure how the .asf.yaml file accomplishes this. Maybe it instructs some ASF robot to modify the GitHub project settings on ou

Re: [DISCUSS] Github PR link to JIRA issue

2022-04-01 Thread Haisheng Yuan
Yes, that is what I meant. I was expecting to see the link to JIRA in PR's commit page: https://github.com/apache/calcite/pull/2752/commits I am lazy to navigate to JIRA manually. :) Haisheng On 2022/04/01 01:04:19 Julian Hyde wrote: > Ah, I see. In the page for a commit (e.g. [1]) the text “[C

Re: [DISCUSS] Github PR link to JIRA issue

2022-03-31 Thread Julian Hyde
Ah, I see. In the page for a commit (e.g. [1]) the text “[CALCITE-5064]” appears as a blue hyperlink whereas the page for the corresponding pull request (e.g. [2]) the “[CALCITE-5064]” text is not a hyperlink. Is that what you meant, Haisheng? Julian [1] https://github.com/apache/calcite/com

Re: [DISCUSS] Github PR link to JIRA issue

2022-03-31 Thread Michael Mior
Stamatis, Unless I'm misunderstanding, Haisheng was referring to links in the opposite direction. That is, linking to JIRA issues from GitHub. The setting you reference is for creating a link from JIRA to GitHub. -- Michael Mior mm...@apache.org Le jeu. 31 mars 2022 à 13:53, Stamatis Zampetakis

Re: [DISCUSS] Github PR link to JIRA issue

2022-03-31 Thread Stamatis Zampetakis
It's already done via .asf.yaml [1]. Best, Stamatis [1] https://github.com/apache/calcite/blob/88cc385f98c551c1aca7ffab101934f1c34fdffd/.asf.yaml#L35 On Thu, Mar 31, 2022 at 7:19 PM Michael Mior wrote: > Not sure what might have changed, but here's the GitHub documentation on > the feature. If

Re: [DISCUSS] Github PR link to JIRA issue

2022-03-31 Thread Michael Mior
Not sure what might have changed, but here's the GitHub documentation on the feature. If this isn't working as expected, I would contact INFRA to make sure things are correctly configured. (Apparently in the future, this may be done via .asf.yaml) https://docs.github.com/en/repositories/managing-y

Re: [DISCUSS] Github PR link to JIRA issue

2022-03-30 Thread Haisheng Yuan
Hi Thomas, I didn't make myself clear. 6789 is just a random number, should be [CALCITE-], as Julian mentioned. The problem happens on github PR. e.g. in https://github.com/apache/calcite/pull/2757, the commit message title is [CALCITE-4401] SqlJoin toString throws RuntimeException Previou

Re: [DISCUSS] Github PR link to JIRA issue

2022-03-30 Thread Thomas Rebele
When I visit https://issues.apache.org/jira/browse/CALCITE-6789, I get an error message: You can't view this issue It may have been deleted or you don't have permission to view it. I can view other tickets, though (e.g., https://issues.apache.org/jira/browse/CALCITE-5008). Maybe the link has been

Re: [DISCUSS] Github PR link to JIRA issue

2022-03-30 Thread Julian Hyde
It seems to happen sporadically. Maybe the commit message of the PR needs to start with exactly “[CALCITE-]”. > On Mar 30, 2022, at 10:45 AM, Haisheng Yuan wrote: > > Hi all, > > Previously, the JIRA issue e.g. [CALCITE-6789] in Calcite github PR and > commit message will be automatically