[jira] [Created] (CALCITE-6681) NullPointerException in ProjectCorrelateTransposeRule

2024-11-07 Thread Mihai Budiu (Jira)
Mihai Budiu created CALCITE-6681: Summary: NullPointerException in ProjectCorrelateTransposeRule Key: CALCITE-6681 URL: https://issues.apache.org/jira/browse/CALCITE-6681 Project: Calcite Iss

[jira] [Created] (CALCITE-6680) RexImpTable erroneously declares NullPolicy.NONE for IS_EMPTY

2024-11-07 Thread Chris Dennis (Jira)
Chris Dennis created CALCITE-6680: - Summary: RexImpTable erroneously declares NullPolicy.NONE for IS_EMPTY Key: CALCITE-6680 URL: https://issues.apache.org/jira/browse/CALCITE-6680 Project: Calcite

Re: NullPolicy for IS_EMPTY in RexImpTable

2024-11-07 Thread Mihai Budiu
In any case, if you found a bug a JIRA issue must be filed, by you or someone else. If you have a reproduction, great, you can submit it as comments in JIRA, or even as a pull request. If you have a fix, even better. But it would be ideal to reuse as much of the effort you already put into diagn

Re: NullPolicy for IS_EMPTY in RexImpTable

2024-11-07 Thread Mihai Budiu
If you want to provide a patch you have to start by filing an issue in JIRA. See https://calcite.apache.org/develop/ Mihai From: Chris Dennis Sent: Thursday, November 7, 2024 12:49 PM To: dev@calcite.apache.org Subject: Re: NullPolicy for IS_EMPTY in RexImpTable

Re: NullPolicy for IS_EMPTY in RexImpTable

2024-11-07 Thread Chris Dennis
I’m really not fussed about whether a patch written by me gets integrated, or if someone codes up an equivalent fix and writes their own test. I was merely trying to satisfy the requirement for “a concise reproduction, ideally as a test that can be used in Calcite”. It’s a one line fix, and the

Re: NullPolicy for IS_EMPTY in RexImpTable

2024-11-07 Thread Chris Dennis
Patch with a test (probably not best placed) that exposes the issue, and a simple candidate fix. Given the nature of the bug, I’m thinking a review of the NullPolicy for all the operators in this area would make sense. By inspection there’s a whole bunch of non-null-safe Collection logic in SqlF

Re: NullPolicy for IS_EMPTY in RexImpTable

2024-11-07 Thread Mihai Budiu
Can you provide a concise reproduction, ideally as a test that can be used in Calcite (e.g., SqlValidatorTest)? Mihai From: Chris Dennis Sent: Thursday, November 7, 2024 11:06 AM To: dev@calcite.apache.org Subject: NullPolicy for IS_EMPTY in RexImpTable Hi All,

NullPolicy for IS_EMPTY in RexImpTable

2024-11-07 Thread Chris Dennis
Hi All, I’m working on a calcite adapter and I’m hitting issues with handling array columns. I’m seeing NullPointerExceptions from queries like “SELECT * FROM table WHERE list IS EMPTY” when “list” is a nullable column. I think the root cause here might be the NullPolicy for the IS_EMPTY operat