Re: Feedback on a generic return type version of RelShuttle?

2021-12-04 Thread Jacques Nadeau
A few thoughts: Algebra approach. If I understand the model correctly, I actually implemented this in a different project last year (not knowing it was now a design pattern). My main finding was that while it had certain benefits, it was pretty confusing for most people. I am planning to go aga

Re: Feedback on a generic return type version of RelShuttle?

2021-12-04 Thread Stamatis Zampetakis
The visitor pattern is not something written in stone. We all have a general understanding of what a visitor is and how it is used but there are also widely used variations. The following snippet (referring to the visitor pattern) is taken from "Design Patterns: Elements of Reusable Object-Oriente

[jira] [Created] (CALCITE-4924) The COVAR aggregate function returns a wrong data type

2021-12-04 Thread duan xiong (Jira)
duan xiong created CALCITE-4924: --- Summary: The COVAR aggregate function returns a wrong data type Key: CALCITE-4924 URL: https://issues.apache.org/jira/browse/CALCITE-4924 Project: Calcite Issu

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

2021-12-04 Thread Michael Mior
It can't really be fully automatic because sometimes we may want to legitimately add a new dependency. I would be interested in thinking about how we could make sure unwanted dependencies don't creep in. Part of the problem is that the release manager may not know what dependencies should or should