[GitHub] hsyuan opened a new pull request #1048: [CALCITE-2722] Rewrite createLeftCall in iterative way instead of recursive way

hsyuan opened a new pull request #1048: [CALCITE-2722] Rewrite createLeftCall in iterative way instead of recursive way URL: https://github.com/apache/calcite/pull/1048 This is intended to avoid potential stack overflow caused by recursive function call. Codes changes are covered by tes

Re: CalciteRemoteDriverTest vs avatica.MetaImpl vs avatica.server.Main thread safety

Simplest thing would be a singleton guarded by some kind of lock. But I haven’t looked at the code. > On Feb 15, 2019, at 12:59 PM, Vladimir Sitnikov > wrote: > > Julian> allocate a new object per request > > Josh> The Meta implementation inside of the Avatica server is a singleton, > > Juli

Re: [DISCUSS] Move site repositories from svn to gitbox

Agreed, the history of the web site is not very important. Julian > On Feb 15, 2019, at 5:58 AM, Michael Mior wrote: > > I think we may want to keep the old SVN repository around if this is > the case, but I personally don't have a problem with losing history in > the new git repo. On a relate

Re: CalciteRemoteDriverTest vs avatica.MetaImpl vs avatica.server.Main thread safety

Julian> allocate a new object per request Josh> The Meta implementation inside of the Avatica server is a singleton, Julian, I don't think singletones can be allocated per request. I don't think final fields of singletones can be changed on a per-request basis. What's your suggestion then? I've

[jira] [Created] (CALCITE-2853) avatica.MetaImpl and calcite.jdbc.CalciteMetaImpl are not thread-safe

Vladimir Sitnikov created CALCITE-2853: -- Summary: avatica.MetaImpl and calcite.jdbc.CalciteMetaImpl are not thread-safe Key: CALCITE-2853 URL: https://issues.apache.org/jira/browse/CALCITE-2853 P

Re: CalciteRemoteDriverTest vs avatica.MetaImpl vs avatica.server.Main thread safety

Common strategies for implementing servers using non-thread-safe objects: use one object and ensure only one thread uses it at a time (the actor model), allocate a new object per request, or (if creating an object is expensive) pool objects and re-use them for later requests. > On Feb 15, 2019,

Re: CalciteRemoteDriverTest vs avatica.MetaImpl vs avatica.server.Main thread safety

Julian> Indeed, JDBC itself is not thread-safe Just in case: CalciteRemoteDriverTest seems to be pretty sane test (it does not use the same java.sql.Connection across multiple threads), yet it fails with race-condition-like reasons. I won't really want to dig into JDBC thread-safety, however that

Re: CalciteRemoteDriverTest vs avatica.MetaImpl vs avatica.server.Main thread safety

+1 what Josh said. Also: non-thread-safe is not necessarily a bad thing. As long as the caller knows the limitation. Code that is written only to work single-threaded is more efficient and has fewer bugs. Indeed, JDBC itself is not thread-safe. It is not safe for two threads to access the sam

Re: Failed to parse a PostgreSQL query using the Babel conformance

I’ve added comments to the JIRA case. > On Feb 15, 2019, at 5:22 AM, Muhammad Gelbana wrote: > > Here is what I've done so far for CALCITE-2843 > : > https://github.com/MGelbana/calcite/pull/1/files > I appreciate a quick overview and guidance

[GitHub] vlsi commented on issue #998: Suggestion: Improvement of Autoboxing and Unboxing

vlsi commented on issue #998: Suggestion: Improvement of Autoboxing and Unboxing URL: https://github.com/apache/calcite/pull/998#issuecomment-464091696 @o0lwj0o , >The other potential problem is that Java implement autoboxing and unboxing since JDK 1.5. If run this in low version JD

[jira] [Created] (CALCITE-2852) Simplification: enable traversal of unknown UDFs

Zoltan Haindrich created CALCITE-2852: - Summary: Simplification: enable traversal of unknown UDFs Key: CALCITE-2852 URL: https://issues.apache.org/jira/browse/CALCITE-2852 Project: Calcite

[jira] [Created] (CALCITE-2851) Simplification: track visited nodes in paranoid mode

Zoltan Haindrich created CALCITE-2851: - Summary: Simplification: track visited nodes in paranoid mode Key: CALCITE-2851 URL: https://issues.apache.org/jira/browse/CALCITE-2851 Project: Calcite

Re: [DISCUSS] Move site repositories from svn to gitbox

I think we may want to keep the old SVN repository around if this is the case, but I personally don't have a problem with losing history in the new git repo. On a related note, it would be good to find a process for the new repo that can work with a shallow clone so we don't have to have the entire

Re: Failed to parse a PostgreSQL query using the Babel conformance

Here is what I've done so far for CALCITE-2843 : https://github.com/MGelbana/calcite/pull/1/files I appreciate a quick overview and guidance if I'm going in the wrong direction. Thanks, Gelbana On Thu, Feb 14, 2019 at 5:57 PM Muhammad Gelbana

Re: Use of noDag parameter in HepPlanner

FYI, what I concluded by going through the code and the various test cases is the following. By allowing DAGs the planner can detect common sub expressions in queries and re-use an existing result without re-applying a rule if that is not necessary. This should lead to fewer object creations and r

Re: [DISCUSS] Move site repositories from svn to gitbox

Hey everyone, I have now created the calcite-site repo in Gitbox. It is now available via Github and the Gitbox endpoint, but currently empty. I am currently trying to migrate the svn repo, but it is taking a very long time and eventually timed out for me. A member of the ASF infra team has

[jira] [Created] (CALCITE-2849) Your project apache/calcite is using buggy third-party libraries [WARNING]

Kaifeng Huang created CALCITE-2849: -- Summary: Your project apache/calcite is using buggy third-party libraries [WARNING] Key: CALCITE-2849 URL: https://issues.apache.org/jira/browse/CALCITE-2849 Proj