[PR] Fix thread safety of AgentCombiner (brpc)

2025-04-13 Thread via GitHub
chenBright opened a new pull request, #2949: URL: https://github.com/apache/brpc/pull/2949 ### What problem does this PR solve? Issue Number: resolve #2937 Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance ef

Re: [I] bvar AgentCombiner 和 per-thread Agent之间竞争条件 (brpc)

2025-04-13 Thread via GitHub
chenBright commented on issue #2937: URL: https://github.com/apache/brpc/issues/2937#issuecomment-2800010264 DoublyBufferedData也有同样的问题 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Oncall report from Apr 7th to Apr 13th

2025-04-13 Thread Weibing Wang
Hi, all During the last week, 19 issues were closed and the following 5 PRs were merged: * Bugfix/make bthread tag defaut right https://github.com/apache/brpc/pull/2948 * Nit enhance 25 03 05 https://github.com/apache/brpc/pull/2911 * add headers to sub cntl https://github.com/apache/brpc/pull/29

Re: [PR] Support various payload of baidu-std: json, proto-json and proto-text (brpc)

2025-04-13 Thread via GitHub
wwbmmm commented on PR #2946: URL: https://github.com/apache/brpc/pull/2946#issuecomment-2799941978 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

(brpc) branch master updated: Make socket default bthread tag right (#2948)

2025-04-13 Thread guangmingchen
This is an automated email from the ASF dual-hosted git repository. guangmingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new d9dd7b05 Make socket default bthread tag ri

Re: [PR] Bugfix/make bthread tag defaut right (brpc)

2025-04-13 Thread via GitHub
chenBright merged PR #2948: URL: https://github.com/apache/brpc/pull/2948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.or

Re: [PR] Bugfix/make bthread tag defaut right (brpc)

2025-04-13 Thread via GitHub
wwbmmm commented on PR #2948: URL: https://github.com/apache/brpc/pull/2948#issuecomment-2799938172 > 我觉得tag是一个上下文,在系统启动过程应该初始化好,后续的执行流总是切换tag感觉就不太合理了。 有这样的场景,从tag1接受网络消息,然后用户将任务丢给tag2处理,然后在tag2里面返回网络应答,这个过程是不会创建新socket的,接受网络消息的socket是tag1,在它的生命周期里面tag不会改变。 bthread的创建是用户可调用、可配置的,但是socket的创

Re: [PR] epoll bthread deal first (brpc)

2025-04-13 Thread via GitHub
zhengJade commented on code in PR #2819: URL: https://github.com/apache/brpc/pull/2819#discussion_r2041500195 ## src/brpc/event_dispatcher_epoll.cpp: ## @@ -70,7 +70,8 @@ int EventDispatcher::Start(const bthread_attr_t* consumer_thread_attr) { // Set _thread_attr before cr

Re: [PR] epoll bthread deal first (brpc)

2025-04-13 Thread via GitHub
zhengJade commented on code in PR #2819: URL: https://github.com/apache/brpc/pull/2819#discussion_r2041505792 ## src/bthread/task_group.h: ## @@ -200,6 +200,8 @@ class TaskGroup { return total_ns; } +const bthread_attr_t& get_current_attr() { return _cur_meta

Re: [PR] epoll bthread deal first (brpc)

2025-04-13 Thread via GitHub
zhengJade commented on code in PR #2819: URL: https://github.com/apache/brpc/pull/2819#discussion_r2041499486 ## src/bthread/task_control.cpp: ## @@ -430,6 +435,11 @@ int TaskControl::_destroy_group(TaskGroup* g) { bool TaskControl::steal_task(bthread_t* tid, size_t* seed, si