Re: [PR] add headers to sub cntl. (brpc)

2025-04-10 Thread via GitHub
wwbmmm commented on PR #2943: URL: https://github.com/apache/brpc/pull/2943#issuecomment-2785019523 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] iobuf support reserve_aligned (brpc)

2025-04-10 Thread via GitHub
chenBright commented on code in PR #2942: URL: https://github.com/apache/brpc/pull/2942#discussion_r2037183270 ## src/butil/iobuf.cpp: ## @@ -1371,6 +1412,35 @@ IOBuf::Area IOBuf::reserve(size_t count) { return result; } +IOBuf::Area IOBuf::reserve_aligned(size_t n, size

Re: [PR] iobuf support reserve_aligned (brpc)

2025-04-10 Thread via GitHub
yanglimingcn commented on code in PR #2942: URL: https://github.com/apache/brpc/pull/2942#discussion_r2036747959 ## src/butil/iobuf.cpp: ## @@ -1371,6 +1412,35 @@ IOBuf::Area IOBuf::reserve(size_t count) { return result; } +IOBuf::Area IOBuf::reserve_aligned(size_t n, si

Re: [PR] add headers to sub cntl. (brpc)

2025-04-10 Thread via GitHub
beesflower commented on code in PR #2943: URL: https://github.com/apache/brpc/pull/2943#discussion_r2033382344 ## src/brpc/selective_channel.cpp: ## @@ -334,7 +334,11 @@ int Sender::IssueRPC(int64_t start_realtime_us) { sub_cntl->set_request_code(_main_cntl->request_code())

(brpc) branch master updated: Add headers to sub cntl. (#2943)

2025-04-10 Thread guangmingchen
This is an automated email from the ASF dual-hosted git repository. guangmingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new c7ed9f69 Add headers to sub cntl. (#2943) c

Re: [PR] iobuf support reserve_aligned (brpc)

2025-04-10 Thread via GitHub
yanglimingcn commented on code in PR #2942: URL: https://github.com/apache/brpc/pull/2942#discussion_r2032265002 ## src/butil/iobuf.cpp: ## @@ -1371,6 +1371,41 @@ IOBuf::Area IOBuf::reserve(size_t count) { return result; } +IOBuf::Area IOBuf::reserve_aligned(size_t n, si

Re: [PR] iobuf support reserve_aligned (brpc)

2025-04-10 Thread via GitHub
yanglimingcn commented on code in PR #2942: URL: https://github.com/apache/brpc/pull/2942#discussion_r2034951126 ## src/butil/iobuf.cpp: ## @@ -1371,6 +1371,50 @@ IOBuf::Area IOBuf::reserve(size_t count) { return result; } +IOBuf::Area IOBuf::reserve_aligned(size_t n, si

Re: [PR] Support various payload of baidu-std: json, proto-json and proto-text (brpc)

2025-04-10 Thread via GitHub
wwbmmm commented on PR #2946: URL: https://github.com/apache/brpc/pull/2946#issuecomment-2795617960 有点复杂了。我觉得把compress和序列化方式耦合在一起不太好,组合太多了。 可以考虑先序列化成一个SerializedRequest,然后再传进Compress。 解压的时候先Decompress成一个SerializedRequest,然后再反序列化。 或者能不能把序列化/反序列化的工作交给用户自己去做呢?用户只要传递SerializedRequest/Se

Re: [PR] Nit enhance 25 03 05 (brpc)

2025-04-10 Thread via GitHub
wwbmmm merged PR #2911: URL: https://github.com/apache/brpc/pull/2911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated (c7ed9f69 -> f8eb9ec0)

2025-04-10 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git from c7ed9f69 Add headers to sub cntl. (#2943) add f8eb9ec0 Nit enhance with const string (#2911) No new revisions were

Re: [I] Ubuntu24.04编译失败 (brpc)

2025-04-10 Thread via GitHub
wwbmmm commented on issue #2939: URL: https://github.com/apache/brpc/issues/2939#issuecomment-2795656658 > 为啥测试还能失败呀??? 测试环境没有公网访问权限吧? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[I] segment fault when use server_options.http_master_service (brpc)

2025-04-10 Thread via GitHub
gulu-goolu opened a new issue, #2947: URL: https://github.com/apache/brpc/issues/2947 **Describe the bug (描述bug)** ``` (lldb) bt * thread #5, name = 'brpc_wkr:0-1', stop reason = signal SIGSEGV: address not mapped to object (fault address: 0x0) frame #0: 0x563c6bcc s

Re: [I] 请教长连接下的负载均衡问题 (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2926: 请教长连接下的负载均衡问题 URL: https://github.com/apache/brpc/issues/2926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...

Re: [I] example echo_c++ clang 编译后运行 SIGSEGV (brpc)

2025-04-10 Thread via GitHub
wwbmmm commented on issue #2936: URL: https://github.com/apache/brpc/issues/2936#issuecomment-2795673288 建议清除所有编译缓存后重新用clang编译看看。如果还有问题,关掉clang的编译优化选项,重新编译看看 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [I] 服务卡死(死锁?),并且关闭请求后,也无法恢复 (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2912: 服务卡死(死锁?),并且关闭请求后,也无法恢复 URL: https://github.com/apache/brpc/issues/2912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-u

Re: [I] 如何在server端打印出correlation_id? (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2900: 如何在server端打印出correlation_id? URL: https://github.com/apache/brpc/issues/2900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] bthread 怎么在启动时设置cpu亲和性 (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2885: bthread 怎么在启动时设置cpu亲和性 URL: https://github.com/apache/brpc/issues/2885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

Re: [I] brpc的coroutine模式可以将coroutine调度到其他pthread吗 (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2903: brpc的coroutine模式可以将coroutine调度到其他pthread吗 URL: https://github.com/apache/brpc/issues/2903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [I] How do server create stream, and write message to client using stream (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2863: How do server create stream, and write message to client using stream URL: https://github.com/apache/brpc/issues/2863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] 怎么在服务启动后动态设置method级别的最大并发 (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2873: 怎么在服务启动后动态设置method级别的最大并发 URL: https://github.com/apache/brpc/issues/2873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev

Re: [I] 为什么每次只 steal 一个 tid 呢? (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2817: 为什么每次只 steal 一个 tid 呢? URL: https://github.com/apache/brpc/issues/2817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

Re: [I] 请问服务端回response或者客户端发送request时所使用的WriteRequest链表为什么需要反转? (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2762: 请问服务端回response或者客户端发送request时所使用的WriteRequest链表为什么需要反转? URL: https://github.com/apache/brpc/issues/2762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] 按照官网的操作在centos上编译报错了 (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2779: 按照官网的操作在centos上编译报错了 URL: https://github.com/apache/brpc/issues/2779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsu

Re: [I] 为什么brpc框架内部大部分计时都没有使用 MONOTONIC,是有性能或其他方面的考虑吗? (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2763: 为什么brpc框架内部大部分计时都没有使用 MONOTONIC,是有性能或其他方面的考虑吗? URL: https://github.com/apache/brpc/issues/2763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [I] no member named 'set_after_rpc_resp_fn' in 'brpc::Controller' (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2854: no member named 'set_after_rpc_resp_fn' in 'brpc::Controller' URL: https://github.com/apache/brpc/issues/2854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] cpu profiler异常符号 (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2795: cpu profiler异常符号 URL: https://github.com/apache/brpc/issues/2795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

Re: [I] 请问brpc作为client端调用dubbo server支持吗,或者实现思路 (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2723: 请问brpc作为client端调用dubbo server支持吗,或者实现思路 URL: https://github.com/apache/brpc/issues/2723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [I] sizeof(Butex) == BAIDU_CACHELINE_SIZE static assertion failed (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2699: sizeof(Butex) == BAIDU_CACHELINE_SIZE static assertion failed URL: https://github.com/apache/brpc/issues/2699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] 协议中能不能直接支持基于特殊分隔符的分包和基于包长的分包 (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2712: 协议中能不能直接支持基于特殊分隔符的分包和基于包长的分包 URL: https://github.com/apache/brpc/issues/2712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] example echo_c++ clang 编译后运行 SIGSEGV (brpc)

2025-04-10 Thread via GitHub
middaywords closed issue #2936: example echo_c++ clang 编译后运行 SIGSEGV URL: https://github.com/apache/brpc/issues/2936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [I] 一个stream卡住导致其他连接也无法建立 (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2847: 一个stream卡住导致其他连接也无法建立 URL: https://github.com/apache/brpc/issues/2847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-uns

Re: [I] 线程池的线程回收退时core在brpc https://github.com/apache/brpc/issues/1606 (brpc)

2025-04-10 Thread via GitHub
wwbmmm closed issue #2685: 线程池的线程回收退时core在brpc https://github.com/apache/brpc/issues/1606 URL: https://github.com/apache/brpc/issues/2685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] rdma support polling mode (brpc)

2025-04-10 Thread via GitHub
yanglimingcn commented on PR #2920: URL: https://github.com/apache/brpc/pull/2920#issuecomment-2795984926 > @Tuvie 有空看看 @wwbmmm @Tuvie 这个有时间看看吧。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] iobuf support reserve_aligned (brpc)

2025-04-10 Thread via GitHub
chenBright commented on code in PR #2942: URL: https://github.com/apache/brpc/pull/2942#discussion_r2032659341 ## src/butil/iobuf.cpp: ## @@ -1371,6 +1371,50 @@ IOBuf::Area IOBuf::reserve(size_t count) { return result; } +IOBuf::Area IOBuf::reserve_aligned(size_t n, size

[PR] add headers to sub cntl. (brpc)

2025-04-10 Thread via GitHub
beesflower opened a new pull request, #2943: URL: https://github.com/apache/brpc/pull/2943 ### What problem does this PR solve? Fixed the issue that when using SelectiveChannel, the header could not be transparently transmitted to the subchannel. Issue Number: Problem Summary:

[PR] Support various payload of baidu-std: json, proto-json and proto-text (brpc)

2025-04-10 Thread via GitHub
chenBright opened a new pull request, #2946: URL: https://github.com/apache/brpc/pull/2946 ### What problem does this PR solve? Issue Number: #2405 Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能

Re: [PR] iobuf support reserve_aligned (brpc)

2025-04-10 Thread via GitHub
yanglimingcn commented on code in PR #2942: URL: https://github.com/apache/brpc/pull/2942#discussion_r2031323015 ## src/butil/iobuf.cpp: ## @@ -1371,6 +1371,41 @@ IOBuf::Area IOBuf::reserve(size_t count) { return result; } +IOBuf::Area IOBuf::reserve_aligned(size_t n, si