Re: [PR] fix batch create stream and make SetHostSocket thread safe (brpc)

2025-04-06 Thread via GitHub
jenrryyou commented on code in PR #2938: URL: https://github.com/apache/brpc/pull/2938#discussion_r2030132594 ## src/brpc/stream_impl.h: ## @@ -134,6 +134,7 @@ friend struct butil::DefaultDeleter; butil::IOBuf *_pending_buf; int64_t _start_idle_timer_us; bthread_t

[PR] Fix class data for protobuf v26+ (brpc)

2025-04-06 Thread via GitHub
wasphin opened a new pull request, #2941: URL: https://github.com/apache/brpc/pull/2941 ### What problem does this PR solve? Issue Number: #2917 Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):

Re: [I] some function not work in protobuf v5 (brpc)

2025-04-06 Thread via GitHub
wasphin commented on issue #2917: URL: https://github.com/apache/brpc/issues/2917#issuecomment-2781498642 抱歉这一段事情比较多,没太顾上。 验证了下,应该并不是隐藏 New 导致的,使用 28.3 版本编译并没有问题,问题出在运行的时候。Protobuf 26+ 后开始使用 `ClassData` 存储一些元信息,`GetMetadata` 改为基于该信息实现。 -- This is an automated message from the A

Re: [PR] Fix class data for protobuf v27+ (brpc)

2025-04-06 Thread via GitHub
wwbmmm commented on PR #2941: URL: https://github.com/apache/brpc/pull/2941#issuecomment-2781846007 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] fix batch create stream and make SetHostSocket thread safe (brpc)

2025-04-06 Thread via GitHub
wwbmmm commented on PR #2938: URL: https://github.com/apache/brpc/pull/2938#issuecomment-2781844799 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] epoll bthread deal first (brpc)

2025-04-06 Thread via GitHub
wwbmmm commented on code in PR #2819: URL: https://github.com/apache/brpc/pull/2819#discussion_r2030365543 ## src/bthread/task_control.h: ## @@ -153,6 +157,7 @@ friend bthread_t init_for_pthread_stack_trace(); std::vector*> _tagged_cumulated_worker_time; std::vector>*>

[PR] iobuf support reserve_aligned (brpc)

2025-04-06 Thread via GitHub
yanglimingcn opened a new pull request, #2942: URL: https://github.com/apache/brpc/pull/2942 ### What problem does this PR solve? IOBuf通过reserve_aligned(size_t n, size_t alignment)函数在IOBuf内部预分配一些符合对齐规则的内存,后续可以通过unsafe_assign函数或者IOBufAsZeroCopyInputStream等函数把这些内存段解析出来,让用户填充数据。 这样做的好

Oncall report from Mar.31st to Apr.6th

2025-04-06 Thread Lorin Lee
Hi all, Over the past week, the following PRs were merged: * Fix compiler optimize thread local variable access #2918 ( https://github.com/apache/brpc/pull/2918) * jemalloc profiler support objects #2929 ( https://github.com/apache/brpc/pull/2929) Best regards, Lorin Lee