(brpc) branch master updated: Disable CondTest.too_many_bthreads_from_bthread in asan ut (#2940)

2025-04-05 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 06259458 Disable CondTest.too_many_bthreads_from_b

Re: [PR] fix batch create stream and make SetHostSocket thread safe (brpc)

2025-04-05 Thread via GitHub
wwbmmm commented on code in PR #2938: URL: https://github.com/apache/brpc/pull/2938#discussion_r2030032623 ## src/brpc/stream_impl.h: ## @@ -134,6 +134,7 @@ friend struct butil::DefaultDeleter; butil::IOBuf *_pending_buf; int64_t _start_idle_timer_us; bthread_time

Re: [PR] Disable CondTest.too_many_bthreads_from_bthread in asan ut (brpc)

2025-04-05 Thread via GitHub
wwbmmm merged PR #2940: URL: https://github.com/apache/brpc/pull/2940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

Re: [I] 有支持Arena的计划吗 (brpc)

2025-04-05 Thread via GitHub
chenBright commented on issue #1595: URL: https://github.com/apache/brpc/issues/1595#issuecomment-2765045694 #2751 已经支持Arena。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] 服务卡死(死锁?),并且关闭请求后,也无法恢复 (brpc)

2025-04-05 Thread via GitHub
yufeixu-sohu commented on issue #2912: URL: https://github.com/apache/brpc/issues/2912#issuecomment-2768409656 如何解决呢? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [I] 流量大的时候,引起异常bug,即使扩容也不生效 (brpc)

2025-04-05 Thread via GitHub
namelij commented on issue #2927: URL: https://github.com/apache/brpc/issues/2927#issuecomment-2774164018 > 用cpu profiler分析看看 请教个问题,我们这个 是入口服务,即用brpc实现的server,又有 client对外请求 是不是可以 在服务层面增加增加措施,如果服务扛不住了,可以不再处理后续请求,这块有什么好的建议么 -- This is an automated message from the Apache Git Se

Re: [I] 线程池的线程回收退时core在brpc https://github.com/apache/brpc/issues/1606 (brpc)

2025-04-05 Thread via GitHub
ligangbin117 commented on issue #2685: URL: https://github.com/apache/brpc/issues/2685#issuecomment-2774125041 > [#2727](https://github.com/apache/brpc/pull/2727) 支持使用`NO_PTHREAD_MUTEX_HOOK`关闭hook 使用NO_PTHREAD_MUTEX_HOOK关闭后是没有问题的,和https://github.com/apache/brpc/issues/2266 这个效果应该是一样

(brpc) branch master updated (f44f803a -> 98556972)

2025-04-05 Thread lorinlee
This is an automated email from the ASF dual-hosted git repository. lorinlee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git from f44f803a Fix asan switch fiber with error stack info (#2931) add b38ffa42 jemalloc profiler support objects

Re: [I] bthread signal & wait 问题咨询 (brpc)

2025-04-05 Thread via GitHub
GreateCode commented on issue #2849: URL: https://github.com/apache/brpc/issues/2849#issuecomment-2771834592 类似go的 steal half是不是更好一些 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] brpc streaming 自动切分大消息讨论/ brpc streaming auto cutting big message (brpc)

2025-04-05 Thread via GitHub
chenBright closed issue #1556: brpc streaming 自动切分大消息讨论/ brpc streaming auto cutting big message URL: https://github.com/apache/brpc/issues/1556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] move clean_tls_bls to single noinline function to avoid compiler optimization (brpc)

2025-04-05 Thread via GitHub
chenBright commented on PR #2934: URL: https://github.com/apache/brpc/pull/2934#issuecomment-2774692274 > 是否可以在访问tls_bls变量时使用 BAIDU_GET_VOLATILE_THREAD_LOCAL宏?这种方法应该更通用一些 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Support ProtoJson formatted http body (brpc)

2025-04-05 Thread via GitHub
wwbmmm commented on PR #2921: URL: https://github.com/apache/brpc/pull/2921#issuecomment-2742845240 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

(brpc) branch master updated: Support a more safe read function and variadic functions of DoublyBufferedData (#2898)

2025-04-05 Thread guangmingchen
This is an automated email from the ASF dual-hosted git repository. guangmingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new da4e33a6 Support a more safe read function

Re: [PR] Fix compiler optimize thread local variable access (brpc)

2025-04-05 Thread via GitHub
zcfh commented on PR #2918: URL: https://github.com/apache/brpc/pull/2918#issuecomment-2732058034 > 为什么不使用 BAIDU_GET_VOLATILE_THREAD_LOCAL 宏的方式? 这里我的考虑是,使用 BAIDU_GET_VOLATILE_THREAD_LOCAL 的方式,在非LTO模式下,多了一次函数调用。 只要让它在LTO模式下不inline,那编译器就不会去做优化,**这样改动更小些**。其他地方因为在一个函数内,会多次访问tls_task_g

Re: [PR] Fix some unstable UTs (brpc)

2025-04-05 Thread via GitHub
wwbmmm commented on PR #2928: URL: https://github.com/apache/brpc/pull/2928#issuecomment-2761137230 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [I] Ubuntu24.04编译失败 (brpc)

2025-04-05 Thread via GitHub
InternetofThingsprogrammer commented on issue #2939: URL: https://github.com/apache/brpc/issues/2939#issuecomment-2780706358 > 为啥测试还能失败呀??? ./test/bthread_fd_unittest Running main() from gtest_main.cc [==] Running 13 tests from 1 test case. [--] Global test environment set-u

Re: [PR] move clean_tls_bls to single noinline function to avoid compiler optimization (brpc)

2025-04-05 Thread via GitHub
chenBright commented on PR #2934: URL: https://github.com/apache/brpc/pull/2934#issuecomment-2774694603 master已经修复了ci中cmake的问题,麻烦rebase一下。@BiteThet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] Disable CondTest.too_many_bthreads_from_bthread in asan ut (brpc)

2025-04-05 Thread via GitHub
chenBright opened a new pull request, #2940: URL: https://github.com/apache/brpc/pull/2940 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):

Re: [I] Ubuntu24.04编译失败 (brpc)

2025-04-05 Thread via GitHub
InternetofThingsprogrammer commented on issue #2939: URL: https://github.com/apache/brpc/issues/2939#issuecomment-2780660433 为啥测试还能失败呀??? ./test/bthread_fd_unittest Running main() from gtest_main.cc [==] Running 13 tests from 1 test case. [--] Global test environm

(brpc) 01/01: Merge pull request #2929 from GreateCode/jemalloc_objects

2025-04-05 Thread lorinlee
This is an automated email from the ASF dual-hosted git repository. lorinlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git commit 985569728a5d4f691ca6b7517f66f33e5789942f Merge: f44f803a b38ffa42 Author: LorinLee AuthorDate: Thu Apr 3 22:36:59 2025 +

[PR] jemalloc profiler support objects (brpc)

2025-04-05 Thread via GitHub
GreateCode opened a new pull request, #2929: URL: https://github.com/apache/brpc/pull/2929 ### What problem does this PR solve? Issue Number: Problem Summary: 1. 重置采样率还会继续采样,不应设置FLAGS_je_prof_active=false。 2. 想看到内存对象数,而不只是大小。 ### What is changed and the side eff

Re: [PR] support dynamic update method concurrency (brpc)

2025-04-05 Thread via GitHub
wwbmmm commented on code in PR #2923: URL: https://github.com/apache/brpc/pull/2923#discussion_r2007244682 ## src/brpc/policy/auto_concurrency_limiter.cpp: ## @@ -134,6 +134,8 @@ int AutoConcurrencyLimiter::MaxConcurrency() { return _max_concurrency; } +int AutoConcurren

Re: [PR] Fix compiler optimize thread local variable access (brpc)

2025-04-05 Thread via GitHub
zcfh commented on PR #2918: URL: https://github.com/apache/brpc/pull/2918#issuecomment-2742685114 还有几个问题请教下。 1. 还会有其他类似的场景吗?实现是在cpp里,只是非LTO模式下,不触发这个问题。 2. 这个pr的合入后续还需要我这里做什么吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Fix __sanitizer_start_switch_fiber with error stack info (brpc)

2025-04-05 Thread via GitHub
chenBright commented on PR #2931: URL: https://github.com/apache/brpc/pull/2931#issuecomment-2767962165 @BusyJay CC -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [I] 如果server被kill掉,client有一定几率coredump (brpc)

2025-04-05 Thread via GitHub
imdouyu commented on issue #2922: URL: https://github.com/apache/brpc/issues/2922#issuecomment-2740531562 > 这个栈不太能说明是bRPC的问题,你可以把client的处理逻辑先屏蔽掉吗?然后试试?复现的概率大吗? 在我们的场景中比较容易复现,我试试构造一个可复现的mini example -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Fix #2146 E112 EHOSTDOWN in short and pooled connection (brpc)

2025-04-05 Thread via GitHub
chenBright commented on PR #2177: URL: https://github.com/apache/brpc/pull/2177#issuecomment-2761972312 > @Huixxi 能给解释一下,当前的代码是因为bug还是因为设计上导致的E112无法恢复吗?想知道根音,然后目前的方案是解决设计问题,还是做一个兜底。 我计较好奇“E112无法恢复”的原因。我理解上“E112无法恢复”有两种场景: 1. 健康检查一直失败; 2. E112后经健康检查恢复后,又出现E112,一直反复。 -- This is

Re: [I] brpc可以支持预连接吗 (brpc)

2025-04-05 Thread via GitHub
chenBright closed issue #2617: brpc可以支持预连接吗 URL: https://github.com/apache/brpc/issues/2617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

Re: [PR] Support a more safe read function and variadic functions of DoublyBufferedData (brpc)

2025-04-05 Thread via GitHub
chenBright merged PR #2898: URL: https://github.com/apache/brpc/pull/2898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.or