Re: [PR] jemalloc profiler support objects (brpc)

2025-03-30 Thread via GitHub
GreateCode commented on PR #2929: URL: https://github.com/apache/brpc/pull/2929#issuecomment-2764467656 > > 1. 重置采样率还会继续采样,不应设置FLAGS_je_prof_active=false。 > > 这样修改了程序的默认行为,是否会影响原来的用户? 不会,改的不是默认值,是手动触发FLAGS_je_prof_reset时,对FLAGS_je_prof_active值的更新,此时没有修改jemalloc内部参数,现在改后FLAGS_je

Re: [PR] jemalloc profiler support objects (brpc)

2025-03-30 Thread via GitHub
wwbmmm commented on PR #2929: URL: https://github.com/apache/brpc/pull/2929#issuecomment-2764449452 > 1. 重置采样率还会继续采样,不应设置FLAGS_je_prof_active=false。 这样修改了程序的默认行为,是否会影响原来的用户? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [I] 服务卡死(死锁?),并且关闭请求后,也无法恢复 (brpc)

2025-03-30 Thread via GitHub
Tech-Circle-48 commented on issue #2912: URL: https://github.com/apache/brpc/issues/2912#issuecomment-2764521852 可以一起参与吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix #2146 E112 EHOSTDOWN in short and pooled connection (brpc)

2025-03-30 Thread via GitHub
chenBright commented on PR #2177: URL: https://github.com/apache/brpc/pull/2177#issuecomment-2764637743 > 好像从已有的Failed的Socket上也能够获取到EndPoint字段? 可以使用AddressFailedAsWell。 > 需要区分Socket的连接状态和屏蔽状态,LB看的是屏蔽状态,实际连接的时候,再看连接状态,如果连接状态是Failed时再启动备用连接之类的。 目前LB将会屏蔽Failed连接状态的Socket,除此

[PR] Remove the unused INVALID_PTHREAD_KEY (brpc)

2025-03-30 Thread via GitHub
chenBright opened a new pull request, #2930: URL: https://github.com/apache/brpc/pull/2930 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):

Re: [I] 请教长连接下的负载均衡问题 (brpc)

2025-03-30 Thread via GitHub
Tech-Circle-48 commented on issue #2926: URL: https://github.com/apache/brpc/issues/2926#issuecomment-2764523385 我理解rr是在请求阶段,brpc会为每个RS建立一个SubChannel,每个SubChannel对应一个连接。请求发送的时候,从活跃的SubChannel列表中进行RR选择 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Support AddressSanitizer (brpc)

2025-03-30 Thread via GitHub
chenBright commented on code in PR #2890: URL: https://github.com/apache/brpc/pull/2890#discussion_r2019890431 ## src/bthread/task_group.cpp: ## @@ -657,7 +715,11 @@ void TaskGroup::sched_to(TaskGroup** pg, TaskMeta* next_meta) { g->_control->_task_tracer.set_s

Re: [I] 服务卡死(死锁?),并且关闭请求后,也无法恢复 (brpc)

2025-03-30 Thread via GitHub
chenBright commented on issue #2912: URL: https://github.com/apache/brpc/issues/2912#issuecomment-2764621835 看着像是usercode_in_pthread模式下,所有worker都卡在同步RPC,没有worker处理response了。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

(brpc) branch master updated: support dynamic update method concurrency (#2923)

2025-03-30 Thread jiashunzhu
This is an automated email from the ASF dual-hosted git repository. jiashunzhu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new bf88565c support dynamic update method concurr

Oncall report from Mar.24th to Mar.30th

2025-03-30 Thread Jiashun Zhu
Hi all, Over the past week, the following PRs were merged: * Support AddressSanitizer #2890 (https://github.com/apache/brpc/pull/2890) * Fix some unstable UTs #2928 (https://github.com/apache/brpc/pull/2928) * Support ProtoJson formatted http body #2921 ( https://github.com/apache/brpc/pull/2921)

Re: [I] 有没有办法由使用方控制request和response的析构时机 (brpc)

2025-03-30 Thread via GitHub
chenBright closed issue #1315: 有没有办法由使用方控制request和response的析构时机 URL: https://github.com/apache/brpc/issues/1315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] lalb在有可用节点的情况下仍可能触发“[E112]Fail to select server...” (brpc)

2025-03-30 Thread via GitHub
chenBright closed issue #2427: lalb在有可用节点的情况下仍可能触发“[E112]Fail to select server...” URL: https://github.com/apache/brpc/issues/2427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] jemalloc profiler support objects (brpc)

2025-03-30 Thread via GitHub
wwbmmm commented on PR #2929: URL: https://github.com/apache/brpc/pull/2929#issuecomment-2764935186 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Support AddressSanitizer (brpc)

2025-03-30 Thread via GitHub
BusyJay commented on code in PR #2890: URL: https://github.com/apache/brpc/pull/2890#discussion_r2020463256 ## src/bthread/task_group.cpp: ## @@ -657,7 +715,11 @@ void TaskGroup::sched_to(TaskGroup** pg, TaskMeta* next_meta) { g->_control->_task_tracer.set_stat

Re: [I] 线程池的线程回收退时core在brpc https://github.com/apache/brpc/issues/1606 (brpc)

2025-03-30 Thread via GitHub
chenBright commented on issue #2685: URL: https://github.com/apache/brpc/issues/2685#issuecomment-2764442610 应该是#2727 中描述的问题 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

(brpc) branch master updated: Support ProtoJson formatted http body (#2921)

2025-03-30 Thread guangmingchen
This is an automated email from the ASF dual-hosted git repository. guangmingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new c7add74f Support ProtoJson formatted http b

Re: [I] revive socket should also re-resolve names (brpc)

2025-03-30 Thread via GitHub
chenBright closed issue #2666: revive socket should also re-resolve names URL: https://github.com/apache/brpc/issues/2666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Support ProtoJson formatted http body (brpc)

2025-03-30 Thread via GitHub
chenBright merged PR #2921: URL: https://github.com/apache/brpc/pull/2921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.or

Re: [PR] Remove the unused INVALID_PTHREAD_KEY (brpc)

2025-03-30 Thread via GitHub
wwbmmm merged PR #2930: URL: https://github.com/apache/brpc/pull/2930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: Remove the unused INVALID_PTHREAD_KEY (#2930)

2025-03-30 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new ab668877 Remove the unused INVALID_PTHREAD_KEY (#2

Re: [I] INVALID_PTHREAD_KEY 看着没有使用了?是不是可以去掉 (brpc)

2025-03-30 Thread via GitHub
wwbmmm closed issue #2397: INVALID_PTHREAD_KEY 看着没有使用了?是不是可以去掉 URL: https://github.com/apache/brpc/issues/2397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] Fix #2146 E112 EHOSTDOWN in short and pooled connection (brpc)

2025-03-30 Thread via GitHub
wwbmmm commented on PR #2177: URL: https://github.com/apache/brpc/pull/2177#issuecomment-2764955492 我在想能不能把SocketPool的逻辑稍微改一下,变成SingleSocketPool: GetSocket的逻辑: 如果pool里能找到不是Failed状态的Socket,就返回该Socket,且不从pool中删除 如果找到Failed状态的Socket,就从pool中删除 如果找不到可用的Socket,就新建一个Socket,并加入到Pool中,

Re: [I] 使用NotifyOnCancel时出现coredump (brpc)

2025-03-30 Thread via GitHub
ivanallen commented on issue #1369: URL: https://github.com/apache/brpc/issues/1369#issuecomment-2765199614 似乎遇到了同样的问题: ``` (gdb) bt -- #0 0x00fe657b in brpc::Controller::RunOnCancel(bthread_id_t, void*, int) () #1 0x00fc692b in bthread_id_error_verbose (

Re: [PR] support dynamic update method concurrency (brpc)

2025-03-30 Thread via GitHub
zyearn merged PR #2923: URL: https://github.com/apache/brpc/pull/2923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

Re: [I] brpc是否支持泛化调用,后续是否有相关计划? (brpc)

2025-03-30 Thread via GitHub
chenBright commented on issue #1385: URL: https://github.com/apache/brpc/issues/1385#issuecomment-2765040416 #2629 已经支持泛化调用。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] build_with_bazel 无法正常编译 (brpc)

2025-03-30 Thread via GitHub
chenBright closed issue #2365: build_with_bazel 无法正常编译 URL: https://github.com/apache/brpc/issues/2365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

Re: [I] 有没有办法由使用方控制request和response的析构时机 (brpc)

2025-03-30 Thread via GitHub
chenBright commented on issue #1315: URL: https://github.com/apache/brpc/issues/1315#issuecomment-2765042469 #2328 已经支持。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] 有支持Arena的计划吗 (brpc)

2025-03-30 Thread via GitHub
chenBright closed issue #1595: 有支持Arena的计划吗 URL: https://github.com/apache/brpc/issues/1595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

Re: [I] Brpc channel core 掉的bug (brpc)

2025-03-30 Thread via GitHub
chenBright closed issue #2461: Brpc channel core 掉的bug URL: https://github.com/apache/brpc/issues/2461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

Re: [PR] Fix #2146 E112 EHOSTDOWN in short and pooled connection (brpc)

2025-03-30 Thread via GitHub
wwbmmm commented on PR #2177: URL: https://github.com/apache/brpc/pull/2177#issuecomment-2764946349 > bRPC的恐慌策略可以这样设计:**保持LB屏蔽策略不变**,当LB选不出实例的时候,不返回E112,而是使用第一次选到实例的信息构造出一个备用Socket用于通信。在E112期间,负载均衡也是生效的,开销也比较小,只是多一次创建Socket的开销,这个Socket在恐慌周期内是可以复用的,完全可接受。 这样是不是得修改所有的LB?除了框架自带的LB,有些用户还会