Re: [PR] Fix ParkingLot::signal does not modify _pending_signal when there is no waiter (brpc)

2025-03-18 Thread via GitHub
JimChengLin commented on PR #2916: URL: https://github.com/apache/brpc/pull/2916#issuecomment-273162 > > 我参照2907的修改进行了线上小流量验证,发现tp99上涨了约2-3ms,原先tp99大概是450ms,是否也是这个原因 > > 按照这个bug_fix的修改进行了验证,tp99确实恢复了。 👍,我也去测试一下 -- This is an automated message from the Apache Git Service.

Re: [PR] Fix compiler optimize thread local variable access (brpc)

2025-03-18 Thread via GitHub
zcfh commented on PR #2918: URL: https://github.com/apache/brpc/pull/2918#issuecomment-2732918403 重新提交了一版。 另外bthread.cpp内,还有其他访问tls_task_group的情况,我没做修改。因为从我的测试排查来看,它们没有出现类似的问题。还请帮忙确认一下这个结论是否正确。 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Fix compiler optimize thread local variable access (brpc)

2025-03-18 Thread via GitHub
wwbmmm commented on PR #2918: URL: https://github.com/apache/brpc/pull/2918#issuecomment-2735202071 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [I] 求助:socket.cpp:1036, IsWriteComplete] Check failed: NULL == old_head->next (brpc)

2025-03-18 Thread via GitHub
zcfh closed issue #2572: 求助:socket.cpp:1036, IsWriteComplete] Check failed: NULL == old_head->next URL: https://github.com/apache/brpc/issues/2572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[I] apache/WLK (brpc)

2025-03-18 Thread via GitHub
volkanural opened a new issue, #2919: URL: https://github.com/apache/brpc/issues/2919 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

[I] apache/WLK [brpc-website]

2025-03-18 Thread via GitHub
volkanural opened a new issue, #174: URL: https://github.com/apache/brpc-website/issues/174 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [I] apache/WLK (brpc)

2025-03-18 Thread via GitHub
volkanural closed issue #2919: apache/WLK URL: https://github.com/apache/brpc/issues/2919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

Re: [I] brpc echo ipv6 无法使用 (brpc)

2025-03-18 Thread via GitHub
volkanural commented on issue #2841: URL: https://github.com/apache/brpc/issues/2841#issuecomment-2735242132 nasıl kullanılır -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] bazel deal with attribute const (brpc)

2025-03-18 Thread via GitHub
volkanural commented on issue #2850: URL: https://github.com/apache/brpc/issues/2850#issuecomment-2735243049 open -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] Fix compiler optimize thread local variable access (brpc)

2025-03-18 Thread via GitHub
wwbmmm commented on PR #2918: URL: https://github.com/apache/brpc/pull/2918#issuecomment-2732451853 我觉得问题的根本原因是编译器对TLS变量访问的优化,而不是内联优化,所以使用BAIDU_GET_VOLATILE_THREAD_LOCAL,是更根本的改法。 如果要区分一个函数内是一次调用还是多次调用,来使用不同的改法,这样维护成本会比较高。未来随着代码的改动,调用次数可能会发生变化,最好还是采用一种统一的改法。 -- This is an automated mes

[PR] rdma support polling mode (brpc)

2025-03-18 Thread via GitHub
yanglimingcn opened a new pull request, #2920: URL: https://github.com/apache/brpc/pull/2920 ### What problem does this PR solve? Issue Number: #1434 #2344 Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effe