Re: [I] bthread signal & wait 问题咨询 (brpc)

2025-03-17 Thread via GitHub
chenBright commented on issue #2849: URL: https://github.com/apache/brpc/issues/2849#issuecomment-2728809670 > > [@MJY-HUST](https://github.com/MJY-HUST) 可以试试[#2907](https://github.com/apache/brpc/pull/2907) 看能不能解决问题? > > 没效果 @GreateCode #2819 呢? -- This is an automated mess

Re: [I] bthread signal & wait 问题咨询 (brpc)

2025-03-17 Thread via GitHub
GreateCode commented on issue #2849: URL: https://github.com/apache/brpc/issues/2849#issuecomment-2728857589 > > > [@MJY-HUST](https://github.com/MJY-HUST) 可以试试[#2907](https://github.com/apache/brpc/pull/2907) 看能不能解决问题? > > > > > > 没效果 > > [@GreateCode](https://github.com/G

Re: [PR] Fix compiler optimize thread local variable access (brpc)

2025-03-17 Thread via GitHub
wwbmmm commented on PR #2918: URL: https://github.com/apache/brpc/pull/2918#issuecomment-2731864017 为什么不使用 BAIDU_GET_VOLATILE_THREAD_LOCAL 宏的方式? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] Fix compiler optimize thread local variable access (brpc)

2025-03-17 Thread via GitHub
zcfh opened a new pull request, #2918: URL: https://github.com/apache/brpc/pull/2918 ### What problem does this PR solve? Issue Number: Problem Summary: `bthread_usleep`/`bthread_yield` 包含对 tls_task_group 的访问,在LTO模式下,会触发 #2156 提到的问题。在example下会出现 `bthread=4294967808 sched_t

Re: [PR] Fix ParkingLot::signal does not modify _pending_signal when there is no waiter (brpc)

2025-03-17 Thread via GitHub
zhoukangsheng commented on PR #2916: URL: https://github.com/apache/brpc/pull/2916#issuecomment-2731404875 > 我参照2907的修改进行了线上小流量验证,发现tp99上涨了约2-3ms,原先tp99大概是450ms,是否也是这个原因 按照这个bug_fix的修改进行了验证,tp99确实恢复了。 -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Fix ParkingLot::signal does not modify _pending_signal when there is no waiter (brpc)

2025-03-17 Thread via GitHub
JimChengLin commented on PR #2916: URL: https://github.com/apache/brpc/pull/2916#issuecomment-2728608117 确实会有问题,我之前线上没注意到这个问题。 如果你的任务来自于 worker,parking lot 的 waiter 有可能唤醒没那么频繁,但不会信号丢失。因为 signal 的 worker 本身最终会把 task 消费掉。这个 bug/feature 会进一步减少 futex wake,降低 CPU 占用。 如果任务来自于 non-wor

Re: [PR] Fix ParkingLot::signal does not modify _pending_signal when there is no waiter (brpc)

2025-03-17 Thread via GitHub
yanglimingcn commented on PR #2916: URL: https://github.com/apache/brpc/pull/2916#issuecomment-2728636873 > 确实会有问题,我之前线上没注意到这个问题。 > > 如果你的任务来自于 worker,parking lot 的 waiter 有可能唤醒没那么频繁,但不会信号丢失。因为 signal 的 worker 本身最终会把 task 消费掉。这个 bug/feature 会进一步减少 futex wake,降低 CPU 占用。 > > 如果任务

Re: [I] some function not work in protobuf v5 (brpc)

2025-03-17 Thread via GitHub
chenBright commented on issue #2917: URL: https://github.com/apache/brpc/issues/2917#issuecomment-2728640113 cc @wasphin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Oncall report from Mar 10th to Mar 16th

2025-03-17 Thread Xiguo Hu
Hi, all During the last week 2 issues were closed. - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org

Re: [PR] Fix ParkingLot::signal does not modify _pending_signal when there is no waiter (brpc)

2025-03-17 Thread via GitHub
zhoukangsheng commented on PR #2916: URL: https://github.com/apache/brpc/pull/2916#issuecomment-2728578798 我参照2907的修改进行了线上小流量验证,发现tp99上涨了约2-3ms,原先tp99大概是450ms,是否也是这个原因 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Fix ParkingLot::signal does not modify _pending_signal when there is no waiter (brpc)

2025-03-17 Thread via GitHub
yanglimingcn commented on PR #2916: URL: https://github.com/apache/brpc/pull/2916#issuecomment-2728587930 > 我参照2907的修改进行了线上小流量验证,发现tp99上涨了约2-3ms,原先tp99大概是450ms,是否也是这个原因 这个不修改会产生bug,这个应该是必须要修改的,我这边遇到问题了。 -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Fix ParkingLot::signal does not modify _pending_signal when there is no waiter (brpc)

2025-03-17 Thread via GitHub
JimChengLin commented on PR #2916: URL: https://github.com/apache/brpc/pull/2916#issuecomment-2729206996 > yanglimingcn 有巨大的差别,syscall 的成本是 us 级别的,atomic check 是 ns 级别的。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [I] bthread signal & wait 问题咨询 (brpc)

2025-03-17 Thread via GitHub
GreateCode commented on issue #2849: URL: https://github.com/apache/brpc/issues/2849#issuecomment-2728738280 > [@MJY-HUST](https://github.com/MJY-HUST) 可以试试[#2907](https://github.com/apache/brpc/pull/2907) 看能不能解决问题? 没效果 -- This is an automated message from the Apache Git Service. T