[I] Brpc server side async or not recommendation! (brpc)

2024-09-03 Thread via GitHub
qiaobaochen opened a new issue, #2755: URL: https://github.com/apache/brpc/issues/2755 Hi, I am beginner in brpc, I decide to use brpc as a database proxy in our scenario, after I read the doc of brpc, I still cannot decide use async server or sync server in our situation. detail:

Re: [I] Brpc server side async or not recommendation! (brpc)

2024-09-03 Thread via GitHub
jamesge commented on issue #2755: URL: https://github.com/apache/brpc/issues/2755#issuecomment-2326111025 The bRPC server is asynchronous at its core, a "sync service" is just a service calling "done->Run()" before the service callback ends. You should look at interfaces of the DB client

Re: [I] Brpc server side async or not recommendation! (brpc)

2024-09-03 Thread via GitHub
qiaobaochen commented on issue #2755: URL: https://github.com/apache/brpc/issues/2755#issuecomment-2326121929 > The bRPC server is asynchronous at its core, a "sync service" is just a service calling "done->Run()" before the service callback ends. You should look at interfaces of the DB cli

Re: [I] Brpc server side async or not recommendation! (brpc)

2024-09-03 Thread via GitHub
qiaobaochen closed issue #2755: Brpc server side async or not recommendation! URL: https://github.com/apache/brpc/issues/2755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Batch create and accept stream (brpc)

2024-09-03 Thread via GitHub
jenrryyou commented on PR #2754: URL: https://github.com/apache/brpc/pull/2754#issuecomment-2326397806 看了下macos protobuf22的报错 ![image](https://github.com/user-attachments/assets/bb2708b7-0bde-4803-846a-6a8fd0739360) ,是因为链接的库libprotobuf.dylib没有 google::protobuf::internal::ThreadSafeA

Re: [PR] Active Spinning and queue old bthread at the head for bthread mutex (brpc)

2024-09-03 Thread via GitHub
chenBright commented on PR #2749: URL: https://github.com/apache/brpc/pull/2749#issuecomment-2326458507 > 有测试这个性能提升的效果吗? 1. 自旋没啥效果,应该是因为触发条件比较苛刻,不好模拟。如果本地调度队列已经空了,进程负载应该不高,不自旋、多一次唤醒,问题也不大。 2. 测试第二点优化,性能没变化。性能最好的应该是修改之前的,公平性一般会牺牲一些性能。性能和公平性是需要权衡的,golang为了公平性还引入了饥饿模式,让等待队列中饥饿(排队时间超过1

Re: [I] 有社区交流群吗 (brpc)

2024-09-03 Thread via GitHub
zhangdongqiu commented on issue #1241: URL: https://github.com/apache/brpc/issues/1241#issuecomment-2327832879 vx:xishanzhidian帮我拉到群里 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] 有社区交流群吗 (brpc)

2024-09-03 Thread via GitHub
GreateCode commented on issue #1241: URL: https://github.com/apache/brpc/issues/1241#issuecomment-2327834789 > vx:chao10001,求拉谢谢 @gydong 求 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[I] 疑似keytable内存泄漏 (brpc)

2024-09-03 Thread via GitHub
lsdh-fei opened a new issue, #2756: URL: https://github.com/apache/brpc/issues/2756 **Describe the bug (描述bug)** 升级1.10之后,内存会不断增长,在vars界面查看,发现bthread_keytable_count在不断增长,我理解keytable是thread local的,thread销毁后也会跟着销毁,不应该无限增长 **To Reproduce (复现方法)** 使用1.10之后就会出现,但是用1.8就不存在泄漏 **

Re: [PR] Active Spinning and queue old bthread at the head for bthread mutex (brpc)

2024-09-03 Thread via GitHub
wwbmmm commented on PR #2749: URL: https://github.com/apache/brpc/pull/2749#issuecomment-2327897465 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [I] 疑似keytable内存泄漏 (brpc)

2024-09-03 Thread via GitHub
chenBright commented on issue #2756: URL: https://github.com/apache/brpc/issues/2756#issuecomment-2327918899 > thread销毁后也会跟着销毁,不应该无限增长 自己起的线程中使用bthread_keytable吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] Protoc Version 版本冲突,怎么解决? (brpc)

2024-09-03 Thread via GitHub
drgnchan commented on issue #661: URL: https://github.com/apache/brpc/issues/661#issuecomment-2327936652 我是删掉了${DORIS_HOME}/thirdparty/src/brpc-1.4.0/doris_build文件夹后,再重新构建(bash build_thirdparty.sh)就通过了 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] 疑似keytable内存泄漏 (brpc)

2024-09-03 Thread via GitHub
lsdh-fei commented on issue #2756: URL: https://github.com/apache/brpc/issues/2756#issuecomment-2327998937 @chenBright 不是,就是rpc处理的bthread中使用的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] 疑似keytable内存泄漏 (brpc)

2024-09-03 Thread via GitHub
lsdh-fei commented on issue #2756: URL: https://github.com/apache/brpc/issues/2756#issuecomment-2328029067 @MJY-HUST 没有单独使用bthread-local,就是task_runner中的,我门最近把brpc从1.8升级到了1.10,然后就发现新版有内存泄漏,LogStream占用了大量内存,看了下brpc源代码,发现log stream的buf是存在keytable中,然后就怀疑是keytable的问题,然后看vars监控,发现keytable的数量一直在不断