Re: [PR] fix gflags bthread_concurrency_by_tag validate error (brpc)

2024-08-18 Thread via GitHub
yanglimingcn commented on PR #2730: URL: https://github.com/apache/brpc/pull/2730#issuecomment-2295510120 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[I] grpc H2UnsentResponse LeakSanitizer: detected memory leaks (brpc)

2024-08-18 Thread via GitHub
hpsdy opened a new issue, #2738: URL: https://github.com/apache/brpc/issues/2738 **Describe the bug (描述bug)** asan 压测,报h2协议brpc::policy::H2UnsentResponse::New内存泄漏 **To Reproduce (复现方法)** brpc1.8.0,h2:grpc协议。编译选项加上-fsanitize=address -fno-common,编译静态链接asan。 **Expected behavi

Re: [PR] Support A Multiple Producer, Single Consumer Queue (brpc)

2024-08-18 Thread via GitHub
yanglimingcn commented on PR #2492: URL: https://github.com/apache/brpc/pull/2492#issuecomment-2295609704 @chenBright PR里面我提了点问题,你有时间帮忙看看。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] gdb_bthread_stack.py not work. (brpc)

2024-08-18 Thread via GitHub
zhaoyulong commented on issue #2674: URL: https://github.com/apache/brpc/issues/2674#issuecomment-2295614164 > bthread_begin (gdb) source /home/yulong.zhao/brpc/tools/gdb_bthread_stack.py (gdb) bthead_begin Undefined command: "bthead_begin". Try "help". (gdb) bthread_begin

Re: [I] gdb_bthread_stack.py not work. (brpc)

2024-08-18 Thread via GitHub
zhaoyulong commented on issue #2674: URL: https://github.com/apache/brpc/issues/2674#issuecomment-2295614443 > try #2732 (gdb) source /home/yulong.zhao/brpc/tools/gdb_bthread_stack.py (gdb) bthead_begin Undefined command: "bthead_begin". Try "help". (gdb) bthread_begin war

Oncall report from Aug 12th to Aug 18th

2024-08-18 Thread Shuai Liu
Hi, all During the last week no new issues have been closed and PR merged. Best Regards, serverglen - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org

Re: [PR] Support A Multiple Producer, Single Consumer Queue (brpc)

2024-08-18 Thread via GitHub
chenBright commented on PR #2492: URL: https://github.com/apache/brpc/pull/2492#issuecomment-2295753677 > @chenBright PR里面我提了点问题,你有时间帮忙看看。 好像没看到 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Support A Multiple Producer, Single Consumer Queue (brpc)

2024-08-18 Thread via GitHub
yanglimingcn commented on PR #2492: URL: https://github.com/apache/brpc/pull/2492#issuecomment-2295801526 _cur_enqueue_node看上去每次执行都要设置成NULL,这个是必要的吗? 是不是把 node = _cur_enqueue_node.load(memory_order_relaxed);换成 node = _cur_enqueue_node.exchange(NULL, memory_order_relaxed); 就可以了呢? 你们在实际

Re: [PR] Support A Multiple Producer, Single Consumer Queue (brpc)

2024-08-18 Thread via GitHub
yanglimingcn commented on PR #2492: URL: https://github.com/apache/brpc/pull/2492#issuecomment-2295802186 > > @chenBright PR里面我提了点问题,你有时间帮忙看看。 > > 好像没看到 _cur_enqueue_node看上去每次执行都要设置成NULL,这个是必要的吗? 是不是把 node = _cur_enqueue_node.load(memory_order_relaxed);换成 node = _cur_enque