Re: [I] 如何在requestMeta当中设置 traceId, parentSpanId, spanId? (brpc)

2024-06-09 Thread via GitHub
wwbmmm commented on issue #2656: URL: https://github.com/apache/brpc/issues/2656#issuecomment-2157374309 brpc并没有暴露给用户修改RequestMeta中的traceid/spanid/parentspanid的方法,而且如你所说,brpc std协议中定义的这几个id都是long型,可能不能满足需求。 但也可以考虑通过其它字段来传递这几个id。比如std协议在这个PR https://github.com/apache/brpc/pull/2406 之后提供了自

Re: [PR] [feat] latency scale factor (brpc)

2024-06-09 Thread via GitHub
wwbmmm merged PR #2655: URL: https://github.com/apache/brpc/pull/2655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: [feat] latency scale factor (#2655)

2024-06-09 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 556e56b4 [feat] latency scale factor (#2655) 556e5

Re: [PR] fixbug: there is a ',' before 'quantile=' when labels is empty (brpc)

2024-06-09 Thread via GitHub
wwbmmm merged PR #2659: URL: https://github.com/apache/brpc/pull/2659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: fixbug: there is a ',' before 'quantile=' when labels is empty (#2659)

2024-06-09 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new f8558b00 fixbug: there is a ',' before 'quantile='

Re: [PR] Use butil::ThreadLocal to store keytable (brpc)

2024-06-09 Thread via GitHub
wwbmmm commented on code in PR #2645: URL: https://github.com/apache/brpc/pull/2645#discussion_r1632645911 ## src/bthread/key.cpp: ## @@ -204,14 +205,57 @@ class BAIDU_CACHELINE_ALIGNMENT KeyTable { SubKeyTable* _subs[KEY_1STLEVEL_SIZE]; }; +class KeyTableList { +public:

Re: [PR] Use butil::ThreadLocal to store keytable (brpc)

2024-06-09 Thread via GitHub
wwbmmm commented on PR #2645: URL: https://github.com/apache/brpc/pull/2645#issuecomment-2157454749 对这个场景有点疑问,如果bthread生命周期很短,为什么还要使用bthread_local变量呢,用pthread local、局部变量或者通过函数参数传递不行吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Oncall report from Jun 3rd to Jun 10th

2024-06-09 Thread Weibing Wang
Hi, all During last week, 5 issues were closed, and the following 10 PRs were merged: * fixbug: there is a ',' before 'quantile=' when labels is empty: https://github.com/apache/brpc/pull/2659 * [feat] latency scale factor: https://github.com/apache/brpc/pull/2655 * Support thread local object it