[I] bvar::PassiveStatus 无法暴露指标 (brpc)

2024-05-28 Thread via GitHub
shishc9 opened a new issue, #2653: URL: https://github.com/apache/brpc/issues/2653 你好,咨询一下 PassiveStatus 设计初衷是什么呢,或者针对哪些场景? 根据 [bvar::PassiveStatus\](https://github.com/apache/brpc/blob/master/docs/cn/bvar_c%2B%2B.md#bvarpassivestatus) 文档,process_username 不能作为指标暴露出去,这个特化模板正确使用方法是什么呢? -

Re: [PR] circuit breaker with half open state (brpc)

2024-05-28 Thread via GitHub
zyearn commented on code in PR #2634: URL: https://github.com/apache/brpc/pull/2634#discussion_r1617050132 ## src/brpc/circuit_breaker.cpp: ## @@ -188,6 +197,20 @@ bool CircuitBreaker::OnCallEnd(int error_code, int64_t latency) { if (_broken.load(butil::memory_order_relaxe

Re: [PR] Use butil::ThreadLocal to store keytable (brpc)

2024-05-28 Thread via GitHub
chenBright commented on code in PR #2645: URL: https://github.com/apache/brpc/pull/2645#discussion_r1617125722 ## src/bthread/key.cpp: ## @@ -204,14 +205,54 @@ class BAIDU_CACHELINE_ALIGNMENT KeyTable { SubKeyTable* _subs[KEY_1STLEVEL_SIZE]; }; +class KeyTableList { +pub

Re: [PR] circuit breaker with half open state (brpc)

2024-05-28 Thread via GitHub
jiangyt-git commented on code in PR #2634: URL: https://github.com/apache/brpc/pull/2634#discussion_r1617205807 ## src/brpc/circuit_breaker.cpp: ## @@ -188,6 +197,20 @@ bool CircuitBreaker::OnCallEnd(int error_code, int64_t latency) { if (_broken.load(butil::memory_order_r

Re: [PR] Use butil::ThreadLocal to store keytable (brpc)

2024-05-28 Thread via GitHub
MJY-HUST commented on code in PR #2645: URL: https://github.com/apache/brpc/pull/2645#discussion_r1617418262 ## src/bthread/key.cpp: ## @@ -204,14 +205,54 @@ class BAIDU_CACHELINE_ALIGNMENT KeyTable { SubKeyTable* _subs[KEY_1STLEVEL_SIZE]; }; +class KeyTableList { +publi

Re: [PR] Use butil::ThreadLocal to store keytable (brpc)

2024-05-28 Thread via GitHub
chenBright commented on code in PR #2645: URL: https://github.com/apache/brpc/pull/2645#discussion_r1618089611 ## test/bthread_key_unittest.cpp: ## @@ -385,19 +388,21 @@ TEST(KeyTest, using_pool) { ASSERT_EQ(0, bthread_start_urgent(&bth, &attr, pool_thread, &bth_data));