jiangyt-git commented on code in PR #2634:
URL: https://github.com/apache/brpc/pull/2634#discussion_r1615913983
##
src/brpc/circuit_breaker.cpp:
##
@@ -45,6 +46,10 @@ DEFINE_int32(circuit_breaker_max_isolation_duration_ms,
3,
"Maximum isolation duration in milliseconds
MJY-HUST commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1615932183
##
src/bthread/key.cpp:
##
@@ -204,14 +205,54 @@ class BAIDU_CACHELINE_ALIGNMENT KeyTable {
SubKeyTable* _subs[KEY_1STLEVEL_SIZE];
};
+class KeyTableList {
+publi
MJY-HUST commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1615932183
##
src/bthread/key.cpp:
##
@@ -204,14 +205,54 @@ class BAIDU_CACHELINE_ALIGNMENT KeyTable {
SubKeyTable* _subs[KEY_1STLEVEL_SIZE];
};
+class KeyTableList {
+publi
MJY-HUST commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1615932183
##
src/bthread/key.cpp:
##
@@ -204,14 +205,54 @@ class BAIDU_CACHELINE_ALIGNMENT KeyTable {
SubKeyTable* _subs[KEY_1STLEVEL_SIZE];
};
+class KeyTableList {
+publi
chenBright commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1615950548
##
src/bthread/key.cpp:
##
@@ -204,14 +205,54 @@ class BAIDU_CACHELINE_ALIGNMENT KeyTable {
SubKeyTable* _subs[KEY_1STLEVEL_SIZE];
};
+class KeyTableList {
+pub
MJY-HUST commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1616004571
##
src/bthread/key.cpp:
##
@@ -234,11 +234,12 @@ class KeyTableList {
};
static KeyTable* borrow_keytable(bthread_keytable_pool_t* pool) {
-if (pool != NULL && (p
MJY-HUST commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1616004767
##
src/bthread/key.cpp:
##
@@ -273,8 +274,9 @@ void return_keytable(bthread_keytable_pool_t* pool,
KeyTable* kt) {
delete kt;
return;
}
-kt->n
ballontt commented on issue #2052:
URL: https://github.com/apache/brpc/issues/2052#issuecomment-2133669737
> 1. ，使用 cut() 函数避免 copy，直接引用 iobuf 中的数据来 deserialize，避免原来
请教一下，接收端如何使用cut来避免copy？brpc中的cutn()函数实现都是有copy的。
--
This is an automated message from the Apache Git Service.
To resp
corznoc opened a new issue, #2652:
URL: https://github.com/apache/brpc/issues/2652
**Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)**
leveldb已经老旧化，是否考虑切到rocksdb
**Describe the solution you'd like (描述你期望的解决方法)**
期待支持切到rocksdb，或者编译时运行不使用leveldb。
如果不使用内建服务，应该不依赖
wwbmmm commented on PR #2634:
URL: https://github.com/apache/brpc/pull/2634#issuecomment-2134433391
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
10 matches
Mail list logo
