Re: [PR] Add virtual destructors to MongoServiceAdaptor and SpanFilter (brpc)

2024-05-24 Thread via GitHub
yozhao commented on PR #2651: URL: https://github.com/apache/brpc/pull/2651#issuecomment-2128873260 嗯 大意了,改过来了。 lei he ***@***.***> 于2024年5月24日周五 14:16写道: > ***@***. commented on this pull request. > -- > > In src/brpc/span.h >

Re: [PR] Mongo client support (brpc)

2024-05-24 Thread via GitHub
jiangdongzi commented on PR #2171: URL: https://github.com/apache/brpc/pull/2171#issuecomment-2128898253 不支持auth? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [I] 我在brpc实现了mongo的客户端, 对于无返回的请求, 该如何处理呢? 静静的等待超时? (brpc)

2024-05-24 Thread via GitHub
jiangdongzi commented on issue #2636: URL: https://github.com/apache/brpc/issues/2636#issuecomment-2128914091 > 设置notify_on_success后,不会 如果直接返回, 那么回包后controller, request, response析构了怎么办, 还是说只支持不回包的请求? -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Opt performance of async log (brpc)

2024-05-24 Thread via GitHub
Superskyyy commented on PR #2602: URL: https://github.com/apache/brpc/pull/2602#issuecomment-2128949264 Hi, let's merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [I] brpcDummyServer成功启动但无法工作问题 (brpc)

2024-05-24 Thread via GitHub
Georgexzp closed issue #2649: brpcDummyServer成功启动但无法工作问题 URL: https://github.com/apache/brpc/issues/2649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Opt performance of async log (brpc)

2024-05-24 Thread via GitHub
chenBright commented on PR #2602: URL: https://github.com/apache/brpc/pull/2602#issuecomment-2129192263 @wwbmmm 这个PR应该可以合了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T