Re: [I] BUG? Response执行完先于IssueRPC中的bthread_id_unlock执行完毕的话, unlock会失败吧? (brpc)

chenBright commented on issue #2646: URL: https://github.com/apache/brpc/issues/2646#issuecomment-2124024905 bthread_id_unlock的返回值是什么？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] BUG? Response执行完先于IssueRPC中的bthread_id_unlock执行完毕的话, unlock会失败吧? (brpc)

jiangdongzi commented on issue #2646: URL: https://github.com/apache/brpc/issues/2646#issuecomment-2124152249 > bthread_id_unlock的返回值是什么？ 22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[I] 308 Unknown status code (brpc)

zengkui opened a new issue, #2647: URL: https://github.com/apache/brpc/issues/2647 **Describe the bug (描述bug)** 使用brpc实现了一个http client 发送请求到公司内部的一个web server上 ，同样的这个代码 使用brpc 1.7.0 返回的结果是 [E1010]HTTP/1.1 308 Unknown status code (308)。 而使用brpc 1.1.0 请求是正常的。 **To Reproduce (复现方法)**

Re: [PR] fix compiler optimize thread local variable access (brpc)

zcfh commented on PR #2156: URL: https://github.com/apache/brpc/pull/2156#issuecomment-2124600518 > 另外还有一个疑问是，函数 task_runner 和 tls_task_group 不都是在一个编译单元内吗？为什么是开启lto后才会触发这个问题呢。 这个差异找到了。和clang对tls变量访问的选择有关。如果使用-fPIC编译 + 分布式 thinlto ，clang-16之前都会出现这种行为差异，[具体原因](https://discourse.llvm.org/t/h

[I] 遇到一个编译问题 (brpc)

yozhao opened a new issue, #2648: URL: https://github.com/apache/brpc/issues/2648 third_party/brpc-1.9.0/src/brpc/span.h:207:7: error: ‘class brpc::SpanFilter’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor] class SpanFilter { ^~~

Re: [PR] Small FlatMap optimization with default initialization (brpc)

javeme commented on PR #2620: URL: https://github.com/apache/brpc/pull/2620#issuecomment-2124823943 Because the usage difference with std::map, FlatMap is unfriendly to use. I think this PR is a good improvement. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] BUG? Response执行完先于IssueRPC中的bthread_id_unlock执行完毕的话, unlock会失败吧? (brpc)

chenBright commented on issue #2646: URL: https://github.com/apache/brpc/issues/2646#issuecomment-2126065790 发rpc的时候，已经lock bthread_id了，bthread_id_unlock_and_destroy实际是在bthread_id_unlock里被调的，这在设计的时候已经考虑到了。 bthread_id的使用是不是有改动？或者定位一下这个EINVAL返回值实际是哪里返回的。 -- This is an automated messa

Re: [I] 308 Unknown status code (brpc)

chenBright commented on issue #2647: URL: https://github.com/apache/brpc/issues/2647#issuecomment-2126073352 308是server响应的状态码。如果server响应308状态码的话，http rpc就会失败。这块逻辑没有改动过。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Use object_pool to store keytable by gflag (brpc)

MJY-HUST commented on PR #2645: URL: https://github.com/apache/brpc/pull/2645#issuecomment-2126086597 @chenBright hello，我根据讨论修改了实现，可以帮忙看一下么 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Small FlatMap optimization with default initialization (brpc)

chenBright commented on PR #2620: URL: https://github.com/apache/brpc/pull/2620#issuecomment-2126132016 There are some unknown crash issues. This PR will be opened after these issues are resolved. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Set protected branches and limit merge methods (brpc)

CalvinKirs closed pull request #1872: Set protected branches and limit merge methods URL: https://github.com/apache/brpc/pull/1872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen