Re: [PR] Support thread local object iteration (brpc)

2024-05-06 Thread via GitHub
chenBright commented on code in PR #2632: URL: https://github.com/apache/brpc/pull/2632#discussion_r1591734105 ## src/butil/thread_key.h: ## @@ -187,9 +205,9 @@ void ThreadLocal::reset(T* ptr) { } // Remove and delete old_ptr. if (old_ptr) { -

Re: [PR] bthread set concurrency by tag (brpc)

2024-05-06 Thread via GitHub
MalikHou commented on code in PR #2628: URL: https://github.com/apache/brpc/pull/2628#discussion_r1591748003 ## src/brpc/server.cpp: ## @@ -902,6 +902,17 @@ int Server::StartInternal(const butil::EndPoint& endpoint, _tl_options = ThreadLocalOptions(); } +auto

Re: [PR] Support proxy and generic call of baidu protocol (brpc)

2024-05-06 Thread via GitHub
chenBright commented on code in PR #2629: URL: https://github.com/apache/brpc/pull/2629#discussion_r1591749339 ## src/brpc/controller.h: ## @@ -305,7 +305,9 @@ friend void policy::ProcessThriftRequest(InputMessageBase*); // Get/own SampledRequest for sending dumped requests

Re: [PR] Support proxy and generic call of baidu protocol (brpc)

2024-05-06 Thread via GitHub
chenBright commented on code in PR #2629: URL: https://github.com/apache/brpc/pull/2629#discussion_r1591749339 ## src/brpc/controller.h: ## @@ -305,7 +305,9 @@ friend void policy::ProcessThriftRequest(InputMessageBase*); // Get/own SampledRequest for sending dumped requests

Re: [PR] Support proxy and generic call of baidu protocol (brpc)

2024-05-06 Thread via GitHub
chenBright commented on code in PR #2629: URL: https://github.com/apache/brpc/pull/2629#discussion_r1591749586 ## src/brpc/controller.h: ## @@ -305,7 +305,9 @@ friend void policy::ProcessThriftRequest(InputMessageBase*); // Get/own SampledRequest for sending dumped requests

Re: [PR] bthread set concurrency by tag (brpc)

2024-05-06 Thread via GitHub
MalikHou commented on code in PR #2628: URL: https://github.com/apache/brpc/pull/2628#discussion_r1591749942 ## docs/cn/bthread_tagged_task_group.md: ## @@ -22,18 +22,23 @@ FLAGS_bthread_concurrency为所有分组的线程数的上限,FLAGS_bthread_mi 一般情况应用创建的bthread不需要设置bthread_attr_t的tag字段,创建的bthr

Re: [PR] Support thread local object iteration (brpc)

2024-05-06 Thread via GitHub
chenBright commented on code in PR #2632: URL: https://github.com/apache/brpc/pull/2632#discussion_r1591734105 ## src/butil/thread_key.h: ## @@ -187,9 +205,9 @@ void ThreadLocal::reset(T* ptr) { } // Remove and delete old_ptr. if (old_ptr) { -

Re: [PR] Support thread local object iteration (brpc)

2024-05-06 Thread via GitHub
chenBright commented on code in PR #2632: URL: https://github.com/apache/brpc/pull/2632#discussion_r1591750821 ## src/butil/thread_key.h: ## @@ -187,9 +205,9 @@ void ThreadLocal::reset(T* ptr) { } // Remove and delete old_ptr. if (old_ptr) { -

[PR] circuit breaker with half open state (brpc)

2024-05-06 Thread via GitHub
jiangyt-git opened a new pull request, #2634: URL: https://github.com/apache/brpc/pull/2634 ### What problem does this PR solve? 解决server在夯住的情况下,比如可以响应ping请求、但没法响应业务逻辑请求时,单次ping请求成功就可以从熔断恢复,然后需要重新采样才能继续熔断的问题。 Issue Number: Problem Summary: ### What is changed and

Re: [PR] bthread set concurrency by tag (brpc)

2024-05-06 Thread via GitHub
MalikHou commented on PR #2628: URL: https://github.com/apache/brpc/pull/2628#issuecomment-2097361642 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] bthread set concurrency by tag (brpc)

2024-05-06 Thread via GitHub
MalikHou commented on code in PR #2628: URL: https://github.com/apache/brpc/pull/2628#discussion_r1591749942 ## docs/cn/bthread_tagged_task_group.md: ## @@ -22,18 +22,23 @@ FLAGS_bthread_concurrency为所有分组的线程数的上限,FLAGS_bthread_mi 一般情况应用创建的bthread不需要设置bthread_attr_t的tag字段,创建的bthr

Re: [I] 在pthread中调用done->Run()是否会存在潜在的bthread调用? (brpc)

2024-05-06 Thread via GitHub
chenBright closed issue #2549: 在pthread中调用done->Run()是否会存在潜在的bthread调用? URL: https://github.com/apache/brpc/issues/2549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub