Re: [I] bthread 中使用 std::mutex和std::condition_variable导致线程丢失 (brpc)

2024-04-07 Thread via GitHub
Cyber-SiKu commented on issue #2590: URL: https://github.com/apache/brpc/issues/2590#issuecomment-2041384361 > 线程锁内挂起协程(协程锁、rpc、bthread_usleep等),会导致死锁。 看样子像是线程调度出去了,但是再也没有调度回来。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] CentOS编译失败,openssl版本问题 (brpc)

2024-04-07 Thread via GitHub
aMagicNeko commented on issue #2585: URL: https://github.com/apache/brpc/issues/2585#issuecomment-2041385607 我也是,解决了吗哥 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Support start KeepWrite bthread urgent (brpc)

2024-04-07 Thread via GitHub
wasphin commented on PR #2591: URL: https://github.com/apache/brpc/pull/2591#issuecomment-2041513347 [absl 4038192a57cb75f7ee671f81a3378ff4c74c4f8e](https://github.com/abseil/abseil-cpp/commit/4038192a57cb75f7ee671f81a3378ff4c74c4f8e) 中删除了 flags 库,当前使用的最新的 absl 20240116.1 没有 flags 库了,我看下怎么识

[PR] Do not link abseil interface targets (brpc)

2024-04-07 Thread via GitHub
wasphin opened a new pull request, #2592: URL: https://github.com/apache/brpc/pull/2592 ### What problem does this PR solve? Issue Number: #2591 Problem Summary: abseil targets required by protobuf may be an interface only target, which should not be linked. ### W

Re: [PR] Support start KeepWrite bthread urgent (brpc)

2024-04-07 Thread via GitHub
wasphin commented on PR #2591: URL: https://github.com/apache/brpc/pull/2591#issuecomment-2041521560 另外最新版的 protobuf(26.1)又改接口了,目前测 protobuf 22+ ci 安装的最新版的 protobuf,应该不久又会有问题🤦 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] Mixed requests cause in RPC EAGAIN error: Resource temporarily unavailable. (brpc)

2024-04-07 Thread via GitHub
stdpain closed issue #2477: Mixed requests cause in RPC EAGAIN error: Resource temporarily unavailable. URL: https://github.com/apache/brpc/issues/2477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

(brpc) branch master updated: Do not link abseil interface targets (#2592)

2024-04-07 Thread guangmingchen
This is an automated email from the ASF dual-hosted git repository. guangmingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 16ab5b5c Do not link abseil interface targe

Re: [PR] Do not link abseil interface targets (brpc)

2024-04-07 Thread via GitHub
chenBright merged PR #2592: URL: https://github.com/apache/brpc/pull/2592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.or

Re: [PR] EventDispatcher supports various IO types (brpc)

2024-04-07 Thread via GitHub
chenBright commented on code in PR #2560: URL: https://github.com/apache/brpc/pull/2560#discussion_r1555157615 ## src/brpc/event_dispatcher.h: ## @@ -21,11 +21,74 @@ #include "butil/macros.h" // DISALLOW_COPY_AND_ASSIGN #include "bthread/types.h"

Re: [PR] EventDispatcher supports various IO types (brpc)

2024-04-07 Thread via GitHub
chenBright commented on code in PR #2560: URL: https://github.com/apache/brpc/pull/2560#discussion_r1555158106 ## src/brpc/event_dispatcher.h: ## @@ -21,11 +21,74 @@ #include "butil/macros.h" // DISALLOW_COPY_AND_ASSIGN #include "bthread/types.h"

Re: [PR] EventDispatcher supports various IO types (brpc)

2024-04-07 Thread via GitHub
chenBright commented on code in PR #2560: URL: https://github.com/apache/brpc/pull/2560#discussion_r1555157615 ## src/brpc/event_dispatcher.h: ## @@ -21,11 +21,74 @@ #include "butil/macros.h" // DISALLOW_COPY_AND_ASSIGN #include "bthread/types.h"

Re: [PR] EventDispatcher supports various IO types (brpc)

2024-04-07 Thread via GitHub
wwbmmm commented on PR #2560: URL: https://github.com/apache/brpc/pull/2560#issuecomment-2041768859 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Support start KeepWrite bthread urgent (brpc)

2024-04-07 Thread via GitHub
wwbmmm commented on PR #2591: URL: https://github.com/apache/brpc/pull/2591#issuecomment-2041772676 这个优化会有实际效果吗,如果启动了KeepWrite线程,说明之前的write已经写不进去了,这时再立即KeepWrite,是不是也会写不进去,最终还是要等待epollout -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Support FastPthreadMutex contention profiler && expose FastPthreadMutex to user (brpc)

2024-04-07 Thread via GitHub
wwbmmm commented on PR #2589: URL: https://github.com/apache/brpc/pull/2589#issuecomment-2041779851 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Support on_failed callback for streaming rpc (brpc)

2024-04-07 Thread via GitHub
wwbmmm merged PR #2565: URL: https://github.com/apache/brpc/pull/2565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

Re: [I] stream感知正常和异常关闭 (brpc)

2024-04-07 Thread via GitHub
wwbmmm closed issue #2285: stream感知正常和异常关闭 URL: https://github.com/apache/brpc/issues/2285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr.

(brpc) branch master updated: Support on_failed callback for streaming rpc (#2565)

2024-04-07 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 337142f2 Support on_failed callback for streaming

Re: [PR] Support IOBuf Profiler (brpc)

2024-04-07 Thread via GitHub
wwbmmm merged PR #2497: URL: https://github.com/apache/brpc/pull/2497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: Support IOBuf Profiler (#2497)

2024-04-07 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 498c3e17 Support IOBuf Profiler (#2497) 498c3e17 i

Re: [PR] Support shutdown write and notify for success write (brpc)

2024-04-07 Thread via GitHub
wwbmmm merged PR #2547: URL: https://github.com/apache/brpc/pull/2547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: Support shutdown write and notify for success write (#2547)

2024-04-07 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new c666ea45 Support shutdown write and notify for suc

Re: [PR] Support start KeepWrite bthread urgent (brpc)

2024-04-07 Thread via GitHub
chenBright commented on PR #2591: URL: https://github.com/apache/brpc/pull/2591#issuecomment-2041785578 不一定是写不进去。大多数情况应该是StartWrite写完队头数据,但是队列里还有还有其他数据,所以启动协程KeepWrite。 不过 #2588 在压力比较大的时候,整体服务能力都下降了。只优化少数连接上的rpc回包延迟,优化应该有限吧。 -- This is an automated message from the Apache Git Servic

Re: [I] 是否可以直接执行Socket::StartWrite里的KeepWrite? (brpc)

2024-04-07 Thread via GitHub
chenBright commented on issue #2588: URL: https://github.com/apache/brpc/issues/2588#issuecomment-2041786950 @xybanpeng 可以使用 #2591 测试一下优化效果 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Oncall report from Apr 1st to Apr 7th

2024-04-07 Thread Weibing Wang
Hi, all during the last week, 4 issues were closed and the following 7 PRs were merged: * Support shutdown write and notify for success write https://github.com/apache/brpc/pull/2547 * Support IOBuf Profiler https://github.com/apache/brpc/pull/2497 * Support on_failed callback for streaming rpc h

[I] brpc作为子模块,cmake编译时error: 'z_stream' does not name a type (brpc)

2024-04-07 Thread via GitHub
aMagicNeko opened a new issue, #2593: URL: https://github.com/apache/brpc/issues/2593 **Describe the bug (描述bug)** `In file included from /root/MEVpp/third-party/brpc/src/brpc/policy/gzip_compress.h:23, from /root/MEVpp/third-party/brpc/src/brpc/builtin/flot_min_j