[I] Registered logo is incomplete (brpc)

2024-03-24 Thread via GitHub
sebbASF opened a new issue, #2579: URL: https://github.com/apache/brpc/issues/2579 The logo for bRPC which appears in the ASF logo collection is incomplete. https://apache.org/logos/?#brpc and https://apache.org/logos/res/brpc/brpc.png The letters RPC are not visible. --

Re: [I] Registered logo is incomplete (brpc)

2024-03-24 Thread via GitHub
Huixxi commented on issue #2579: URL: https://github.com/apache/brpc/issues/2579#issuecomment-2016746813 It's not visible, but the color is white so it's not that visible. Is it a problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [I] Registered logo is incomplete (brpc)

2024-03-24 Thread via GitHub
sebbASF commented on issue #2579: URL: https://github.com/apache/brpc/issues/2579#issuecomment-2016753807 Probably the most common background colour for websites is white. In particular, the logos page. Also https://brpc.apache.org/docs/users/ where various logos are displayed. What

Re: [I] Registered logo is incomplete (brpc)

2024-03-24 Thread via GitHub
Huixxi commented on issue #2579: URL: https://github.com/apache/brpc/issues/2579#issuecomment-2016766348 Ok, maybe we should replace it with a black one, just like our official website's icon https://brpc.apache.org/ . Thanks a lot. -- This is an automated message from the Apache Git Serv

Re: [I] 使用RDMA, Fail to ibv_fork_init: Operation now in progress (brpc)

2024-03-24 Thread via GitHub
Huixxi commented on issue #2566: URL: https://github.com/apache/brpc/issues/2566#issuecomment-2016772199 @Tuvie 有时间可以看下这个问题,我感觉使用不同的端口并不能屏蔽两个进程的RDMA的资源占用。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] 添加 Async Streaming RPC RDMA 相关案例 (brpc)

2024-03-24 Thread via GitHub
Huixxi commented on issue #2564: URL: https://github.com/apache/brpc/issues/2564#issuecomment-2016773808 好啊,直接提PR就行 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [I] 使用brpc提供的rpc_press进行性能测试,求问极限QPS (brpc)

2024-03-24 Thread via GitHub
Huixxi commented on issue #2533: URL: https://github.com/apache/brpc/issues/2533#issuecomment-2016773861 https://brpc.apache.org/docs/benchmark/ 目前只有这个。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] BRPC cause pybind embed hang (brpc)

2024-03-24 Thread via GitHub
Huixxi commented on issue #2559: URL: https://github.com/apache/brpc/issues/2559#issuecomment-2016775446 大概率是用法不对。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] Registered logo is incomplete (brpc)

2024-03-24 Thread via GitHub
sebbASF commented on issue #2579: URL: https://github.com/apache/brpc/issues/2579#issuecomment-2016779762 The website does use the white version, however its background is blue. The project has full control over how the logo is used on its own website, but that is not the case for log

Re: [PR] test/iobuf: fix mismatch deallocation (brpc)

2024-03-24 Thread via GitHub
Huixxi merged PR #2550: URL: https://github.com/apache/brpc/pull/2550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated (8b340f95 -> 338e95cd)

2024-03-24 Thread huixxi
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git from 8b340f95 Get gcc version by script to support cross-compile (#2567) add ad70b7fd test/iobuf: fix mismatch deallocat

(brpc) 01/01: Merge pull request #2550 from BusyJay/BusyJay-patch-1

2024-03-24 Thread huixxi
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git commit 338e95cd5428ca703587aa7c4e0dcad83aedb1e2 Merge: 8b340f95 ad70b7fd Author: HU AuthorDate: Sun Mar 24 19:47:18 2024 +0800

Re: [PR] Ignore eovercrowded for streaming control frame (brpc)

2024-03-24 Thread via GitHub
Huixxi merged PR #2571: URL: https://github.com/apache/brpc/pull/2571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

Re: [I] 使用stream,如果服务器端overcrowded后,则客户端一直卡住,直到超时 (brpc)

2024-03-24 Thread via GitHub
Huixxi closed issue #2541: 使用stream,如果服务器端overcrowded后,则客户端一直卡住,直到超时 URL: https://github.com/apache/brpc/issues/2541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

(brpc) 01/01: Merge pull request #2571 from chenBright/opt_stream_overcrowded

2024-03-24 Thread huixxi
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git commit 8f7a10ed72b3a77ee6e6be68e28da03e6d3de94a Merge: 338e95cd 151bc780 Author: HU AuthorDate: Sun Mar 24 21:10:54 2024 +0800

(brpc) branch master updated (338e95cd -> 8f7a10ed)

2024-03-24 Thread huixxi
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git from 338e95cd Merge pull request #2550 from BusyJay/BusyJay-patch-1 add 151bc780 Ignore eovercrowded for streaming contr

Oncall report from Mar 18th to Mar 24th

2024-03-24 Thread Xiguo Hu
Hi, all During the last week 2 issues were closed, 3 issues were commented on, and following 2 PRs were merged and closed: 1. Support connect on socket create #2574 2. Fix invalid headers of multiple cookie and set-cookie #2577 -

Re: [PR] EventDispatcher supports various IO types (brpc)

2024-03-24 Thread via GitHub
chenBright commented on code in PR #2560: URL: https://github.com/apache/brpc/pull/2560#discussion_r1536847585 ## src/brpc/socket_inl.h: ## @@ -176,17 +119,25 @@ inline void Socket::ReAddress(SocketUniquePtr* ptr) { } inline int Socket::AddressFailedAsWell(SocketId id, Socke

Re: [PR] Fix compile with protobuf 22-25. (brpc)

2024-03-24 Thread via GitHub
wasphin commented on code in PR #2576: URL: https://github.com/apache/brpc/pull/2576#discussion_r1537000881 ## src/brpc/protocol.cpp: ## @@ -18,13 +18,21 @@ // Since kDefaultTotalBytesLimit is private, we need some hacks to get the limit. // Works for pb 2.4, 2.6, 3.0 +#inc

Re: [PR] Fix compile with protobuf 22-25. (brpc)

2024-03-24 Thread via GitHub
ketor commented on code in PR #2576: URL: https://github.com/apache/brpc/pull/2576#discussion_r1537060645 ## src/brpc/protocol.cpp: ## @@ -18,13 +18,21 @@ // Since kDefaultTotalBytesLimit is private, we need some hacks to get the limit. // Works for pb 2.4, 2.6, 3.0 +#inclu

Re: [PR] Fix compile with protobuf 22-25. (brpc)

2024-03-24 Thread via GitHub
ketor commented on code in PR #2576: URL: https://github.com/apache/brpc/pull/2576#discussion_r1537060645 ## src/brpc/protocol.cpp: ## @@ -18,13 +18,21 @@ // Since kDefaultTotalBytesLimit is private, we need some hacks to get the limit. // Works for pb 2.4, 2.6, 3.0 +#inclu