Re: [I] http协议set-cookie header格式不符合mdn文档要求 (brpc)

2024-03-20 Thread via GitHub
chenBright commented on issue #2575: URL: https://github.com/apache/brpc/issues/2575#issuecomment-2009029395 @pirDOL 试试 #2577 能不能解决问题 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] EventDispatcher supports various IO types (brpc)

2024-03-20 Thread via GitHub
chenBright commented on code in PR #2560: URL: https://github.com/apache/brpc/pull/2560#discussion_r1533202769 ## src/brpc/socket_inl.h: ## @@ -176,17 +119,25 @@ inline void Socket::ReAddress(SocketUniquePtr* ptr) { } inline int Socket::AddressFailedAsWell(SocketId id, Socke

Re: [PR] Ignore eovercrowded for streaming control frame (brpc)

2024-03-20 Thread via GitHub
wwbmmm commented on PR #2571: URL: https://github.com/apache/brpc/pull/2571#issuecomment-2011259857 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Fix compile with protobuf 22-25. (brpc)

2024-03-20 Thread via GitHub
wwbmmm merged PR #2576: URL: https://github.com/apache/brpc/pull/2576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: Fix compile with protobuf 22-25. (#2576)

2024-03-20 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new e1447025 Fix compile with protobuf 22-25. (#2576)

Re: [PR] Support shutdown write and notify for success write (brpc)

2024-03-20 Thread via GitHub
wwbmmm commented on PR #2547: URL: https://github.com/apache/brpc/pull/2547#issuecomment-2011262495 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Support connect on socket create (brpc)

2024-03-20 Thread via GitHub
wwbmmm commented on PR #2574: URL: https://github.com/apache/brpc/pull/2574#issuecomment-2011264087 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] EventDispatcher supports various IO types (brpc)

2024-03-20 Thread via GitHub
wwbmmm commented on code in PR #2560: URL: https://github.com/apache/brpc/pull/2560#discussion_r1533283281 ## src/brpc/socket_inl.h: ## @@ -176,17 +119,25 @@ inline void Socket::ReAddress(SocketUniquePtr* ptr) { } inline int Socket::AddressFailedAsWell(SocketId id, SocketUni

(brpc) branch master updated: Update commiter doc

2024-03-20 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new e11c84dc Update commiter doc e11c84dc is described