Re: [I] http协议set-cookie header格式不符合mdn文档要求 (brpc)

2024-03-19 Thread via GitHub
chenBright commented on issue #2575: URL: https://github.com/apache/brpc/issues/2575#issuecomment-2007043794 > @chenBright > > `;`是[Attributes](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#attributes)分隔符,因此如果bRPC中需要特殊处理应使用其他符号 > > > 另外,多个Cookie之间不能使用,分隔,

Re: [PR] Support Protobuf 22 (brpc)

2024-03-19 Thread via GitHub
wasphin commented on PR #2546: URL: https://github.com/apache/brpc/pull/2546#issuecomment-2007066853 https://github.com/protocolbuffers/protobuf/blob/v3.24.0/src/google/protobuf/descriptor.h#L469 确实是 24 版本开始的 `start_number`, 当时改糊涂了 -- This is an automated message from the Apach

[PR] Fix invalid headers of multiple cookie and set-cookie (brpc)

2024-03-19 Thread via GitHub
chenBright opened a new pull request, #2577: URL: https://github.com/apache/brpc/pull/2577 ### What problem does this PR solve? Issue Number: resolve #2575 Problem Summary: 目前bRPC处理cookie和set-cookie这两个header的逻辑有问题: 1. [RFC 9114]规定:(https://datatracker.ietf.org/doc/ht

Re: [PR] Support connect on socket create (brpc)

2024-03-19 Thread via GitHub
chenBright commented on code in PR #2574: URL: https://github.com/apache/brpc/pull/2574#discussion_r1530723978 ## src/brpc/socket.h: ## @@ -198,6 +198,14 @@ struct SocketOptions { // user->BeforeRecycle() before recycling. int fd; butil::EndPoint remote_side; +