[I] http协议set-cookie header格式不符合mdn文档要求 (brpc)

2024-03-18 Thread via GitHub
pirDOL opened a new issue, #2575: URL: https://github.com/apache/brpc/issues/2575 **Describe the bug (描述bug)** [Set-Cookie - HTTP | MDN](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie) > To send multiple cookies, multiple Set-Cookie headers should be sent

Re: [I] http协议set-cookie header格式不符合mdn文档要求 (brpc)

2024-03-18 Thread via GitHub
chenBright commented on issue #2575: URL: https://github.com/apache/brpc/issues/2575#issuecomment-2003265889 多次通过调用SetHeader("Set-Cookie", xxx)来设置cookie吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] http协议set-cookie header格式不符合mdn文档要求 (brpc)

2024-03-18 Thread via GitHub
pirDOL commented on issue #2575: URL: https://github.com/apache/brpc/issues/2575#issuecomment-2003523529 @chenBright 根据HttpHeader接口来看,只有SetHeader和AppendHeader,两个接口都不能构造出http server返回响应报文中有多个set-cookie的场景,可以改用如下命令mockserver ```python #!/noah/bin/python import socket def handle

Re: [PR] Support Protobuf 22 (brpc)

2024-03-18 Thread via GitHub
ketor commented on PR #2546: URL: https://github.com/apache/brpc/pull/2546#issuecomment-2003527639 请问这个PR使用的protobuf的版本是多少呢? 用prototbuf 3.22.5版本验证,cmake编译会报错: /home/mengsz/git/other/brpc/src/json2pb/json_to_pb.cpp: In function ‘bool json2pb::JsonValueToProtoMessage(const butil::r

Re: [PR] Support Protobuf 22 (brpc)

2024-03-18 Thread via GitHub
ketor commented on PR #2546: URL: https://github.com/apache/brpc/pull/2546#issuecomment-2003754254 `#if GOOGLE_PROTOBUF_VERSION < 4025000 for (int tag_number = ext_range->start; tag_number < ext_range->end; ++tag_number) #else for (int tag_number = ext_range->start_n

Re: [I] http协议set-cookie header格式不符合mdn文档要求 (brpc)

2024-03-18 Thread via GitHub
chenBright commented on issue #2575: URL: https://github.com/apache/brpc/issues/2575#issuecomment-2004305249 [RFC-7230 Field Order](https://tools.ietf.org/html/rfc7230#section-3.2.2) In practice, the "Set-Cookie" header field ([RFC6265]) often appears multiple times in a response messag

[PR] Fix compile with protobuf 22-25. (brpc)

2024-03-18 Thread via GitHub
ketor opened a new pull request, #2576: URL: https://github.com/apache/brpc/pull/2576 ### What problem does this PR solve? Issue Number: Problem Summary: PR #2546 在Protobuf 22-24这几个版本上的编译有一些问题,在25版本上可以编译通过。同时在Rocky 8.9的GCC 13上编译发现,原有的 #define private public的方式已经不被编译器接受,也会导致编译

Re: [PR] Support shutdown write and notify for success write (brpc)

2024-03-18 Thread via GitHub
chenBright commented on code in PR #2547: URL: https://github.com/apache/brpc/pull/2547#discussion_r1529605268 ## src/brpc/socket.cpp: ## @@ -307,33 +307,56 @@ const uint32_t MAX_PIPELINED_COUNT = 16384; struct BAIDU_CACHELINE_ALIGNMENT Socket::WriteRequest { static Writ

Re: [I] http协议set-cookie header格式不符合mdn文档要求 (brpc)

2024-03-18 Thread via GitHub
pirDOL commented on issue #2575: URL: https://github.com/apache/brpc/issues/2575#issuecomment-2005696601 @chenBright 根据[Set-Cookie Syntax](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#syntax),`;`是[Attributes](https://developer.mozilla.org/en-US/docs/Web/HTTP/H