chenBright opened a new pull request, #2574:
URL: https://github.com/apache/brpc/pull/2574
### What problem does this PR solve?
Issue Number:
Problem Summary:
目前直接使用client Socket，存在两个问题：
1. 不能只连接对端，只能在第一次写入的时候连接。
2. 虽然可以先通过tcp connect获取一个fa，再通过SocketOptions.fd创建一个So
wwbmmm commented on PR #2567:
URL: https://github.com/apache/brpc/pull/2567#issuecomment-2002774169
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
wwbmmm commented on PR #2565:
URL: https://github.com/apache/brpc/pull/2565#issuecomment-2002775718
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
wwbmmm commented on PR #2497:
URL: https://github.com/apache/brpc/pull/2497#issuecomment-2002777327
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
wwbmmm merged PR #2570:
URL: https://github.com/apache/brpc/pull/2570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
F
This is an automated email from the ASF dual-hosted git repository.
wwbmmm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brpc.git
The following commit(s) were added to refs/heads/master by this push:
new 471ac5f0 Support bthread id for log (#2570)
471ac5
wwbmmm merged PR #2569:
URL: https://github.com/apache/brpc/pull/2569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
F
This is an automated email from the ASF dual-hosted git repository.
wwbmmm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brpc.git
The following commit(s) were added to refs/heads/master by this push:
new d4695c90 Add UT of ScopeGuard (#2569)
d4695c90 is
wwbmmm commented on code in PR #2571:
URL: https://github.com/apache/brpc/pull/2571#discussion_r1527722472
##
src/brpc/policy/streaming_rpc_protocol.cpp:
##
@@ -146,19 +148,24 @@ void SendStreamClose(Socket *sock, int64_t
remote_stream_id,
fm.set_frame_type(FRAME_TYPE_CLOS
wwbmmm commented on code in PR #2574:
URL: https://github.com/apache/brpc/pull/2574#discussion_r1527728690
##
src/brpc/socket.h:
##
@@ -198,6 +198,14 @@ struct SocketOptions {
// user->BeforeRecycle() before recycling.
int fd;
butil::EndPoint remote_side;
+//
wwbmmm commented on code in PR #2547:
URL: https://github.com/apache/brpc/pull/2547#discussion_r1527733464
##
src/brpc/socket.cpp:
##
@@ -307,33 +307,56 @@ const uint32_t MAX_PIPELINED_COUNT = 16384;
struct BAIDU_CACHELINE_ALIGNMENT Socket::WriteRequest {
static WriteReq
chenBright commented on code in PR #2571:
URL: https://github.com/apache/brpc/pull/2571#discussion_r1527744829
##
src/brpc/policy/streaming_rpc_protocol.cpp:
##
@@ -146,19 +148,24 @@ void SendStreamClose(Socket *sock, int64_t
remote_stream_id,
fm.set_frame_type(FRAME_TYPE_
Hi, all
During the last week 2 PR is merged:
* Fix random value of CachedReader at first time
https://github.com/apache/brpc/pull/2556
* Fix cancel callback may be called twice
https://github.com/apache/brpc/pull/2557
Best Regards,
serverglen
--
13 matches
Mail list logo
