Re: [PR] bthread task group add tag (brpc)

2024-03-07 Thread via GitHub
yanglimingcn commented on PR #2358: URL: https://github.com/apache/brpc/pull/2358#issuecomment-1983043315 > > 技术上是能实现的,但是做起来也有些复杂,同步的代码确实更好一些,否则execq里面就得调用callback了吧? > > 确实还是有同步代码的需求。有些场景如果用callback,就会使callback里的逻辑很重,虽然技术上是可以的,但是代码看起来就很难看了。 https://github.com/apache/brpc/pull/2

Re: [PR] support bthread primitive cross different worker pools (brpc)

2024-03-07 Thread via GitHub
yanglimingcn commented on PR #2551: URL: https://github.com/apache/brpc/pull/2551#issuecomment-1983124012 @wwbmmm 辛苦有时间review这个PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [I] IOBuf是否能支持连续的内存避免内存拷贝 (brpc)

2024-03-07 Thread via GitHub
wanghenshui commented on issue #2120: URL: https://github.com/apache/brpc/issues/2120#issuecomment-1983377494 mark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] 支持自定义 IOBuf Block size (brpc)

2024-03-07 Thread via GitHub
yanglimingcn commented on issue #2555: URL: https://github.com/apache/brpc/issues/2555#issuecomment-1984982553 这个会有PR吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] 支持自定义 IOBuf Block size (brpc)

2024-03-07 Thread via GitHub
Superskyyy commented on issue #2555: URL: https://github.com/apache/brpc/issues/2555#issuecomment-1985019741 > 这个会有PR吗 两周内我会推pr,我还在验证下这样做会不会在什么场景下有副作用 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[I] 添加 Async Streaming RPC RDMA 相关案例 (brpc)

2024-03-07 Thread via GitHub
Superskyyy opened a new issue, #2564: URL: https://github.com/apache/brpc/issues/2564 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** 文档其实没提到 Streaming RPC 是否可以用 RDMA,怎么实现 Async callback,以及性能如何。我这边用到后确认是没问题的,所以准备添加个几个example。 **Describe the solution you'd like