Re: [PR] fix compiler optimize thread local variable access (brpc)

2024-03-04 Thread via GitHub
zcfh commented on PR #2156: URL: https://github.com/apache/brpc/pull/2156#issuecomment-1976430923 目前从clang11 切换 到clang16 遇到了一些新的问题。和 #1776 提到的问题应该是一样的,不过我看**1776对应的代码并没有合入**, 是有做了其他修复吗。 对比了汇编,这样差异在于326-331 行这段代码(version 0.96) ```c++ // Clean tls variables, must be done

Re: [I] brpc编译错误 (brpc)

2024-03-04 Thread via GitHub
1797818494 commented on issue #1392: URL: https://github.com/apache/brpc/issues/1392#issuecomment-1976553107 同样的问题,有解决的吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] brpc编译错误 (brpc)

2024-03-04 Thread via GitHub
1797818494 commented on issue #1392: URL: https://github.com/apache/brpc/issues/1392#issuecomment-1976555306 ![image](https://github.com/apache/brpc/assets/92515062/a3c99e0e-e540-46f7-961b-66ed2768d871) ![image](https://github.com/apache/brpc/assets/92515062/2d2667de-532f-47f3-8bae-8

[PR] EventDispatcher supports various IO types (brpc)

2024-03-04 Thread via GitHub
chenBright opened a new pull request, #2560: URL: https://github.com/apache/brpc/pull/2560 ### What problem does this PR solve? Issue Number: resolve #2381 Problem Summary: ### What is changed and the side effects? Changed: 1. 将SocketId的功能抽象到VersionedRefWi

Re: [I] EventDispatcher支持不同类型fd (brpc)

2024-03-04 Thread via GitHub
chenBright commented on issue #2381: URL: https://github.com/apache/brpc/issues/2381#issuecomment-1976865640 @yanglimingcn 有空看看,提了个PR #2560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Support Protobuf 22 (brpc)

2024-03-04 Thread via GitHub
wasphin commented on PR #2546: URL: https://github.com/apache/brpc/pull/2546#issuecomment-1976919647 未进行生产环境验证,需谨慎使用。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[I] 疑似DoublyBufferedData::WrapperTLSGroup一处笔误 (brpc)

2024-03-04 Thread via GitHub
shanhe72101 opened a new issue, #2561: URL: https://github.com/apache/brpc/issues/2561 **Describe the bug (描述bug)** 代码位置src/butil/containers/doubly_buffered_data.h template class DoublyBufferedData::WrapperTLSGroup { public: const static size_t RAW_BLOCK_SIZE = 409

Re: [I] brpc编译错误 (brpc)

2024-03-04 Thread via GitHub
TousakaRin commented on issue #1392: URL: https://github.com/apache/brpc/issues/1392#issuecomment-1977903132 @1797818494 一般这种undefined reference的问题,首先利用 gcc -print-search-dirs 或者 ld --verbose | grep SEARCH_DIR 找到系统里寻找 so 的路径,还有上面编译命令里指定的 -L 后面的路径,从这里路径里找到 libprotobuf.so 这个文件,然后利用 objdump/nm

Re: [I] 疑似DoublyBufferedData::WrapperTLSGroup一处笔误 (brpc)

2024-03-04 Thread via GitHub
chenBright commented on issue #2561: URL: https://github.com/apache/brpc/issues/2561#issuecomment-1978029444 欢迎提PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs