Re: [I] struct/class that require cacheline alignment may not work when using new (before c++17). (brpc)

2024-02-26 Thread via GitHub
uvletter commented on issue #2416: URL: https://github.com/apache/brpc/issues/2416#issuecomment-1963741713 ``` = ==155368==ERROR: AddressSanitizer: new-delete-type-mismatch on 0x62130d00 in thread T22 (brpc_timer):

Re: [I] struct/class that require cacheline alignment may not work when using new (before c++17). (brpc)

2024-02-26 Thread via GitHub
ehds commented on issue #2416: URL: https://github.com/apache/brpc/issues/2416#issuecomment-1964341023 > ``` > = > ==155368==ERROR: AddressSanitizer: new-delete-type-mismatch on 0x62130d00 in thread T22 (brpc_timer):

Re: [I] struct/class that require cacheline alignment may not work when using new (before c++17). (brpc)

2024-02-26 Thread via GitHub
uvletter commented on issue #2416: URL: https://github.com/apache/brpc/issues/2416#issuecomment-1964383015 Thx, my current workaround is compiling brpc with std=c++17 too. Just wanna report the unworkable cacheline alignment and underlying risk in mixed compilation units. 获取 Outlook

Re: [PR] enable aligned new if supported (brpc)

2024-02-26 Thread via GitHub
uvletter commented on PR #2421: URL: https://github.com/apache/brpc/pull/2421#issuecomment-1965752700 The solution is not sophisticated in my opinion. The brpc header file may be included in other translation units, which could be not aligned-new, so the final artifact will be a mixture of

[I] 在pthread中调用done (brpc)

2024-02-26 Thread via GitHub
coyorkdow opened a new issue, #2548: URL: https://github.com/apache/brpc/issues/2548 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** **Describe the solution you'd like (描述你期望的解决方法)** **Describe alternatives you've considered (描述你想到的折衷方案)**

Re: [I] 在pthread中调用done (brpc)

2024-02-26 Thread via GitHub
coyorkdow closed issue #2548: 在pthread中调用done URL: https://github.com/apache/brpc/issues/2548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

Re: [I] 在pthread中调用done (brpc)

2024-02-26 Thread via GitHub
coyorkdow closed issue #2548: 在pthread中调用done URL: https://github.com/apache/brpc/issues/2548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[I] 在pthread中调用done->Run()是否会存在潜在的bthread调用? (brpc)

2024-02-26 Thread via GitHub
coyorkdow opened a new issue, #2549: URL: https://github.com/apache/brpc/issues/2549 在异步的服务端代码中,我们把请求入口处的done对象保存了下来。再之后某个时间,请求处理完成后,再调用done->Run()。 显然,在请求入口的时候,代码是在bthread中运行的。但是假如我们在异步服务的实现中,保证调用done->Run()的环境一定不是bthread,那么该调用是否会有潜在的调用会在bthread中运行呢?更具体来说,是HttpResponseSenderAsDone::R