[PR] WIP: Support Protbuf 22 (brpc)

2024-02-25 Thread via GitHub
wasphin opened a new pull request, #2546: URL: https://github.com/apache/brpc/pull/2546 ### What problem does this PR solve? Issue Number: close #2537 Problem Summary: compatible with protobuf >= 22 ### What is changed and the side effects? Changed: Side ef

Re: [PR] WIP: Support Protbuf 22 (brpc)

2024-02-25 Thread via GitHub
wasphin commented on PR #2546: URL: https://github.com/apache/brpc/pull/2546#issuecomment-1962955207 还有几个问题需要讨论一下: 1. 目前编译方式有多种, 有一定维护成本: - cmake 和 bazel 相对标准, 依赖外部工具; - config_brpc.sh 是自定义的用于生成 makefile 的配置脚本, 是否有必要再保留? 1. Protobuf 22 Log 迁移 absl 后, 需要自定义 absl 的 LogSink 实现自

Re: [PR] Support Protobuf 22 (brpc)

2024-02-25 Thread via GitHub
wasphin commented on code in PR #2546: URL: https://github.com/apache/brpc/pull/2546#discussion_r1501831395 ## CMakeLists.txt: ## @@ -156,6 +154,50 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU") endif() find_package(Protobuf REQUIRED) +if(Protobuf_VERSION GREATER_EQUAL 4.22) +

[PR] Support shutdown write and notify for success write (brpc)

2024-02-25 Thread via GitHub
chenBright opened a new pull request, #2547: URL: https://github.com/apache/brpc/pull/2547 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: 1. 支持半关闭:无需SetFailed,关闭写入端,但不影响读数据。 2. 支持在数据写

Re: [PR] Support Protobuf 22 (brpc)

2024-02-25 Thread via GitHub
wwbmmm commented on PR #2546: URL: https://github.com/apache/brpc/pull/2546#issuecomment-1963223910 > 还有几个问题需要讨论一下: > > 1. 目前编译方式有多种, 有一定维护成本: > >* cmake 和 bazel 相对标准, 依赖外部工具; >* config_brpc.sh 是自定义的用于生成 makefile 的配置脚本, 是否有必要再保留? > 2. Protobuf 22 Log 迁移 absl 后,

(brpc) branch master updated: Fix gflags bthread_concurrency_by_tag validate failed (#2543)

2024-02-25 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 2d411176 Fix gflags bthread_concurrency_by_tag val

Re: [PR] Fix gflags bthread_concurrency_by_tag validate failed (brpc)

2024-02-25 Thread via GitHub
wwbmmm merged PR #2543: URL: https://github.com/apache/brpc/pull/2543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

Re: [PR] Support timed connect for both bthread and pthread (brpc)

2024-02-25 Thread via GitHub
wwbmmm merged PR #2524: URL: https://github.com/apache/brpc/pull/2524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: Support timed connect for both bthread and pthread (#2524)

2024-02-25 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new bcb42862 Support timed connect for both bthread an

Re: [PR] Support bthread_once and bthread singleton (brpc)

2024-02-25 Thread via GitHub
wwbmmm merged PR #2520: URL: https://github.com/apache/brpc/pull/2520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: Support bthread_once and bthread singleton (#2520)

2024-02-25 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new eac19012 Support bthread_once and bthread singleto

Re: [PR] span for new bthread (brpc)

2024-02-25 Thread via GitHub
wwbmmm merged PR #2519: URL: https://github.com/apache/brpc/pull/2519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: span for new bthread (#2519)

2024-02-25 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 24fc31ea span for new bthread (#2519) 24fc31ea is

Re: [PR] Support IOBuf Profiler (brpc)

2024-02-25 Thread via GitHub
wwbmmm commented on code in PR #2497: URL: https://github.com/apache/brpc/pull/2497#discussion_r1501991142 ## src/butil/iobuf_profiler.cpp: ## @@ -0,0 +1,307 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NO

Re: [I] Gflags 解析报错:ERROR: --bthread_concurrency_by_tag must be set on the commandline (default value fails validation) (brpc)

2024-02-25 Thread via GitHub
wwbmmm closed issue #2542: Gflags 解析报错:ERROR: --bthread_concurrency_by_tag must be set on the commandline (default value fails validation) URL: https://github.com/apache/brpc/issues/2542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] 内置服务是否可以观测 streaming rpc (brpc)

2024-02-25 Thread via GitHub
wwbmmm commented on issue #2545: URL: https://github.com/apache/brpc/issues/2545#issuecomment-1963232579 目前还不支持监控streamwrite的请求 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Oncall report from Feb 20 to Feb 26

2024-02-25 Thread Weibing Wang
Hi, all during the last week, 4 issues were closed and the following 5 PRs were merged: * Support timed connect for both bthread and pthread https://github.com/apache/brpc/pull/2524 * Support bthread_once and bthread singleton https://github.com/apache/brpc/pull/2520 * span for new bthread https:

Re: [I] 内置服务是否可以观测 streaming rpc (brpc)

2024-02-25 Thread via GitHub
Superskyyy commented on issue #2545: URL: https://github.com/apache/brpc/issues/2545#issuecomment-1963359574 > 目前还不支持监控streamwrite的请求 > 目前还不支持监控streamwrite的请求 谢谢,请问 streaming 的方式通常来说是否应该比普通rpc的性能要高?我在项目里集成了brpc streaming后发现在传输的对象越大性能越差 正在排查是我们的代码的问题还是 streaming rpc 使用起来有什么要