Re: [VOTE] Release Apache bRPC 1.7.0

2023-11-01 Thread James Ge
+1 binding I've checked [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] Source code distributions have correct names matching the current release. Best regards, James On Fri, Oct 27, 2023 at 9:09 PM Lorin Lee wrote: > Hi Apache bRPC Community, > > This is a call

Re: [VOTE] Release Apache bRPC 1.7.0

2023-11-01 Thread Jiashun Zhu
+1 binding. I have checked - [x] the links of the package are valid; - [x] the checksum of the package is valid; - [x] the signature of the package is valid; - [x] RELEASE_VERSION in the source code matches the current release; - [x] LICENSE and NOTICE are not absent, note that we use CI based on

[I] 服务端latency统计时间可能有误 (brpc)

2023-11-01 Thread via GitHub
FancyJan opened a new issue, #2437: URL: https://github.com/apache/brpc/issues/2437 **Describe the bug (描述bug)** 写一个简单的client去压测单机server,获取如下两个指标: client耗时:通过brpc::Controller::latency_us()获取 server耗时:通过bvar中的对应latency bvar获取 之前我们使用的版本是0.9.7,client侧耗时会明显大于server耗时,符合预期 最近升级到

Re: [PR] bthread task group add tag (brpc)

2023-11-01 Thread via GitHub
yanglimingcn commented on PR #2358: URL: https://github.com/apache/brpc/pull/2358#issuecomment-1788869486 int bthread_set_tagged_worker_startfn(void (*start_fn)(bthread_tag_t)); 我觉得这样的函数使用上有点受限,很多时候需要给这个startfn传递一个参数,去做一些thread local的初始化工作。 改成 int bthread_set_tagged_worker_startfn(void

Re: [VOTE] Release Apache bRPC 1.7.0

2023-11-01 Thread Shuai Liu
+1 non-binding. I have checked - [x] the links of the package are valid; - [x] the checksum of the package is valid; - [x] the signature of the package is valid; - [x] RELEASE_VERSION in the source code matches the current release; - [x] LICENSE and NOTICE are not absent, note that we use CI based

Re: [PR] fix ErrorToString (brpc)

2023-11-01 Thread via GitHub
darionyaphet closed pull request #1297: fix ErrorToString URL: https://github.com/apache/brpc/pull/1297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix server start process and remove some argument (brpc)

2023-11-01 Thread via GitHub
darionyaphet closed pull request #1299: Fix server start process and remove some argument URL: https://github.com/apache/brpc/pull/1299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] Remove useless and (brpc)

2023-11-01 Thread via GitHub
darionyaphet opened a new pull request, #2438: URL: https://github.com/apache/brpc/pull/2438 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):