Re: [PR] lalb try left server nodes (brpc)

2023-10-27 Thread via GitHub
wwbmmm commented on PR #2428: URL: https://github.com/apache/brpc/pull/2428#issuecomment-1782740122 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [I] server支持OnNewConnection(...), OnClosedConnection(...)回调 (brpc)

2023-10-27 Thread via GitHub
wwbmmm commented on issue #2424: URL: https://github.com/apache/brpc/issues/2424#issuecomment-1782747516 > 我们可以在AuthContext新增属性:on_destroy_context(AuthContext* ctx), 用户通过out_ctx->set_destroy_context注册回调。 > > 在Socket::OnRecycle中delete _auth_context 之前,调用其on_destroy_context回调函数。

Re: [PR] Fuzzing move fuzz test in main repo add more fuzz test (brpc)

2023-10-27 Thread via GitHub
wwbmmm commented on PR #2420: URL: https://github.com/apache/brpc/pull/2420#issuecomment-1782751836 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[VOTE] Release Apache bRPC 1.7.0

2023-10-27 Thread Lorin Lee
Hi Apache bRPC Community, This is a call for vote to release Apache bRPC version 1.7.0 [Release Note] Feature: * Support pthread mode for ExecutionQueue by @chenBright in #2333 * Add wireshark dissector for baidu_std protocol by @wasphin in #2408 * selective_channel 支持返回response_attachment by @yo

[PR] Fix http verbose memory leak (brpc)

2023-10-27 Thread via GitHub
chenBright opened a new pull request, #2429: URL: https://github.com/apache/brpc/pull/2429 ### What problem does this PR solve? Issue Number: Problem Summary: rpc失败了,导致HttpMessage提前析构,不一定会delete _vmsgbuilder,有可能导致_vmsgbuilder泄露。 ### What is changed and the side eff

Re: [I] server支持OnNewConnection(...), OnClosedConnection(...)回调 (brpc)

2023-10-27 Thread via GitHub
antkiller996 commented on issue #2424: URL: https://github.com/apache/brpc/issues/2424#issuecomment-1783660291 > > 我们可以在AuthContext新增属性:on_destroy_context(AuthContext* ctx), 用户通过out_ctx->set_destroy_context注册回调。 > > 在Socket::OnRecycle中delete _auth_context 之前,调用其on_destroy_context回调函数。