[GitHub] [incubator-brpc] lorinlee commented on issue #2033: thrift模式done->Run()无法提前回复客户端

2022-12-04 Thread GitBox
lorinlee commented on issue #2033: URL: https://github.com/apache/incubator-brpc/issues/2033#issuecomment-1336358412 这个原因是thrift和baidu_std对异常的处理方式不同。baidu_std在框架侧没有捕获异常,thrift捕获了异常并且设置了cntl。 thrift这样的实现,在调用用户callback时,如果catch到了异常,是需要保证cntl还有效的,因为需要将错误设置到cntl。而done->Run()如果将rpc返回了,那相应

[GitHub] [incubator-brpc] lorinlee closed issue #2032: ExecutionQueue是严格有序的么, A B依次提交, 是否可以保证B任务必然在A任务完成后开始执行

2022-12-04 Thread GitBox
lorinlee closed issue #2032: ExecutionQueue是严格有序的么, A B依次提交, 是否可以保证B任务必然在A任务完成后开始执行 URL: https://github.com/apache/incubator-brpc/issues/2032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [incubator-brpc] zhaocc1106 commented on issue #2033: thrift模式done->Run()无法提前回复客户端

2022-12-04 Thread GitBox
zhaocc1106 commented on issue #2033: URL: https://github.com/apache/incubator-brpc/issues/2033#issuecomment-1336375306 > ProcessThriftFramedRequestNoExcept 好的,感谢,我看下。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-brpc] Tuvie opened a new pull request, #2034: fix bug: QP cannot be put back to QP pool

2022-12-04 Thread GitBox
Tuvie opened a new pull request, #2034: URL: https://github.com/apache/incubator-brpc/pull/2034 ### What problem does this PR solve? Issue Number: Problem Summary: fix a QP leak bug ### What is changed and the side effects? Changed: Modify the condition to move QP

[GitHub] [incubator-brpc] Tuvie closed pull request #2034: fix bug: QP cannot be put back to QP pool

2022-12-04 Thread GitBox
Tuvie closed pull request #2034: fix bug: QP cannot be put back to QP pool URL: https://github.com/apache/incubator-brpc/pull/2034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [incubator-brpc] chenBright opened a new pull request, #2035: only allow to convert root array to single repeated pb

2022-12-04 Thread GitBox
chenBright opened a new pull request, #2035: URL: https://github.com/apache/incubator-brpc/pull/2035 ### What problem does this PR solve? Issue Number: Problem Summary: 目前打开single_repeated_to_array开关后,pb转json只支持root case,但是打开array_to_single_repeated开关,json转pb没有限制root case。这

[GitHub] [incubator-brpc] wasphin commented on pull request #2035: only allow to convert root array to single repeated pb

2022-12-04 Thread GitBox
wasphin commented on PR #2035: URL: https://github.com/apache/incubator-brpc/pull/2035#issuecomment-1336434709 > ### What problem does this PR solve? > Issue Number: > > Problem Summary: 目前打开single_repeated_to_array开关后,pb转json只支持root case,但是打开array_to_single_repeated开关,json转pb没有限制r

[GitHub] [incubator-brpc] Tuvie opened a new pull request, #2036: fix bug: QP cannot be put back to QP pool

2022-12-04 Thread GitBox
Tuvie opened a new pull request, #2036: URL: https://github.com/apache/incubator-brpc/pull/2036 What problem does this PR solve? Issue Number: Problem Summary: fix a QP leak bug What is changed and the side effects? Changed: Modify the condition to move QP back to QP pool

[GitHub] [incubator-brpc] chenBright commented on pull request #2035: only allow to convert root array to single repeated pb

2022-12-04 Thread GitBox
chenBright commented on PR #2035: URL: https://github.com/apache/incubator-brpc/pull/2035#issuecomment-1336627772 > > ### What problem does this PR solve? > > Issue Number: > > Problem Summary: 目前打开single_repeated_to_array开关后,pb转json只支持root case,但是打开array_to_single_repeated开关,json转pb没有

[GitHub] [incubator-brpc] wwbmmm opened a new pull request, #2037: Fix demangle core

2022-12-04 Thread GitBox
wwbmmm opened a new pull request, #2037: URL: https://github.com/apache/incubator-brpc/pull/2037 ### What problem does this PR solve? Issue Number: #2025 Problem Summary: Segfault in demangle ### What is changed and the side effects? Changed: verify pointer before

[GitHub] [incubator-brpc] wwbmmm merged pull request #2035: only allow to convert root array to single repeated pb

2022-12-04 Thread GitBox
wwbmmm merged PR #2035: URL: https://github.com/apache/incubator-brpc/pull/2035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apa

[incubator-brpc] branch master updated: only allow to convert root array to single repeated pb

2022-12-04 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new a0bc7db4 only allow to convert root arra

Oncall report from Nov 28st to Dec 4th

2022-12-04 Thread Lorin Lee
Hi all, we have merged 9 PRs last week, * change os tag of Linux workflow from ubuntu-latest to ubuntu-20.04 * fix some typos * Make GenericDocument's handler public to enable ouside parser/writer * Add Action Badge and Remove Travis file * Fix MacOS warning: bool literal returned from 'main' [-W

[GitHub] [incubator-brpc] lorinlee opened a new pull request, #2038: Update oncall.md

2022-12-04 Thread GitBox
lorinlee opened a new pull request, #2038: URL: https://github.com/apache/incubator-brpc/pull/2038 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性

[GitHub] [incubator-brpc] wwbmmm merged pull request #2038: Update oncall.md

2022-12-04 Thread GitBox
wwbmmm merged PR #2038: URL: https://github.com/apache/incubator-brpc/pull/2038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apa

[incubator-brpc] branch master updated (4f59bc64 -> bdbd92a4)

2022-12-04 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git from 4f59bc64 Merge pull request #2035 from chenBright/root_single_array add bdbd92a4 Update oncall.md (#2038)

Re: Hi, mentors,please review and sign off on the pod report,thanks

2022-12-04 Thread Jerry Tan
thanks for trista‘s sign-off on the pod report. we still need JB's sign-off. Hi, JB, could you please help to do that? thanks. On 2022/11/29 03:25:14 Jerry Tan wrote: > https://cwiki.apache.org/confluence/display/INCUBATOR/December2022#brpc > > it may be the last pod report。 > > please sign of

[GitHub] [incubator-brpc] wwbmmm commented on issue #2025: 使用cmake编译example里echo_c++进程启动即报Segmentation fault: 11

2022-12-04 Thread GitBox
wwbmmm commented on issue #2025: URL: https://github.com/apache/incubator-brpc/issues/2025#issuecomment-1336672187 @SillyBoyenjoy 可以试试PR #2037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

New release manager for version 1.4.0

2022-12-04 Thread Weibing Wang
Hi, all After discussion, we assign Xiaofeng to be the release manager for version 1.4.0. Looking forward to his good job. Best regards Weibing - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands,

Re: New release manager for version 1.4.0

2022-12-04 Thread Shuai Liu
Looking forward to the 1.4.0 release by Xiaofeng. Best Regards, serverglen Weibing Wang 于2022年12月5日周一 11:11写道: > Hi, all > > After discussion, we assign Xiaofeng to be the release manager for > version 1.4.0. Looking forward to his good job. > > > Best regards > Weibing > > ---

Re: New release manager for version 1.4.0

2022-12-04 Thread Jerry Tan
cool. Welcome xiaofeng. On 2022/12/05 03:11:35 Weibing Wang wrote: > Hi, all > > After discussion, we assign Xiaofeng to be the release manager for > version 1.4.0. Looking forward to his good job. > > > Best regards > Weibing > > ---

Re: Oncall report from Nov 28st to Dec 4th

2022-12-04 Thread Jerry Tan
thanks,lorin On 2022/12/05 02:32:01 Lorin Lee wrote: > Hi all, > > we have merged 9 PRs last week, > > * change os tag of Linux workflow from ubuntu-latest to ubuntu-20.04 > * fix some typos > * Make GenericDocument's handler public to enable ouside parser/writer > * Add Action Badge and Remove

[GitHub] [incubator-brpc] ChinaChenp commented on pull request #1814: fix ssl state exception coredump

2022-12-04 Thread GitBox
ChinaChenp commented on PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#issuecomment-1336726349 我们刚好也遇到这个问题,居然已经修复了,感谢大佬们的贡献; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-brpc] zhaocc1106 opened a new issue, #2039: thrift模式下使用java客户端thrift原生api访问容易失败,服务端没有收到请求

2022-12-04 Thread GitBox
zhaocc1106 opened a new issue, #2039: URL: https://github.com/apache/incubator-brpc/issues/2039 **Describe the bug (描述bug)** 使用thrift模式搭建服务,java客户端使用thrift原生api访问,容易出现下面的错误: Caused by: org.apache.thrift.transport.TTransportException at org.apache.thrift.transport.TIOStreamTr

[GitHub] [incubator-brpc] ldak4747 opened a new issue, #2040: brpc的multi-label的bvar,是否可以支持,label的动态释放?

2022-12-04 Thread GitBox
ldak4747 opened a new issue, #2040: URL: https://github.com/apache/incubator-brpc/issues/2040 实际场景如: metric都是同一个metric(multi-label的MVariable) 1、根据索引的上线,增加metric的对应label 2、当索引下线,删除metric的对应label -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-brpc] serverglen commented on issue #2040: brpc的multi-label的bvar,是否可以支持,label的动态释放?

2022-12-04 Thread GitBox
serverglen commented on issue #2040: URL: https://github.com/apache/incubator-brpc/issues/2040#issuecomment-1336813489 本周我提交下,内部版本已经支持了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [incubator-brpc] wwbmmm commented on issue #2039: thrift模式下使用java客户端thrift原生api访问容易失败,服务端没有收到请求

2022-12-04 Thread GitBox
wwbmmm commented on issue #2039: URL: https://github.com/apache/incubator-brpc/issues/2039#issuecomment-1336814175 有TTransportException的报错具体信息吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [incubator-brpc] ldak4747 commented on issue #2040: brpc的multi-label的bvar,是否可以支持,label的动态释放?

2022-12-04 Thread GitBox
ldak4747 commented on issue #2040: URL: https://github.com/apache/incubator-brpc/issues/2040#issuecomment-1336823107 非常的感谢,我怎么能及时知道更新呢? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [incubator-brpc] serverglen commented on pull request #2037: Fix demangle core

2022-12-04 Thread GitBox
serverglen commented on PR #2037: URL: https://github.com/apache/incubator-brpc/pull/2037#issuecomment-1336826037 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [incubator-brpc] zhaocc1106 commented on issue #2039: thrift模式下使用java客户端thrift原生api访问容易失败,服务端没有收到请求

2022-12-04 Thread GitBox
zhaocc1106 commented on issue #2039: URL: https://github.com/apache/incubator-brpc/issues/2039#issuecomment-1336828570 > 直接触发了thrift jar的exception,看起来是read返回信息时抛出的,但是服务端没有收到这条信息。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-brpc] zhaocc1106 commented on issue #2039: thrift模式下使用java客户端thrift原生api访问容易失败,服务端没有收到请求

2022-12-04 Thread GitBox
zhaocc1106 commented on issue #2039: URL: https://github.com/apache/incubator-brpc/issues/2039#issuecomment-1336828764 > 有TTransportException的报错具体信息吗 直接触发了thrift jar的exception,看起来是read返回信息时抛出的,但是服务端没有收到这条信息。 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-brpc] serverglen commented on issue #2040: brpc的multi-label的bvar,是否可以支持,label的动态释放?

2022-12-04 Thread GitBox
serverglen commented on issue #2040: URL: https://github.com/apache/incubator-brpc/issues/2040#issuecomment-1336832407 我提交完后,在这里at你,你也可以[订阅brpc邮件](https://brpc.apache.org/zh/docs/community/mailing_list/)。 另外:欢迎提交 [贵公司的使用案例](https://github.com/apache/incubator-brpc/issues/1640),帮助bRPC越来越

[GitHub] [incubator-brpc] zhaocc1106 commented on issue #2039: thrift模式下使用java客户端thrift原生api访问容易失败,服务端没有收到请求

2022-12-04 Thread GitBox
zhaocc1106 commented on issue #2039: URL: https://github.com/apache/incubator-brpc/issues/2039#issuecomment-1336846278 > 有TTransportException的报错具体信息吗 thrift jar里对应代码位置的细节见如下截图: ![image](https://user-images.githubusercontent.com/26559935/205573745-3f0d8ed8-313e-4ab7-a99b-44a191c361