Hi, guys,
Apache brpc (incubating) has learned and grown much since our
incubation in 2018-11-13. It is almost 4 years now. How time flies.
Now, I'm glad to call on a discussion about whether we are ready for
graduation.
if we all agree， I will call for a vote for the graduate.
Updates sin
welcome, zhaogeng.
On 2022/10/26 02:15:55 Hu go wrote:
> Welcome Zhaogeng.
>
> Best Regards,
> Xiguo
>
> On Wed, Oct 26, 2022 at 10:00 AM Weibing Wang wrote:
> >
> > Welcome!
> >
> > On Wed, Oct 26, 2022 at 9:55 AM Shuai Liu wrote:
> > >
> > > Welcome Zhaogeng.
> > >
> > > Best Regards,
> > >
wwbmmm commented on code in PR #1965:
URL: https://github.com/apache/incubator-brpc/pull/1965#discussion_r1005438299
##
src/butil/endpoint.cpp:
##
@@ -304,12 +304,17 @@ int str2endpoint(const char* ip_str, int port, EndPoint*
point) {
int hostname2endpoint(const char* str, E
wwbmmm commented on PR #1965:
URL: https://github.com/apache/incubator-brpc/pull/1965#issuecomment-1291755562
建议补充一下边界值的单测
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
wwbmmm commented on PR #1964:
URL: https://github.com/apache/incubator-brpc/pull/1964#issuecomment-1291786786
LGTM
@serverglen 有空也看看
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
HehuaTang opened a new issue, #1966:
URL: https://github.com/apache/incubator-brpc/issues/1966
**Describe the bug (描述bug)**
# git pull
Already up-to-date.
# git branch
* master
rdma-old
# pwd
/root/rdma/incubator-brpc/example/rdma_performance/bu
make client
[ 25%]
cdjingit commented on PR #1964:
URL: https://github.com/apache/incubator-brpc/pull/1964#issuecomment-1291852611
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
serverglen commented on code in PR #1964:
URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1005599888
##
src/brpc/builtin/prometheus_metrics_service.cpp:
##
@@ -200,6 +200,13 @@ int DumpPrometheusMetricsToIOBuf(butil::IOBuf* output) {
return -1;
welcome zhaogeng
Jerry Tan 于2022年10月26日周三 17:03写道：
> welcome, zhaogeng.
>
> On 2022/10/26 02:15:55 Hu go wrote:
> > Welcome Zhaogeng.
> >
> > Best Regards,
> > Xiguo
> >
> > On Wed, Oct 26, 2022 at 10:00 AM Weibing Wang wrote:
> > >
> > > Welcome!
> > >
> > > On Wed, Oct 26, 2022 at 9:55 AM Shu
HehuaTang commented on issue #1966:
URL:
https://github.com/apache/incubator-brpc/issues/1966#issuecomment-1291991775
cmake -DWITH_RDMA=on . # in brpc project's directory can fixed this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
HehuaTang closed issue #1966: 编译链接错误
URL: https://github.com/apache/incubator-brpc/issues/1966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
Tuvie commented on issue #1966:
URL:
https://github.com/apache/incubator-brpc/issues/1966#issuecomment-1292111741
This is because brpc is not compile with rdma. Let me add a warning for this
kind of mistake.
--
This is an automated message from the Apache Git Service.
To respond to the m
Tuvie opened a new pull request, #1967:
URL: https://github.com/apache/incubator-brpc/pull/1967
### What problem does this PR solve?
Issue Number: 1966
Problem Summary:
When brpc is not compiled with rdma, a binary may not be linked correctly if
the application invoke i
Welcome Zhaogeng.
Thank you for your contribution of RDMA to brpc.
Best Regards.
On Wed, Oct 26, 2022 at 8:48 PM fisherman wrote:
> welcome zhaogeng
>
> Jerry Tan 于2022年10月26日周三 17:03写道：
>
> > welcome, zhaogeng.
> >
> > On 2022/10/26 02:15:55 Hu go wrote:
> > > Welcome Zhaogeng.
> > >
> > > Be
chenBright opened a new pull request, #1968:
URL: https://github.com/apache/incubator-brpc/pull/1968
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects
guodongxiaren commented on PR #1899:
URL: https://github.com/apache/incubator-brpc/pull/1899#issuecomment-1292212191
@zyearn 改了以后还有其他地方失败
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
zyearn commented on PR #1899:
URL: https://github.com/apache/incubator-brpc/pull/1899#issuecomment-1292515385
看了下主要是两个地方：
```
I1026 15:17:31 5891 bthread_butex_unittest.cpp:61] Joined thread 4294969088
at 232338us [0]
Expected: (labs(elp - (th - (bthread_t*)arg + 1) * 10L)) <=
zyearn commented on PR #1968:
URL: https://github.com/apache/incubator-brpc/pull/1968#issuecomment-1292523595
这里”使能“应该是enable的意思
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
zyearn commented on code in PR #1967:
URL: https://github.com/apache/incubator-brpc/pull/1967#discussion_r1006103478
##
src/brpc/rdma/rdma_helper.cpp:
##
@@ -633,4 +633,19 @@ bool SupportedByRdma(std::string protocol) {
} // namespace rdma
} // namespace brpc
-#endif // i
hope to test it fully before 1.4 release
On 2022/10/25 06:12:01 Weibing Wang wrote:
> Since bRPC 1.3.0 has been released, I have merged the RDMA feature
> into master branch.
>
> RDMA usage doc:
> https://github.com/apache/incubator-brpc/blob/master/docs/cn/rdma.md
>
> Next we will collect rdma
+1, thanks Jerry for bringing up this discussion, glad to see the bRPC
project moving forward.
On 2022/10/26 09:01:29 Jerry Tan wrote:
> Hi, guys,
>
>
> Apache brpc (incubating) has learned and grown much since our
>
> incubation in 2018-11-13. It is almost 4 years now. How time flies.
>
>
This is an automated email from the ASF dual-hosted git repository.
jerrytan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new 99055916 Update newcommitter.md
990559
+1, thanks Jerry, This is really good news.
Best Regards,
serverglen
Wang Xiaofeng 于2022年10月27日周四 08:12写道：
>
> +1, thanks Jerry for bringing up this discussion, glad to see the bRPC
> project moving forward.
>
> On 2022/10/26 09:01:29 Jerry Tan wrote:
> > Hi, guys,
> >
> >
> > Apache brpc (inc
wwbmmm commented on PR #1899:
URL: https://github.com/apache/incubator-brpc/pull/1899#issuecomment-1292871987
目前有很多case是关于时间判断的，但macos执行过慢，可能会造成这些case非常不稳定，要不先跳过mac上的ut执行？先把mac编译加到CI里
后面可能需要系统地理一下这些case
--
This is an automated message from the Apache Git Service.
To respond to the messa
guodongxiaren commented on PR #1899:
URL: https://github.com/apache/incubator-brpc/pull/1899#issuecomment-1292873706
> 目前有很多case是关于时间判断的，但macos执行过慢，可能会造成这些case非常不稳定，要不先跳过mac上的ut执行？先把mac编译加到CI里
>
> 后面可能需要系统地理一下这些case
可以。我晚点改一下
--
This is an automated message from the Apache Gi
+1, a long-awaited milestone!
Shuai Liu 于2022年10月27日周四 10:06写道：
> +1, thanks Jerry, This is really good news.
>
> Best Regards,
> serverglen
>
>
> Wang Xiaofeng 于2022年10月27日周四 08:12写道：
>
> >
> > +1, thanks Jerry for bringing up this discussion, glad to see the bRPC
> > project moving forward.
>
Welcome!
Wang Wei 于2022年10月26日周三 22:30写道：
>
> Welcome Zhaogeng.
> Thank you for your contribution of RDMA to brpc.
>
> Best Regards.
>
> On Wed, Oct 26, 2022 at 8:48 PM fisherman wrote:
>
> > welcome zhaogeng
> >
> > Jerry Tan 于2022年10月26日周三 17:03写道：
> >
> > > welcome, zhaogeng.
> > >
> > > On
Welcome zhaogeng!
Thanks for your contributions!
Lorin Lee 于2022年10月27日周四 10:21写道：
> Welcome!
>
> Wang Wei 于2022年10月26日周三 22:30写道：
> >
> > Welcome Zhaogeng.
> > Thank you for your contribution of RDMA to brpc.
> >
> > Best Regards.
> >
> > On Wed, Oct 26, 2022 at 8:48 PM fisherman wrote:
> >
>
+1, brpc is being used so widely and has so big impact, glad to see
it's graduation!!!
Best Regards,
Lorin Lee
牟盖东 于2022年10月27日周四 10:18写道：
>
> +1, a long-awaited milestone!
>
> Shuai Liu 于2022年10月27日周四 10:06写道：
>
> > +1, thanks Jerry, This is really good news.
> >
> > Best Regards,
> > serverg
+1
Since I joined the brpc community, I have seen that the community grows rapidly:
We released new versions every quarter following the Apache workflow.
We attract more and more committers from different companies.
We discuss more in the mail list.
We meet online and offline to make the community
This is an automated email from the ASF dual-hosted git repository.
jerrytan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new 84c77340 Update newcommitter.md
84c773
+1, glad to see our community became more active and diverse.
Please give a look and fix the issues [1] before we officially call for the
graduation vote, Thanks.
[1] https://incubator.apache.org/clutch/brpc.html
--
Tris
+1, a big time!
Best regards,
Xiguo
On Thu, Oct 27, 2022 at 11:16 AM Trista Pan wrote:
>
> +1, glad to see our community became more active and diverse.
> Please give a look and fix the issues [1] before we officially call for the
> graduation vote, Thanks.
>
>
> [1] https://incubator.apache.or
Thanks, Trista
I will update the podling website to fix the issue.
Best regards
Weibing
On Thu, Oct 27, 2022 at 11:16 AM Trista Pan wrote:
>
> +1, glad to see our community became more active and diverse.
> Please give a look and fix the issues [1] before we officially call for the
> graduatio
cdjingit commented on code in PR #1964:
URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1006382654
##
src/brpc/builtin/prometheus_metrics_service.cpp:
##
@@ -32,6 +32,8 @@ DECLARE_int32(bvar_latency_p2);
DECLARE_int32(bvar_latency_p3);
}
+DEFINE_bool(mvar
Tuvie commented on code in PR #1967:
URL: https://github.com/apache/incubator-brpc/pull/1967#discussion_r1006397471
##
src/brpc/rdma/rdma_helper.cpp:
##
@@ -633,4 +633,19 @@ bool SupportedByRdma(std::string protocol) {
} // namespace rdma
} // namespace brpc
-#endif // if
+1, thanks Jerry, I have been looking forward to graduation for a long time.
Best regards
Wang Wei
On Thu, Oct 27, 2022 at 11:54 AM Wang,Weibing wrote:
> Thanks, Trista
>
> I will update the podling website to fix the issue.
>
> Best regards
> Weibing
>
> On Thu, Oct 27, 2022 at 11:16 AM Trista
serverglen opened a new issue, #100:
URL: https://github.com/apache/incubator-brpc-website/issues/100
目前的下载地址是：https://brpc.apache.org/docs/downloadbrpc/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
wasphin commented on issue #100:
URL:
https://github.com/apache/incubator-brpc-website/issues/100#issuecomment-1293003978
同时需要考虑对先前地址的兼容，毕竟已经对外提供了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Huixxi merged PR #101:
URL: https://github.com/apache/incubator-brpc-website/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@br
serverglen commented on code in PR #1964:
URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1006420523
##
src/brpc/builtin/prometheus_metrics_service.cpp:
##
@@ -32,6 +32,8 @@ DECLARE_int32(bvar_latency_p2);
DECLARE_int32(bvar_latency_p3);
}
+DEFINE_bool(mv
serverglen commented on code in PR #1964:
URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1006422609
##
src/brpc/builtin/prometheus_metrics_service.cpp:
##
@@ -32,6 +32,8 @@ DECLARE_int32(bvar_latency_p2);
DECLARE_int32(bvar_latency_p3);
}
+DEFINE_bool(mv
wwbmmm merged PR #102:
URL: https://github.com/apache/incubator-brpc-website/pull/102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@br
cdjingit commented on code in PR #1964:
URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1006438537
##
src/brpc/builtin/prometheus_metrics_service.cpp:
##
@@ -32,6 +32,8 @@ DECLARE_int32(bvar_latency_p2);
DECLARE_int32(bvar_latency_p3);
}
+DEFINE_bool(mvar
chenBright commented on PR #1968:
URL: https://github.com/apache/incubator-brpc/pull/1968#issuecomment-1293058910
> 这里”使能“应该是enable的意思
那这个表述是没问题的吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
serverglen commented on code in PR #1964:
URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1006453757
##
src/brpc/builtin/prometheus_metrics_service.cpp:
##
@@ -32,6 +32,8 @@ DECLARE_int32(bvar_latency_p2);
DECLARE_int32(bvar_latency_p3);
}
+DEFINE_bool(mv
serverglen commented on code in PR #1964:
URL: https://github.com/apache/incubator-brpc/pull/1964#discussion_r1006454157
##
src/brpc/builtin/prometheus_metrics_service.cpp:
##
@@ -32,6 +32,8 @@ DECLARE_int32(bvar_latency_p2);
DECLARE_int32(bvar_latency_p3);
}
+DEFINE_bool(mv
Tuvie commented on PR #1968:
URL: https://github.com/apache/incubator-brpc/pull/1968#issuecomment-1293060921
>
这里原意确实就是使能(enable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
chenBright commented on PR #1968:
URL: https://github.com/apache/incubator-brpc/pull/1968#issuecomment-1293062221
> >
>
> 这里原意确实就是使能(enable)
哦哦，好的，那我close这个PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chenBright closed pull request #1968: fix typo in rdma doc
URL: https://github.com/apache/incubator-brpc/pull/1968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
50 matches
Mail list logo
