[GitHub] [incubator-brpc] cdjingit commented on issue #1453: rdma 有开源计划吗?

2021-07-01 Thread GitBox
cdjingit commented on issue #1453: URL: https://github.com/apache/incubator-brpc/issues/1453#issuecomment-871996762 https://github.com/apache/incubator-brpc/tree/rdma 这个版本支持 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-brpc] cdjingit commented on issue #1454: brpc支持pb3

2021-07-01 Thread GitBox
cdjingit commented on issue #1454: URL: https://github.com/apache/incubator-brpc/issues/1454#issuecomment-872113664 可以详细列一下你们内部方案可能改动的点吗?我认为框架层面需要兼容protobuf2的。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-brpc] cdjingit commented on issue #1449: bthread: bthread_setspecific may cause memory leak

2021-07-01 Thread GitBox
cdjingit commented on issue #1449: URL: https://github.com/apache/incubator-brpc/issues/1449#issuecomment-872138808 @lorinlee As doc [description](https://github.com/apache/incubator-brpc/blob/master/docs/cn/server.md#bthread-local), seems we MUST call bthread_getspecific to check KeyTabl

[GitHub] [incubator-brpc] wwbmmm opened a new issue #1455: Socket::WaitAndReset内存泄露

2021-07-01 Thread GitBox
wwbmmm opened a new issue #1455: URL: https://github.com/apache/incubator-brpc/issues/1455 **Describe the bug (描述bug)** heap profiling结果: ![image](https://user-images.githubusercontent.com/3894631/124116125-2d53f980-daa1-11eb-8a05-dcb8e541cf81.png) **To Reproduce (复现方法)**

[GitHub] [incubator-brpc] wwbmmm opened a new pull request #1456: Fix Socket::WaitAndReset memory leak #1455

2021-07-01 Thread GitBox
wwbmmm opened a new pull request #1456: URL: https://github.com/apache/incubator-brpc/pull/1456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: de

Apache brpc(Incubating) github issue weekly oncall report ( 21/06/2021 - 27/06/2021)

2021-07-01 Thread Lorin Lee
Hi all, Here is the Apache brpc(Incubating) github issue weekly oncall report from 21/06/2021 to 27/06/2021. This week we resolved 6 issues as below 1. https://github.com/apache/incubator-brpc/issues/1443 2. https://github.com/apache/incubator-brpc/issues/1436 3. https://github.com/

[incubator-brpc] annotated tag 1.0.0-rc01 updated (60f2a47 -> fbd3e28)

2021-07-01 Thread lorinlee
This is an automated email from the ASF dual-hosted git repository. lorinlee pushed a change to annotated tag 1.0.0-rc01 in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git. *** WARNING: tag 1.0.0-rc01 was modified! *** from 60f2a47 (commit) to fbd3e28 (tag) taggin

[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1433: Controller增加回调函数,用以支持在响应client之后,request/response析构之前执行一些自定义逻辑

2021-07-01 Thread GitBox
guodongxiaren commented on pull request #1433: URL: https://github.com/apache/incubator-brpc/pull/1433#issuecomment-872300187 > #1300 这个可以提供类似的功能,供参考,不过需要注意一下control,request, response的析构顺序 不太一样吧。我这个偏业务,比如我是要根据业务场景的上下文状态,从request、response中**一次性**取出一些pb字段,组成一个json 或者新的pb,发给kafka。

[GitHub] [incubator-brpc] guodongxiaren commented on a change in pull request #1433: Controller增加回调函数,用以支持在响应client之后,request/response析构之前执行一些自定义逻辑

2021-07-01 Thread GitBox
guodongxiaren commented on a change in pull request #1433: URL: https://github.com/apache/incubator-brpc/pull/1433#discussion_r662347923 ## File path: example/http_c++/http_server.cpp ## @@ -190,10 +197,12 @@ int main(int argc, char* argv[]) { // Start the server. b

[GitHub] [incubator-brpc] wwbmmm commented on pull request #1314: implement weighted randomized load balancer #1254

2021-07-01 Thread GitBox
wwbmmm commented on pull request #1314: URL: https://github.com/apache/incubator-brpc/pull/1314#issuecomment-872659963 > 1.可以简单描述一下这个需求吗,方便我们理解。 > 3.为什么? 由于rr和wrr都是基于TLS实现轮询的,在用户pthread数量很多的场景下,容易出现负载不均衡,这时使用random/wr可以达到更好的负载均衡的效果 -- This is an automated message from the Apache

Re: Apache brpc(Incubating) github issue weekly oncall report ( 21/06/2021 - 27/06/2021)

2021-07-01 Thread Wang,Weibing
1. Support passes the client's timeout to the server and the server can get the client's timeout by calling Controller::timeout_us(). Related issue: https://github.com/apache/incubator-brpc/issues/1440 2. Support any type of data in baidu-std's response. Just like Se

[GitHub] [incubator-brpc] wwbmmm commented on issue #1449: bthread: bthread_setspecific may cause memory leak

2021-07-01 Thread GitBox
wwbmmm commented on issue #1449: URL: https://github.com/apache/incubator-brpc/issues/1449#issuecomment-872665659 I had encountered this problem before, finally I created a wrapper class that ensure calling bthread_getspecific before bthread_setspecific: ```cpp template cla